From 4ee24a9492c7c83952f59ecc54071c31aa68fa86 Mon Sep 17 00:00:00 2001
From: zachh <zachh@google.com>
Date: Thu, 11 Jan 2018 14:05:10 -0800
Subject: Fixed bug in handling of empty numbers in new call log.

Empty numbers were not being inserted into PhoneLookupHistory because the URI "content://.../PhoneLookupHistory/" is treated the same as "content://.../PhoneLookupHistory" (w/o the trailing slash). This caused the update (i.e. replace) operation to incorrectly update all rows in the table when it should have updated a single row.

The fix for this was to switch to a query parameter, so the empty number URI now looks like "content://.../PhoneLookupHistory?number="

Also improved some logging while debugging this problem.

Bug: 71866050
Test: unit and manual
PiperOrigin-RevId: 181659081
Change-Id: Idec4fb77e74920cd5485620b0a997db03aa8ff9b
---
 java/com/android/incallui/PhoneLookupHistoryRecorder.java | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

(limited to 'java/com/android/incallui/PhoneLookupHistoryRecorder.java')

diff --git a/java/com/android/incallui/PhoneLookupHistoryRecorder.java b/java/com/android/incallui/PhoneLookupHistoryRecorder.java
index 667c0d1cc..8517deb65 100644
--- a/java/com/android/incallui/PhoneLookupHistoryRecorder.java
+++ b/java/com/android/incallui/PhoneLookupHistoryRecorder.java
@@ -66,10 +66,7 @@ final class PhoneLookupHistoryRecorder {
             appContext
                 .getContentResolver()
                 .update(
-                    PhoneLookupHistory.CONTENT_URI
-                        .buildUpon()
-                        .appendEncodedPath(normalizedNumber.get())
-                        .build(),
+                    PhoneLookupHistory.contentUriForNumber(normalizedNumber.get()),
                     contentValues,
                     null,
                     null);
-- 
cgit v1.2.3