| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Change-Id: I0597dbb5ea12511c347c1bd08c2a12db5d57bd81
|
|
|
|
| |
Change-Id: I27570067fb094bbcc5b4bb6d72755fcd6ff9cf0b
|
|
|
|
|
| |
Test: make
Change-Id: Ib75f4f25e91067311de244d7f1fb95bc898aec22
|
|
|
|
|
|
|
|
|
|
| |
The self provisioning gateway expects 10 digit US national number.
TEST=manual, VVM subscription cannot be automated.
Bug: 110390254
Test: manual, VVM subscription cannot be automated.
PiperOrigin-RevId: 202695056
Change-Id: I9368a4e04d50f4a402d994f7bef3fb1e4b654940
|
|
|
|
|
|
| |
Test: Existing tests
PiperOrigin-RevId: 202589482
Change-Id: I6982e4069d30032bf46caf3c9984dfc0e7196f6f
|
|
|
|
|
|
|
|
|
|
| |
this will show the "Can't active visual voicemail" message
TEST=TAP
Bug: 110390254
Test: TAP
PiperOrigin-RevId: 201979303
Change-Id: I265dcc616ae6f14e00ae20ce2ea914d3c3b85a49
|
|
|
|
|
|
|
|
|
|
|
|
| |
activated yet.
On VVM3 if subscription failed, the alternative form SMS will still be sent by the carrier. In this state dialer should fallback to legacy voicemail notification.
TEST=manual - disable auto subscription in code, check legacy voicemail notification functionality.
Bug: 109896901
Test: manual - disable auto subscription in code, check legacy voicemail notification functionality.
PiperOrigin-RevId: 200113818
Change-Id: I55b70e7a8b2cd3d8b40864fa03b2ba209037f4e8
|
|
|
|
|
|
|
|
|
|
|
|
| |
getCarrierConfig() is @Nullable. While the default implementation always return a bundle, this is not true for other carrier apps.
ShadowTelephonyManager.getCarrierConfig() now return null as default to catch this behavior.
TEST=TAP
Bug: 80629471
Test: TAP
PiperOrigin-RevId: 199327865
Change-Id: I7416bee3d5f5307919c6825fc74c26f25b6b001f
|
|
|
|
|
|
|
|
|
|
| |
The SIM may no longer be valid, but the rest of the deactivation process should still go through.
TEST=TAP
Bug: 79476712
Test: TAP
PiperOrigin-RevId: 199174445
Change-Id: I52d6030320f2675ac74fc06470e3cd8f33b613b8
|
|
|
|
|
|
|
|
|
| |
It no longer provides any value, so just use dagger directly.
Bug: 80441695
Test: tap
PiperOrigin-RevId: 198806461
Change-Id: Id607abb65b77633bce511ad0c943ac19453a85d5
|
|
|
|
|
|
|
|
|
|
| |
Previously the phoneAccountHandle is validated before creating the CarrierIdentifier, but it seems like there's a chance that it would be invalidated in the gap before the identifier is created.
TEST=TAP
Bug: 73890027
Test: TAP
PiperOrigin-RevId: 197172168
Change-Id: I6f4f77819ed6ce9f3449f7e47a3538af1098d826
|
|
|
|
|
|
| |
Test: presubmit.
PiperOrigin-RevId: 196158524
Change-Id: Iec1e457039e97be0236cd700d397b4095ee3c2c3
|
|
|
|
|
|
|
|
|
|
| |
These reflection calls are used for the transition period when amending VVM APIs in O. The public version should be used now.
TEST=TAP
Bug: 77334965
Test: TAP
PiperOrigin-RevId: 193095281
Change-Id: Ifaf2e78f007a155221146b40369aaed66d4325c6
|
|
|
|
|
|
|
|
| |
TEST=TAP
Bug: 77838297
Test: TAP
PiperOrigin-RevId: 192534802
Change-Id: I9c6b0aaab33f5ae5e9d26131c7a9a2858005c385
|
|
|
|
|
|
|
|
| |
TEST=Manual
Bug: 77838297
Test: Manual
PiperOrigin-RevId: 192343100
Change-Id: I2f054d432c54359b99dcf4e15d9059abdda91293
|
|
|
|
|
|
|
|
|
| |
In this CL, the client will stop treating text/* attachments as transcrptions for T-mobile. Transcriptions are already disabled by the device type sent during provisioning so this will not affect any existing functionality. This prevents other data on the server showing up as transcription.
Bug: 77342321
Test: TAP, exact behavior not testable.
PiperOrigin-RevId: 191350836
Change-Id: I758996c3fef75ece7cecf0f7a0b4df7ace970d80
|
|
|
|
|
|
|
|
|
| |
Repeated requests from the server responds in an ALREADY_EXISTS error and does not transcribe the voicemails. In that case we should ask the server if the request is present already on the server, and if so retrieve it.
Bug: 77236260
Test: N/A
PiperOrigin-RevId: 191016332
Change-Id: I605c546a3bec3599c7b162853463ca7e46f63886
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
availability check
Checking donation is not a simple config check, but everything that donation availability is dependent on via the isVoicemailDonationAvailable() helper method. We update the code accordingly.
When the user declines the promo for donation, we should also update the toggle accordingly.
Bug: 74033229
Test: N/A
PiperOrigin-RevId: 191011808
Change-Id: I6e4ff9914355deed72175179fc7b9009f2395ef5
|
|
|
|
|
|
|
|
|
| |
When transcription toggle is turned off, we delete all local transcriptions. However when it is turned back on, we should re-transcribe all those( previously transcribed, then deleted) voicemails again.
Bug: 74033229
Test: N/A
PiperOrigin-RevId: 190640972
Change-Id: Iaaf324e74c7630852daeb314f34c2c3095fe3196
|
|
|
|
|
|
|
|
|
|
|
| |
This happens when an old dialer submitted a job and the newer dialer is trying to handle it. The class fingerprint changed so it can no longer be unparceled.
In this CL, such tasks will be dropped.
Bug: 64225192
Test: N/A
PiperOrigin-RevId: 190491751
Change-Id: I90fe2d24a435201cfae09970387e9b1c3a58b094
|
|
|
|
|
|
|
|
|
| |
When a user turns off transcription setting we should delete all the voicemails locally transcribed by google. We do this by deleting all the transcripts associated with the source package of the app.
Bug: 74033229,76167428
Test: Unit Test
PiperOrigin-RevId: 190159353
Change-Id: I328aece594aa0e66de59e43fa3619b5e9ae15f78
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Manually set to M
- MissedCallNotifierTest (not sure what the issue is here...)
- CallLogGroupBuilderTest (because a check was removed, some NPEs are thrown)
- MainSearchControllerTest (/system/etc/fonts.xml (No such file or directory))
Ignore Tests
- a few random ones in incallui/answer/impl/hint (shared prefs aren't working for some reason)
- VisualVoicemailUpdateTaskTest (disabled the whole test, issue unclear)
Bug: 73902692
Test: tap
PiperOrigin-RevId: 190030202
Change-Id: I1e9b61d758a61582c5a183ee884dd2181d1c10de
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL refactors the existing voicemail settings fragment and adds UI support for voicemail transcription. It mainly deals with the following:
- ensuring that when the VVM toggle is turned off, transcription and donations are gone.
- when transcription is off, donation preference is gone.
- donation is only available when transcription is available and enabled
- as part of the refactor, fixes existing logging bugs
- breaks preferences and its associated methods into helper methods when possible
- groups relevant preferences together when possible
Bug: 74033229
Test: Unit tests
PiperOrigin-RevId: 189418217
Change-Id: I3442cb5752a235cfca643ba55df3fb75171e3fe4
|
|
|
|
|
|
|
|
|
|
|
| |
The metadata belongs with the voicemail settings menu, which is moved into dialer a while ago. Not moving the metadata causes build variants without VVM to have duplicated voicemail settings in telephony and dialer.
Also removed the redundant metadata in incall ui manifest.
Bug: 73096806
Test: manual
PiperOrigin-RevId: 188756468
Change-Id: I00174f84024c5b9ab809d99e40a55d22a07bd063
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On VVM3 when the user upgrade to premium VVM through the carrier, the carrier will actively send STATUS SMSes first indicating the status is unknown, then the new premium status.
STATUS updates sent by the carrier were ignored until recently. Currently seeing the unknown status the provisioning process will be triggered, and the user will be downgraded back to basic VVM.
In this CL if the STATUS update is initiated by the carrier instead by a STATUS request, provisioning will be ignored.
Bug: 73625577
Test: N/A
PiperOrigin-RevId: 186737242
Change-Id: Ieb10f9a50e0c3001d02cefc31256a9adac1ae5d1
|
|
|
|
|
|
|
| |
Bug: 72666573
Test: Updated unit test to match the real case
PiperOrigin-RevId: 186376740
Change-Id: If1523963a03f89d6699ef89c8b82c4f22c04d039
|
|
|
|
|
|
|
|
|
|
|
| |
This CL allows VVM configs to be specifed with Group identifier, which takes precedence over configs with only MCC/MNC.
TelephonyVvmConfigManger is renamed to DialerVvmConfigManger. It was created when VVM was still in telephony, and need to separate itself from the CarrierConfig app.
Bug: 72666573
Test: Unit tests
PiperOrigin-RevId: 184924155
Change-Id: Ic71e99ed2b3015eed87dfb7e111538ff3b744206
|
|
|
|
|
|
|
| |
Bug: 72647204
Test: Tested by Bouygues
PiperOrigin-RevId: 184914101
Change-Id: Ic7dec5ee33a959751062127ab010dc79f6fb2bae
|
|
|
|
|
|
|
|
|
|
|
| |
Previously it is only disabled when the user has not changed the VVM settings, and the user can still re-enable it.
After this CL, VVM will always be disabled, and the settings will be hidden.
Bug: 72668279
Test: Unit tests
PiperOrigin-RevId: 184063245
Change-Id: I42c12f3fd2f3e397158e08b26875a7e99a766d33
|
|
|
|
|
|
|
|
| |
Using non-application contexts incurs extra disk access because shared prefs are cached per context.
Test: manually ejected sim and observed no strict mode violations
PiperOrigin-RevId: 183739285
Change-Id: I9337e226ae1e060478219cf495752ceccf5a31e6
|
|
|
|
|
|
|
|
|
| |
It is unclear from the docs or implementation what callbacks are invoked when the network is lost, or does the system release the callback for us somewhere else. In this CL VvmNetworkRequestCallback.releaseNetwork() will be guarded from calling twice, and log levels for callbacks are raised.
Bug: 64243619
Test: N/A, repro steps unknown.
PiperOrigin-RevId: 183298754
Change-Id: I5e589b2b59478b270890056fa08abb306ee1600c
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we are now using the AlarmManager to decide when to poll
for voicemail transcriptions, we need to ensure that we don't
start transcribing a voicemail until polling for the previous
one ends.
This cl postpones a voicemail transcription task if there is an alarm
set to poll for a transcription result. After a transcription result
is received (or we give up) the db is scanned for any pending transcriptions
and the next one is started.
Bug: 70242961
Test: manual and updated unit tests
PiperOrigin-RevId: 181899975
Change-Id: I7b8fb696164980cf710aa58a79418c6954e2b4d2
|
|
|
|
|
|
| |
Test: Existing tests
PiperOrigin-RevId: 180230450
Change-Id: I0b2589cfeeaef81e42a04efa48af24b4e4d0e95f
|
|
|
|
|
|
|
| |
Bug: 70243393
Test: N/A
PiperOrigin-RevId: 179064288
Change-Id: Id8b2e600ae00edbe2697932ad2d9fe78ea4430b5
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
voicemail_transcription_available
Follow the convention that features allowed by server configuration flags use the
word 'available' and when a feature is allowed by the user via settings then use the
word 'enabled'
Bug: 37340510
Test: manual and updated unit tests
PiperOrigin-RevId: 178831467
Change-Id: I5691fd7db45a70908d32cdac2b049fe76e6a0680
|
|
|
|
|
|
|
|
|
| |
Carrier might send STATUS SMS actively if the account configuration has changed. Previously it will be discarded if the account is already activated. In this CL activation will be rerun if the messageData already exist since it is initiated by an STATUS SMS.
Bug: 69857261
Test: ActivationTaskTest
PiperOrigin-RevId: 178028542
Change-Id: I6d103569c2be4eeadc3a7877d160fff03ad8b40e
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For privacy reasons we now delete all voicemails and transcriptions when
the user disables visual voicemail, (after confirming that they want to do this
via a dialog).
Note: we only delete voicemails whose source package is the google dialer.
Note: the voicemails will be re-downloaded and re-transcribed if the user re-enables visual voicemail
Bug: 69323147
Test: manual and unit test
PiperOrigin-RevId: 177315139
Change-Id: Ie04496dc5960b485794733fbf74f7f704e806023
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
result
This cl switches the way asynchronous transcription tasks poll for their
results. it has been observed that sometimes the server side transcription
takes longer than expected (sometimes many minutes), so instead of blocking
a thread for all that time this cl schedules an alarm for the next time to
poll. it also uses an exponential backoff scheme to determine the poll times
and increases the maximum total polling time from 20 seconds to 20 minutes.
Bug: 66966157
Test: manual and unit tests
PiperOrigin-RevId: 177257577
Change-Id: Ib2998f03cc418d5241ccffec71ba3945c9fe4cbc
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow users who have agreed to donate their voicemails to also provide
transcription quality feedback.
screenshot:
https://drive.google.com/open?id=0B9o_KvtLkcuIajVtdFN3Y0Qydmx2NXJYN2N3OVA3N0h5UEdR
Bug: 68712148
Test: manual and new unit tests
PiperOrigin-RevId: 176774942
Change-Id: I08b9afbbefaedfb0de5199038a1d2769bd983855
|
|
|
|
|
|
|
|
|
| |
This CL checks if the carrier app is installed on the system image. If so, VVM will be force disabled (user can't turn it on, can't even see the switch as if they are on a unsupported carrier). Otherwise, VVM will only be disabled by default if the carrier app is present (User can still turn it on in settings).
Bug: 67496592
Test: OmtpCarrierConfigHelperTest / manual - move carrier app to /system/app
PiperOrigin-RevId: 176586849
Change-Id: Idf79bdf61c600423062ca54d1b4c6e77cfcd8033
|
|
|
|
|
|
|
|
|
|
|
|
| |
This cl just adds a check before starting a transcription job
to verify that the user has accepted the appropriate TOS. Its
a rather big cl just because it had to expose some TOS acceptance
details that were previously encapsulated in the VoicemailTosMessageCreator.
Bug: 69267260
Test: manual and unit tests
PiperOrigin-RevId: 176132370
Change-Id: Ic28fb197a07f9df7a9b5f1729c84566cba0890fc
|
|
|
|
|
|
|
|
|
|
| |
Added a carrier config and check to see if the carrier allows over
the top voicemail transcription, and if not do not attempt transcription.
Bug: 68951869
Test: manual and unit test
PiperOrigin-RevId: 176065849
Change-Id: I69df1f2867420d7fdcc7f0a31e0e6c26da67abb1
|
|
|
|
|
|
|
|
|
| |
This CL replaces all instance of CallIntentBuilder.build() with PreCall.getIntent(), which when run as an activity, will finish building the intent with user interaction.
Bug: 64216442
Test: manual
PiperOrigin-RevId: 174924323
Change-Id: If41868df4c7ed078d03bd3431fa85b8947056a01
|
|
|
|
|
|
|
|
|
|
|
| |
All voicemails are called by using CallIntentBuilder.forVoicemail() so the PhoneAccountHandle can be designated. A future CL will use dialogs to customize the call (multi SIM selection, RTT, etc.)
As a result voicemail error messages and legacy voicemail notifications will call the account it is received from directly.
Bug: 64216442
Test: Unit tests
PiperOrigin-RevId: 174784322
Change-Id: Ibe1c57bc7852e3d55a39a0cc2da19b6a79954c0f
|
|
|
|
|
|
|
| |
Bug: 68900535
Test: SendTranscriptionFeedbackActionTest
PiperOrigin-RevId: 174732357
Change-Id: I9a99606a13cfc32f53a6ce8a15ad258bb48d7130
|
|
|
|
|
|
|
| |
Bug: 68712148
Test: none
PiperOrigin-RevId: 174535170
Change-Id: I436335d142f369f8e7c3249463117ffd5c00d6b4
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for rating transcription quality since we don't
persist the transcript id. The id we generate is just the md5
hash of the voicemail audio data.
Bug: 68712148
Test: manual and updated unit tests
PiperOrigin-RevId: 174527907
Change-Id: I7a29bf5a96447129fc1437074f20ecebcdb1f43b
|
|
|
|
|
|
|
|
|
|
|
|
| |
in cl/173731907 we added a setting for donating voicemails, but didn't
distinguish between when this feature is enabled/disabled by the user
or by configuration. this cl fixes that by adding a method to check
if the feature is available (ie enabled by config).
Bug: 62423454
Test: manual and unit test
PiperOrigin-RevId: 174245260
Change-Id: I45a59de7f4a171d759e2fcf86db27a100a84de67
|
|
|
|
|
|
|
|
|
| |
The voicemail module should not contain any UI code.
Bug: 37258159
Test: DialerSettingsActivityTest,VoicemailSettingsFragmentTest. A future CL is refactoring VoicemailChangePinActivity into a fragment.
PiperOrigin-RevId: 174125949
Change-Id: I89cf6a083b0a0952332440d76e7ae0cb1c801931
|
|
|
|
|
|
|
| |
Bug: 62423454
Test: manual and updated unit test
PiperOrigin-RevId: 173731907
Change-Id: Ic73600197b1c4fa6ac0937a8c38b048cd8faded8
|