| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to resolve a merge conflict in:
I48296c56fb1d275a06b7c314f5380266c1195ef2
Test: make
master is already up to date and
Merged-In: I858e3665253139b8aab4e4c063bfc4c419f33cc9
Change-Id: Ifc146f2fec24fd2f8a51cd32feb3699bb1c07136
|
|
|
|
|
|
|
| |
Bug: 37846172
Test: on device
PiperOrigin-RevId: 161720359
Change-Id: I2df2036c6d9941d37511f450f58682cf07e774b0
|
|
|
|
|
|
|
| |
video: https://drive.google.com/open?id=0B2Hce9qilHmvdl8xY1hmcDZ0R3M
Test: manual
PiperOrigin-RevId: 161713747
Change-Id: I8185ca897a82479ef7c552a1ce6891e31c4c5aad
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
screenshots:
default sizes:
before: http://screen/u29zyepX0OM
after: http://screen/tXGSUbNfWAE
large sizes:
before: http://screen/NH3OmGDRyBp
after: http://screen/W6DVopCxMUp
Bug: 63156716
Test: screenshots
PiperOrigin-RevId: 161693857
Change-Id: I8310336080ae080dc586dcf21d4966260880a627
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this change, all video calls are referred to as just "video call". This
CL uses the Lightbringer interface to allow customizing that text.
Before: https://drive.google.com/open?id=0B7uuA4cyYX0xeVZCTGtMUUtoRVU
After: https://drive.google.com/open?id=0B7uuA4cyYX0xMnFhbTBXMDI2VW8
Bug: 63138393
Test: CallTypeHelperTest
PiperOrigin-RevId: 161692812
Change-Id: I36dc1a1fae96dddee91c5efb8892c4a6c7ef67ca
|
|
|
|
|
|
|
|
|
|
|
|
| |
This issue occurs when users are shown a post call snackbar and their shared
prefs are updated before pressing "send message". This change resolves the
issue by getting the phone number when the prompt is created rather than when
the button is pressed.
Bug: 62294499
Test: PostCallTest#postCall_UpdatedQuickly_PostCallStartedSuccessfully.
PiperOrigin-RevId: 161689241
Change-Id: Ie2c857f6743aa556f993bc3f8e92c8b2b7357c08
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a user caused their activity to undergo several state changes rapidly, they
could get the contacts fragment into a state where it wouldn't have any
elements but still call onScrollChange. This would result in calls to
getFirstCompletelyVisibleItemPosition returning NO_POSITION (-1) and throw an
AIOOBE when attempting to get a row's header value.
Bug: 63594129
Test: manual.
PiperOrigin-RevId: 161610423
Change-Id: I0c53587a6499c42abe5e51b6ac2b4108c0971545
|
|
|
|
|
|
|
|
|
| |
before: http://screen/DsVrM1vK89e
after: http://screen/RzGZvPTXRQb
Bug: 63093275
Test: manual
PiperOrigin-RevId: 161609906
Change-Id: If53681b9414dd79dba16371f42be437f1afa2729
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Call button may have two lines of text. We were not properly setting the
second to GONE in all cases.
Note: We don't need to require Google Dialer being the default Dialer for the Duo integration to work. I added this check so removing it doesn't go against any previous well-considered decision. It also enables the Espresso test work without needing a flag to override.
Before: https://screenshot.googleplex.com/3YXaZdbQk7k
After: https://drive.google.com/open?id=0B7uuA4cyYX0xNThETTJWdTVQQWM
Bug: 63062360
Test: GoogleDialtactsActivityTest
PiperOrigin-RevId: 161606497
Change-Id: I7526a4fc60b84906cc04563b635eaad9f348415e
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a user took a picture then quickly closed call composer, when the image was
ready we would try to update our view state. Since our fragment is no longer
attached, this cuases a crash when we check that getContext() is not null.
fragment.getContext is never null in robolectric.
Bug: 62687110
Test: manual, cannot test b/c we cannot take photos in Espresso and
PiperOrigin-RevId: 161600278
Change-Id: If9bd98578d221fca4bc99ff17a39f917f3a8bcca
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was odd that we were casting and was causing some crashes. This CL makes
things work more as is typical in Dialer.
We previously did not do this because there are some parts of the
VideoShareSession which are not open-sourceable. Turns out we can simplify
those parts out of the interface.
Bug: 63523694
Test: existing tests
PiperOrigin-RevId: 161593028
Change-Id: I8f1379fc46f4e9d41413b731787dbf37e0901da9
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The dialer app crashes on launch right now when app data is empty, because we fetch the spam list on app start, and we don't tag the network traffic using TrafficStats, which is a strict mode violation.
This CL tags spam network traffic using TrafficStats, by providing a custom transport executor for the GRPC channel. All activity on the channel is tagged as spam.
This unfortunately required creating a new thread pool. I am not sure if this creates more threads than before, because it is not clear what type of transport executor grpc uses by default. Note that the new thread pool will kill unused threads after 60 seconds so won't consume resources when idle.
Bug: 62388129
Test: manually verified app does not crash on launch with empty data. Can add automated tests upon request.
PiperOrigin-RevId: 161568882
Change-Id: I99da6ebb649fe1a63d634871ab314d8d910658f9
|
|
|
|
|
|
|
|
|
| |
Add additional null checks during deseriailzation.
Bug: 63575857
Test: unit tests, on device
PiperOrigin-RevId: 161564824
Change-Id: I54f52e12397adb4473b523325f8c006ff534fbd9
|
|
|
|
|
|
| |
Test: ondevice
PiperOrigin-RevId: 161548092
Change-Id: If4cde06669bc33cca69a9b602f54d873b735c730
|
|
|
|
|
|
|
|
| |
Although we don't know the reason why v.getParent() can be null, we can avoid calling it.
Test: manual
PiperOrigin-RevId: 161442696
Change-Id: I07af0da9b64fb3fa77b01c0b619837a79d593b67
|
|
|
|
|
|
|
|
|
|
|
| |
Methods such as getAccountLabel() is called on different threads which may cause
race condition issue.
This change also delete CallLogCacheLollopopMr1 since it's not necessary that Dialer is targeting M+.
Bug: 63415147,63524435
Test: none
PiperOrigin-RevId: 161440757
Change-Id: Ia609c52e53dabdce78ffb4320f4cd66e38112e47
|
|
|
|
|
|
|
|
|
| |
OC preview devices are hitting the assert and skewing crash rate numbers.
Bug: 62338925
Test: LegacyVoicemailNotificaitonReceiverTest
PiperOrigin-RevId: 161438516
Change-Id: Ib533947d2cd9e9a87ffd9fb629f09f877f683026
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL bumps the version name of Dialer from Dialer v11 to Dialer v12. This CL
also bumps the version code from 15***** to 1600000.
I've also set 'version_conf_incrementer_max_version_code' at go/dialer-v11
to 1599999.
Test: N/A
PiperOrigin-RevId: 161418347
Change-Id: I961f22481d813d66b950894b3783e13624de733e
|
|
|
|
|
|
|
|
|
| |
We cannot use ConfigBindings as full backups happen with a base Application, not the app's custom subclass.
Bug: 63104326
Test: N/A
PiperOrigin-RevId: 161398864
Change-Id: I7f559fe7cfd8bfdd65f49efea943f3f75488d1a6
|
|
|
|
|
|
|
|
|
|
|
|
| |
The tests now call through the click listener to expand instead of just calling
the expanding method directly. This was done after we had a bug come up inside
the click listener that these tests did not catch.
The bug: Lightbringer.getPackageName can return null, so when using a stub there was an NPE inside the ExpandCollapseListener.
Test: only tests
PiperOrigin-RevId: 161121777
Change-Id: Ie58a4c14a32984c183b6159db2076a96cf46b37e
|
|
|
|
|
|
| |
Test: cl/160695183
PiperOrigin-RevId: 160697524
Change-Id: I07127554a968d8dc36c02b522b7536438be7fb90
|
|
|
|
|
|
|
|
|
| |
The original code is somehow triggering when the VVM tab is not selected.
Bug: 62517716
Test: VisualVoicemailCallLogFragment is utterly untestable
PiperOrigin-RevId: 160692310
Change-Id: Ia9da8e5aa7dd28f22c46d87dd25ebf6097918a9a
|
|
|
|
|
|
|
|
|
|
|
| |
When telecom disconnect the video call with the code of DisconnectCause.ERROR and the DisconnectCause#getReason() of "IMS_ACCESS_BLOCKED", we should show an error dialog to user indicating that video call is not available and providing a option to make a voice call instead.
Screenshots:
https://screenshot.googleplex.com/YTUGVouoLmj
Bug: 33821263
Test: manual, VideoCallNotAvailablePromptTest
PiperOrigin-RevId: 160563754
Change-Id: Ie2eb735a92c577b5ae5a5e8b7efa2d699fc964bc
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL bumps the version name of Dialer from
also bumps the version code from 14***** to 15*****.
go/dialer-v10_1 did not have a version_conf_incrementer_max_version_code set, which let it to share the version code increments between v10.1 and v11. There are version codes in v10.1 which are higher than v11 which will lead to users downgrading when we submit v10.1 to the playstore (http://cl/160476738)
To make sure users are not downgraded from v11 to v10.1 when we push to the play store, I've also set 'version_conf_incrementer_max_version_code' at go/dialer-v10_1
to 1504907.
Test: N/A
PiperOrigin-RevId: 160555974
Change-Id: I4a9e64aa2fe461019e179f544fe959b8389a02cf
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Causes crash, see b/63127884
*** Original change description ***
All Fragments are now support library Fragments.
Switch a bunch of imports to support library Fragments (and Loaders) instead of framework Fragments (and Loaders). This was needed to use FragmentManager.isStateSaved() instead of manually tracking that state. This should reduce errors around committing after state is saved.
Also adds METADATA presubmit to prevent new usages of framework Fragments or Loaders.
***
Bug: 38241305,63127884
Test: N/A
PiperOrigin-RevId: 160530287
Change-Id: Ie2c4d3561ebea2d0f05097ce89bdd9bc8767c8cf
|
|
|
|
|
|
|
|
| |
I think this was inadvertently (?) disabled.
Test: no
PiperOrigin-RevId: 160455622
Change-Id: I9f00331d7ef53108eb0adb9bec9c91be22422d2f
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The state of a session is more closely tied to the session itself,
rather than the EnrichedCallManager. The enum was originally placed in
the Manager as it was used in the API, but now that's no longer the
case.
This CL moves the Session State declaration into Session, which is a
more appropriate location.
Test: tap
PiperOrigin-RevId: 160448612
Change-Id: I907476140bc174a061d48ee8e58878af64a62b29
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
b/38149414 building with dreamchip regressed startup time by 400ms. This seems to be caused by linking against the library with cc_library, but the true reason is still unknown.
In this CL, dreamchip libraries is stored as an asset instead. During runtime the asset will be copied into the data directory then loaded.
Currently the copying happens on the main thread. Whether if it's acceptable to introduce further risk to handle this is to be discussed. Disk IO could already happen before this change.
Bug: 38149414
Test: N/A
PiperOrigin-RevId: 160444223
Change-Id: I9f098e7b79df113b2992d8590b33f423942716e4
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Including in:
- expanded call log item
- collapsed call log item
- search
- in call UI
LOG_STORAGE_INCREASE(GB/week): 3.15
5M active block user/day * 10 events/active = 350M event/wk
350M event/wk * (3 * 3 [int32])/event = 3.15GB/wk
Test: GoogleCallLogAdapterTest, ContactListItemViewTest, InCallFragmentTest
PiperOrigin-RevId: 160423797
Change-Id: I6c0ade53caf767ea9b2610a4c0eb68fcc2bcedf7
|
|
|
|
|
|
|
| |
Bug: 63012482
Test: CallLogCacheLollipopMr1Test
PiperOrigin-RevId: 160303077
Change-Id: I00c80a681963c5a7a25fffd04e02db32ca2386dd
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
This CL causes a crash when swapping SIMs.
*** Original change description ***
Adding voicemail transcription branding and progress UI
screen shot showing branding (its harder to capture the progress UI):
https://drive.google.com/open?id=0B9o_KvtLkcuIdkkycVo1RFhsaENYV3J2Yi1LWnJzR0FfSHJR
***
Bug: 63059930
Test: N/A
PiperOrigin-RevId: 160296762
Change-Id: Ib8d709d03d6d8a3fee4a0c384c15df00f55cb182
|
|
|
|
|
|
|
|
| |
This prevents accidental logging.
Test: GoogleCallLogAdapterTest, CallLogListItemViewHolderTest
PiperOrigin-RevId: 160207870
Change-Id: Ib0582613979114c24bb0bd38df41ad7d7dadb63a
|
|
|
|
|
|
|
|
|
|
|
| |
Switch a bunch of imports to support library Fragments (and Loaders) instead of framework Fragments (and Loaders). This was needed to use FragmentManager.isStateSaved() instead of manually tracking that state. This should reduce errors around committing after state is saved.
Also adds METADATA presubmit to prevent new usages of framework Fragments or Loaders.
Bug: 38241305
Test: Covered by existing tests.
PiperOrigin-RevId: 160202511
Change-Id: I5dc0b467da984ca571e49b4dfa0deea44eb372b2
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
• moved scrollbar to edge of screen
• changed divider to .5dp and added shadow
• change "DECLINE" to "NO THANKS" for verizon TOS (it already was that way for non-verizon)
• changed "ACCEPT" button to "TURN ON" text
• increased the bottom bar height
• made the google transcription text in the TOS bold
• add an image to the non-verizon TOS screen (just using test image for now)
i didn't add the 'Learn more' link, since its not ready yet.
verizon screen shot:
https://drive.google.com/open?id=0B9o_KvtLkcuIcVk0dHBtWmFfdjJWQVV3OEdVc0JXN01XZHQ4
non-verizon screen shot:
https://drive.google.com/open?id=0B9o_KvtLkcuIci1OMlVXTHVuMGYwMWZVTS01dGVwMUpLdmRr
Bug: 62375681
Test: manual and updated unit tests
PiperOrigin-RevId: 160006810
Change-Id: Id45a3a848bb219a70fddbb5a7ada29cd39e604a9
|
|
|
|
|
|
|
|
|
|
| |
screen shot showing branding (its harder to capture the progress UI):
https://drive.google.com/open?id=0B9o_KvtLkcuIdkkycVo1RFhsaENYV3J2Yi1LWnJzR0FfSHJR
Bug: 62376944,62424455
Test: device testing
PiperOrigin-RevId: 159993127
Change-Id: I8355164b5831e85de13915e221f6e0f0163e8c81
|
|
|
|
|
|
|
|
|
| |
Logging impressions for interactions with the voicemail transcription server.
Bug: 62423554
Test: none
PiperOrigin-RevId: 159985772
Change-Id: I782d7eb4df917ae42940f359d98abc87f7ec0f95
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
screenshots:
short message (before cl): http://screen/pMAgfV540Y5
short message (after cl): http://screen/VN3TVTBYjPN
long message (before cl): http://screen/V8jSApXmEC2
long message (after cl): http://screen/Vd7zyf2JGvP
long message zoomed (before cl): http://screen/urWDNGACgOf
long message zoomed (after cl): http://screen/i2xEch8HHoq
PiperOrigin-RevId: 159968371
Change-Id: Icaf0a69949b206efd8d08001065cfb4ccdcb1726
|
|
|
|
|
|
|
| |
There is still one more violation in hangouts that i will address in a separate cl.
PiperOrigin-RevId: 159955865
Change-Id: I61cb65d5f099baae497dfe2daddb4f7da6866ad6
|
|
|
|
|
|
| |
Test: IconFactoryTest.java
PiperOrigin-RevId: 159871437
Change-Id: I8df921f36bde619811129ae0f3013ff77903fc8e
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes two bugs we previously had:
1) If video calling was disabled in Settings, we would still show a video call option in the call log (fixed by checking the setting)
2) If a different app from Dialer inserted a video call into the history, we would incorrectly show a video call button in the call log (fixed by checking the account handle matches the default phone account)
PiperOrigin-RevId: 159870114
Change-Id: I19ef6b50db50f9961a486f48996427a1da8f8813
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
https://googleplex-android-review.git.corp.google.com/#/c/2446830/
Test: TH, make
Change-Id: I39aba7e972bac6e5864e70ed693849d90ecd7e08
|
| |
| |
| |
| |
| |
| |
| |
| | |
Reports when a user sucesfully reports a number is inaccurate caller id and
when their report fails.
PiperOrigin-RevId: 159762210
Change-Id: I8507b4d2a3d4b6f3004e8145f4ba0f9e8065e5d7
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Log which tab is presented when app first launched, including:
- speed dial
- call log
- contacts
- voicemail (if not available, we move to contacts tab immediately and log the
move)
Test: manual
PiperOrigin-RevId: 159754375
Change-Id: Ice5be6c0f2c0463204fe3c1c7cf83c4dfc7df5d1
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When a user uses call composer for the first time, it isn't obvious that their
messages are being stored in the Android Messages app. So we display this toast
to them on the first time they make a enriched call to let them know for
privacy purposes.
screenshots:
http://screen/pcuu4GG037Z
http://screen/MLRJiY9V7cH
PiperOrigin-RevId: 159749893
Change-Id: I0cee7b49321f1d2302ba8ed8f6e1c19c44feb19a
|
| |
| |
| |
| |
| |
| |
| |
| | |
Current auto fill content is usually the device's own number thus not useful
and it covers "1" key.
PiperOrigin-RevId: 159742824
Change-Id: I753832120bf9436506bf5394b47c94f94899a92b
|
| |
| |
| |
| |
| |
| |
| |
| | |
An empty string isn't as clear and can lead to incorrectly matching other
intents when just comparing package names.
PiperOrigin-RevId: 159725546
Change-Id: I2943b3569fb6409f5c69deb2032f3d8248f6c14d
|
| |
| |
| |
| |
| |
| |
| | |
TEST=N/A
Video: https://drive.google.com/a/google.com/file/d/0ByIs9UmqOFZFZjBsUS1HQVBxUUE/view?usp=sharing
PiperOrigin-RevId: 159637501
Change-Id: If1b088f7abff2ec52fd54fbbb36d6b7c6d54a926
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When a user deletes a call from the call log, it might not be clear that they
aren't deleting the attachments they made with the call. So we present them
with a snackbar letting them know to open android messages to delete
attachments.
screenshot: http://screen/TSoWmNhjcn4
screenshot: http://screen/vUXShdYpXem
PiperOrigin-RevId: 159631807
Change-Id: Iaad903258160dc789e0c6a524adba56299523636
|
| |
| |
| |
| |
| | |
PiperOrigin-RevId: 159622902
Change-Id: Idabc3122601e442a07b31c38287af767651e9970
|