summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge "Move VM playback from details to call log." into mnc-devAndrew Lee2015-06-0415-209/+200
|\
| * Move VM playback from details to call log.Andrew Lee2015-06-0315-209/+200
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - Delete voicemail playback in the CallDetailActivity. + Add voicemail playback to the call log list items. + Move the VoicemailPlaybackPresenter to the CallLogFragment. + Fix some retaining state for both call log (expanded items), and preserve rotation/state functionality for voicemail playback. This included some changes to the Presenter logic. + Fix some tests. Bug: 21471763 Bug: 21170557 Change-Id: I30aae3a52c5bbf74a5075a9666343c337b1fc0df
* | Merge "Fix VoicemailStatusHelper unit tests." into mnc-devAndrew Lee2015-06-041-0/+5
|\ \
| * | Fix VoicemailStatusHelper unit tests.Andrew Lee2015-06-031-0/+5
| |/ | | | | | | | | | | | | | | | | VoicemailStatusHelperImplTest was broken because of visibility issues caused by recent changes to how we read voicemail status. But, we plan to use this functionality again in the future. Bug: 21471763 Change-Id: I2049d2661c7d0686c8a439ea8a9e5bd20b009dd6
* | Fix unit test errors.Andrew Lee2015-06-033-11/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | When this was refactored before, some of the logic was bad. Some of the expected values were changed as well. I figured "add to contacts" is a really bad default text, because we don't actually support that action in call details. Also, the strings returned by the library for describing relative time spans changed. Bug: 21471763 Change-Id: I0c78c89c9c2e44de198f1f9299711fc31fe81cb1
* | Import translations. DO NOT MERGEGeoff Mendal2015-06-0320-43/+43
|/ | | | | Change-Id: I9395c300cd4cfc041bd2fc10d720d6782e704e45 Auto-generated-cl: translation import
* Merge "Rename PhoneNumberUtils APIs" into mnc-devBrian Attwell2015-06-021-1/+1
|\
| * Rename PhoneNumberUtils APIsBrian Attwell2015-06-021-1/+1
| | | | | | | | | | | | | | In response to more API review. Bug: 21571895 Change-Id: Ia1fa69da07a3427997919ba61c77fcbad7e79f2a
* | Merge "Continue voicemail playback during rotation." into mnc-devAndrew Lee2015-06-022-8/+12
|\ \
| * | Continue voicemail playback during rotation.Andrew Lee2015-06-012-8/+12
| | | | | | | | | | | | | | | | | | | | | | | | Don't pause playback or release the media player during onPause or onDestroy. Bug: 21235334 Change-Id: I0eccd4e38e89c3416817d80aa25cc3bb529a9d6b
* | | Merge "Enter search UI even if dialpad is not animating" into mnc-devYorke Lee2015-06-021-3/+8
|\ \ \
| * | | Enter search UI even if dialpad is not animatingYorke Lee2015-06-011-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a UI bug that happens when the dialpad is displayed without animation. Bug: 21524134 Change-Id: Ic566b09c2839d7f34d5d983f67e592c1b2d50d2e
* | | | Merge "Don't use Log.isLoggable to determine DEBUG flag" into mnc-devYorke Lee2015-06-021-1/+1
|\ \ \ \ | |_|/ / |/| | |
| * | | Don't use Log.isLoggable to determine DEBUG flagYorke Lee2015-06-011-1/+1
| |/ / | | | | | | | | | | | | | | | | | | This allows unnecessary debug statements to be stripped out by the compiler. Change-Id: Id1b6f8bd6c86cf5014e4b76524aa3839eb31bbb8
* | | Merge "Fix CallDetailActivity tests." into mnc-devAndrew Lee2015-06-015-25/+53
|\ \ \ | |/ / |/| |
| * | Fix CallDetailActivity tests.Andrew Lee2015-06-015-25/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | + Reset the AsyncTaskExecutor's instance between calls in tests. I don't know why this is necessary, but it fixes a class of problems which were happening. + Don't try to release a media player if it has not been prepared. + Handle possible race conditions since MediaPlayer's async prepare may be buffering or finished when a test assert is executed. + Add asset file no longer provided by variablespeed library. - Cleanup some stream copy code. Change-Id: I0ae5fde00514c6dcdb1e9c063435a13eed6e8528
* | | Import translations. DO NOT MERGEGeoff Mendal2015-06-011-3/+3
| | | | | | | | | | | | | | | Change-Id: Iaf5c16a5295cb7e172d640dfc350fb952a2a5900 Auto-generated-cl: translation import
* | | Import translations. DO NOT MERGEGeoff Mendal2015-05-292-42/+107
|/ / | | | | | | | | Change-Id: Iac064f2404ce5962bc6a4d49106d8f0ab790741f Auto-generated-cl: translation import
* | Merge "Refactor Voicemail Playback into standalone view." into mnc-devAndrew Lee2015-05-288-878/+682
|\ \
| * | Refactor Voicemail Playback into standalone view.Andrew Lee2015-05-278-878/+682
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | + Substitutes the existing playback widget in CallDetailActivity, although the plan is to move this to the call log shortly. + Convert the widget from a fragment into a layout. This allows us to more easily create multiple instances of the voicemail widget in the same view, as we intend to do in the call log. + Shift UI-related logic from Presenter to the Layout. + Fix janky seeking, so that it now works correctly consistently rather than sporadically, and doesn't need to buffer again. - Remove the VariableSpeed player formerly used in the Presenter. We don't use this functionality anymore, and this allows us to directly used the framework MediaPlayer (instead of a custom legacy proxy). Bug: 21170557 Bug: 20693172 Change-Id: Ia34f459df10e43763b32fdb0954f83e882664231
* | | Merge "Fix Talkback focus for call log action views." into mnc-devAndrew Lee2015-05-271-3/+8
|\ \ \
| * | | Fix Talkback focus for call log action views.Andrew Lee2015-05-271-3/+8
| |/ / | | | | | | | | | | | | Bug: 21448455 Change-Id: Icb9f37643d12dde2d46743d2ce3aa2fade7a68a1
* / / Import translations. DO NOT MERGEGeoff Mendal2015-05-2710-20/+10
|/ / | | | | | | | | Change-Id: I39080af6ee5a21313860b7ca1198c8d2088e4c1b Auto-generated-cl: translation import
* | Use correct xxxhdpi icon for AOSP DialerYorke Lee2015-05-261-0/+0
| | | | | | | | Change-Id: I388fc922485fa1af1db404aab5eebadd32b52fb1
* | Merge "Handle runtime phone permission" into mnc-devYorke Lee2015-05-265-5/+30
|\ \
| * | Handle runtime phone permissionYorke Lee2015-05-225-5/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't have access to the call log without the phone permission, so disable the following functionality: 1) Call log display 2) Show call history overflow menu option 3) Last number dialed functionality Bug: 20266292 Change-Id: I2f1d4b8b5f747d2fa04c3a9c291f9cf5147646b7
* | | Merge "Handle runtime permissions in Dialer" into mnc-devYorke Lee2015-05-2613-28/+124
|\| |
| * | Handle runtime permissions in DialerYorke Lee2015-05-2213-28/+124
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conditionally disable the following features if the required permissions are not available: 1) Display of all contacts 2) Display of speed dial 3) Caller ID in call log 4) Import/export contacts 5) Conversion of People.CONTENT_ITEM_TYPE and Phones.CONTENT_ITEM_TYPE into a phone number (via DIAL intent) 6) UndemoteOutgoingCallReceiver 7) Contact Search 8) Contact lookup in call detail activity 9) Nearby places search Bug: 20266292 Change-Id: I6d26902acb0eac407ae7bc18c11aa6ec57299506
* | | Import translations. DO NOT MERGEGeoff Mendal2015-05-2576-0/+86
| | | | | | | | | | | | | | | Change-Id: I79427c479f3835dd0732cdbc11f38ef4f50c185f Auto-generated-cl: translation import
* | | Merge "Transfer VM fragment logic to presenter." into mnc-devAndrew Lee2015-05-222-121/+94
|\ \ \
| * | | Transfer VM fragment logic to presenter.Andrew Lee2015-05-212-121/+94
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We want the presenter to handle/manage resources pertinent to the activity lifecycle, so that we can convert the playback fragment into a component. My apologies to whoever has to disentangle this presenter logic later (though that could be me). Bug: 21170557 Change-Id: Icf65d3c23f1a12a7d63c2a281f96d2168a4a560f
* | | Merge "Some ListsFragment cleanups." into mnc-devAndrew Lee2015-05-222-52/+30
|\ \ \
| * | | Some ListsFragment cleanups.Andrew Lee2015-05-212-52/+30
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | - Delete unused shortcut code. + Consolidate logic for reporting the current lists view. + Change page position logic to make private the list fragment's calculation of the type of tab in RTL. Bug: 21328994 Change-Id: Ic05a895fce77fea668798fca6e67863a2fcfd88a
* | | Merge "Allow dialing SIP calls directly from search" into mnc-devYorke Lee2015-05-211-1/+15
|\ \ \ | |/ / |/| |
| * | Allow dialing SIP calls directly from searchYorke Lee2015-05-211-1/+15
| |/ | | | | | | | | Bug: 20554942 Change-Id: I47daa3491223aed7e988e7d81501a281f1566f1c
* | Merge "Add voicemail tab if there are active providers." into mnc-devAndrew Lee2015-05-215-15/+98
|\ \ | |/ |/|
| * Add voicemail tab if there are active providers.Andrew Lee2015-05-215-15/+98
| | | | | | | | | | Bug: 21328994 Change-Id: Id6cd45c5614fafcc6f01842a8ec1eaba45dc0928
* | Merge "Import translations. DO NOT MERGE" into mnc-devBaligh Uddin2015-05-210-0/+0
|\ \
| * | Import translations. DO NOT MERGEBaligh Uddin2015-05-2076-544/+88
| |/ | | | | | | | | Change-Id: Id1763fe55b1950d43176649a1d0b66733e804cc8 Auto-generated-cl: translation import
* / Import translations. DO NOT MERGEGeoff Mendal2015-05-2176-544/+88
|/ | | | | Change-Id: Iede24802e00301b96b7029aa69593a33931b761e Auto-generated-cl: translation import
* Add AsyncTaskUtil for call log actions.Andrew Lee2015-05-193-301/+428
| | | | | | | | | | | | | | + Factors out async tasks from Call Detail activity, so that in the near future it can be invoked from the call log directly. + Create listener interfaces for actions to execute after tasks have been completed. + Should have no logical/behavioral changes. Hopefully, this creates a more opaque interface for activities or other classes to perform these actions as well. Bug: 21170557 Change-Id: I43aea7e37600d3978e285f047cba7ce75ebb5787
* Performance improvements to call log scrolling.Andrew Lee2015-05-1910-252/+403
| | | | | | | | | | | | | | | | | | - Remove call to CallUtil to check if video is enabled. It seems like it's fine to include the content description of what the call was, if it was a video call, even if there is not a video-enabled call account. - Factor out PhoneNumberDisplayHelper so it doesn't need to be an instance. This reduces some extra calls to getDisplayNameHelper. Probably a marginal difference, performance-wise, but it probably helps a smidgen and also simplifies the need for creating and passing or recalculating various instances of things. TODO: It'd be much better if PhoneCallDetails had a builder. It's terribly painful to fix all the tests when adding fields... Change-Id: I6da13dc8b6b047043aba871796a8ed13b112a227
* Remove unused InCallAppYorke Lee2015-05-191-6/+2
| | | | | | Move NotificationBroadcastReceiver into its own class. Change-Id: I64dec0c72a30993c471352c9a0fc497fa31b4bc6
* Merge "Only allow one expanded call log card." into mnc-devAndrew Lee2015-05-183-90/+58
|\
| * Only allow one expanded call log card.Andrew Lee2015-05-143-90/+58
| | | | | | | | | | | | | | | | | | | | | | This was some functionality lost in the switch to RecyclerView and cards. + Consolidate old methods into single OnClickListener. - Deleted unused listener. Bug: 20433758 Change-Id: Ic4797687548e94c0459e2a3a4134ef0aa5191d90
* | Remove voicemail transcript from details.Andrew Lee2015-05-182-18/+1
| | | | | | | | | | | | | | | | It will continue to be shown in the call log, but will be removed from details since the widget will be moved. Bug: 21170557 Change-Id: I1ec3b090adc0736f7b134d0f67282ba7b4f9483b
* | Merge "Delete unused code in CallDetailActivity." into mnc-devAndrew Lee2015-05-151-56/+0
|\ \
| * | Delete unused code in CallDetailActivity.Andrew Lee2015-05-151-56/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | - I don't know of any affordances in call detail to make a call, so the onKeyDown code seems to be superfluous. - No references to ViewEntry or forceLeftToRight. Bug: 20433758 Change-Id: Idbf6ffb81d3697b27cb51eda346b46eb5d083878
* | | Merge "Fix potential Dialer NPEs" into mnc-devYorke Lee2015-05-152-2/+4
|\ \ \ | |/ / |/| |
| * | Fix potential Dialer NPEsYorke Lee2015-05-152-2/+4
| | | | | | | | | | | | | | | | | | | | | Fix NPEs encountered during monkey tests Bug: 21167534 Change-Id: I98b6f675adfd233d3583c363f7daeca1bc14d8b7
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-02 14:57:12 +0000