summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Rename the new bubble package name from "bubble" to "newbubble".Eric Erfanian2017-10-24141-505/+3326
| | | | | | | | It fixes AOSP for package name conflict. Test: manual PiperOrigin-RevId: 173298696 Change-Id: Id10ebe0bcf029e61f65cf6580c7198abd8395081
* Merge changes I9a5b30d6,Ie9e7b741,I415f5b7e,I86e720b8,Ia8b7d508, ...Treehugger Robot2017-10-1912-45/+139
|\ | | | | | | | | | | | | | | | | | | * changes: Automated g4 rollback of changelist 172154863. Take into account special dialable characters when grouping calls in the call log UI. Move more Video Share stuff to third_party Fix NPE in TelecomAdapter.stopForegroundNotification(). wrapping %s in in <xliff:g> </xliff:g> tags to prevent translation Check AD eligibility before utilizing the feature.
| * Automated g4 rollback of changelist 172154863.maxwelb2017-10-191-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Causes crashes on rotation: http://b/67839843 *** Original change description *** Do not load every DialtactsActivity fragment on app open With this change we now only load the Favorites and Call Log Fragments when the app opens. Paging to the CallLogFragment makes the ContactsFragment load as we would want. This should result in a faster app start time. I'll need to verify the impact of this using the same method as http://cl/170422671 I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the ch... *** Bug: 64541209,65460373 Test: Manually verified regression fixed PiperOrigin-RevId: 172684553 Change-Id: I9a5b30d6619d930adfb82b19ac3ff9da00decaaa
| * Take into account special dialable characters when grouping calls in the ↵linyuh2017-10-192-30/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | call log UI. Currently we use PhoneNumberUtils#compare(String, String) to determine whether two numbers in the call log should be grouped. The method ignores special dialable characters such as "#", "*", "+", etc, which can cause phone numbers and service dialing numbers to be grouped. For example, suppose the user has a contact named "John Smith" with number 123456789 and a contact named "Service" with number #123456789, and called each contact once. The old grouping logic will put the two numbers in the same group. The new grouping logic in this CL can separate the two numbers. Bug: 30225112 Test: CallLogGroupBuilderTest, PhoneNumberHelperTest PiperOrigin-RevId: 172683494 Change-Id: Ie9e7b7418d6d7c74830cbae09c04ff1feb1b827d
| * Move more Video Share stuff to third_partyroldenburg2017-10-192-0/+58
| | | | | | | | | | | | | | Bug: 36565933 Test: manual, just moving PiperOrigin-RevId: 172671853 Change-Id: I415f5b7e518cca22fad96b017a573322af3f73be
| * Fix NPE in TelecomAdapter.stopForegroundNotification().yueg2017-10-192-4/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | In InCallServiceImpl.tearDown(), we should only clear inCallService after InCallPresenter.tearDown() where we remove all notification. Also remove null assertion in stopForegroundNotification() since other crash should only happens when there is no notification. Test: StatusBarNotifierTest PiperOrigin-RevId: 172657924 Change-Id: I86e720b80f885aa93f12215fda899ee62eeaba5b
| * wrapping %s in in <xliff:g> </xliff:g> tags to prevent translationmdooley2017-10-191-5/+5
| | | | | | | | | | | | | | Bug: 67322107 Test: manual PiperOrigin-RevId: 172656296 Change-Id: Ia8b7d508ef35ff0091b762c28e1091af60ce15b4
| * Check AD eligibility before utilizing the feature.erfanian2017-10-194-1/+18
|/ | | | | | | Bug: 67914094 Test: unit tests PiperOrigin-RevId: 172650441 Change-Id: Ie7df3174a07df2de3a102fb70a126004f704b22f
* Merge "Support bulk inserted voicemails."Treehugger Robot2017-10-184-9/+34
|\
| * Support bulk inserted voicemails.twyen2017-10-174-9/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | Bulk insert is implemented in ag/3073902 When more than one voicemail is inserted into the VoicemailProvider, the URI type is Voicemails.DIR_TYPE instead of ITEM_TYPE. This CL adds support to the new type. Previously when multiple voicemails are being notified, each one of them will generate a ringtone because the notifiction is set to alert children. In this CL, the summary will have alert instead, and will only alert when new voicemails are received. Bug: 21281858 Test: VisualVoicemailNotifierTest PiperOrigin-RevId: 172546076 Change-Id: I4df6098fc3a793139e3d4e77fe1339efdc001944
* | Merge "Fix top text cropping issue in new voicemail tab"Treehugger Robot2017-10-182-3/+3
|\|
| * Fix top text cropping issue in new voicemail tabuabdullah2017-10-172-3/+3
| | | | | | | | | | | | | | | | | | | | | | The numbers used to be cropped (http://screen/YYBG8T0Ma0J). We've fixed that issue in this CL and also removed the term "call_log" from the file name. Screenshot: http://screen/uHCPwf5smVX Bug: 64882313 Test: N/A PiperOrigin-RevId: 172541833 Change-Id: Ib2746b38284c2c04c84ab369d449412d8a9880b4
* | Merge changes Ib92b055d,I5c9f66ffTreehugger Robot2017-10-1812-109/+401
|\| | | | | | | | | | | * changes: Update SearchAdapter query if fragment has query before fragment is ready. Contacts are now searchable by company name.
| * Update SearchAdapter query if fragment has query before fragment is ready.calderwoodra2017-10-171-0/+1
| | | | | | | | | | | | | | | | | | | | | | If a user made a search using the voice/mic icon, the search results weren't being applied to on device contacts because SearchAdapter wasn't receiving the query. Bug: 67633975 Test: manual PiperOrigin-RevId: 172540423 Change-Id: Ib92b055dddf4e4fbdf88eadd62583bf1bac32055
| * Contacts are now searchable by company name.calderwoodra2017-10-1711-109/+400
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change coalesces Cp2 contacts into a new cursor so that they can be associated with the Company name. The following logs can help explain how the data is organizes in the original cursor: display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/name), data1 (A Pixel) display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/note), data1 () display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/group_membership), data1 (1) display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/phone_v2), data1 (+1 650-200-7932) display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/phone_v2), data1 (+1 540-555-6666) display Name (A Pixel), lookupKey (3535i7a9673fc89b77de3), mimeType (vnd.android.cursor.item/organization), data1 (Walmart) This is an example of what is returned for a single contact. We can easily associate contact rows together using the lookup key and determine which rows have relevant data by checking the mime type. I use the data here to coalesce the contacts together into one row for easy parsing in ContactFilterCursor. Rows with mime type phone_v2 contain contact information (for example, this contact has 2 phone numbers). Rows with mime type organization contain contact's company information (for example, this contact works at Walmart). Bug: 67675742,64894607,67848713 Test: existing + SCCT.filter_companyName PiperOrigin-RevId: 172528797 Change-Id: I5c9f66ff0c27276869295eff97bb0216f92995be
* | Merge changes Ibc853aa4,I061e3b45,I31983153Treehugger Robot2017-10-184-24/+51
|\| | | | | | | | | | | | | * changes: Update simulator to add emergency call Allow voicemail transcription notifications to expand Hide voice search button when exiting search if it is not available
| * Update simulator to add emergency callmaxwelb2017-10-171-0/+6
| | | | | | | | | | | | Test: Manual :/ PiperOrigin-RevId: 172521778 Change-Id: Ibc853aa429d61c13a43b56411fb00a0fcb38795f
| * Allow voicemail transcription notifications to expandmdooley2017-10-171-5/+8
| | | | | | | | | | | | | | Bug: 67430264 Test: manual PiperOrigin-RevId: 172520128 Change-Id: I061e3b45599e1c14be387713e63f6fdeae367be4
| * Hide voice search button when exiting search if it is not availabletwyen2017-10-172-19/+37
|/ | | | | | | Bug: 67820772 Test: DialtactsActivityIntegrationTest PiperOrigin-RevId: 172519580 Change-Id: I31983153cedb24c436cbaeef69fe6a2f4e558c65
* Merge changes Ida554313,Ie7187b02,I7a7c23b4Treehugger Robot2017-10-1820-235/+721
|\ | | | | | | | | | | | | * changes: Stop showing partially matched numbers that are not global phone numbers. Display Voicemail Contact Name and Photo in Voicemail Fragment. Add temporary assisted dialing setting to Dialer.
| * Stop showing partially matched numbers that are not global phone numbers.linyuh2017-10-173-139/+218
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When determining whether two phone numbers are identical enough for caller ID purposes, the Contacts Provider ignores special dialable characters such as '#', '*', '+', etc. This makes it possible for the cursor returned by the Contacts Provider to have multiple rows even when the URI asks for a specific number. For example, suppose the user has two contacts whose numbers are "#123" and "123", respectively. When the URI asks for number "123", both numbers will be returned. Therefore, the following strategy is employed to find a match. If the cursor points to a global phone number (i.e., a number that can be accepted by PhoneNumberUtils#isGlobalPhoneNumber(String)) and the lookup number in the URI is a PARTIAL match, the cursor is a match. If the cursor points to a number that is not a global phone number, the cursor is a match iff the lookup number in the URI is an EXACT match. There is no matched cursor in all other circumstances. UI demo: Suppose the user has a contact named "Service1" with number "#123". Before: Incall UI after the user dials "123": https://photos.app.goo.gl/xFWCD4qy2VR3YEuJ2 Call log UI after the call ends: https://photos.app.goo.gl/FT28GdTBy1dtANtI2 After: Incall UI after the user dials "123": https://photos.app.goo.gl/Io3BisQmsyfnvitV2 Call log UI after the call ends: https://photos.app.goo.gl/6GgRrmx75yUTga3B3 Bug: 30225112 Test: PhoneNumberHelperTest PiperOrigin-RevId: 172505648 Change-Id: Ida554313455ff9ce40432897681f89f58d64af04
| * Display Voicemail Contact Name and Photo in Voicemail Fragment.uabdullah2017-10-1710-92/+353
| | | | | | | | | | | | | | | | | | | | | | This CL lays the foundation of querying the annotated call log, retrieving only the voicemail entries and some of the voicemail information in the Voicemail tab. This CL only displays the name/number as well as the corresponding photo of the voicemails present on the device. WANT_LGTM=zachh SCREENSHOT: http://screen/YYBG8T0Ma0J Bug: 33006245, 64882313 Test: Unit tests and manual verification. PiperOrigin-RevId: 172504512 Change-Id: Ie7187b021abf42d1a4522458a1ab28537a7c222c
| * Add temporary assisted dialing setting to Dialer.Eric Erfanian2017-10-177-4/+150
|/ | | | | | | Bug: 63994464 Test: integration test PiperOrigin-RevId: 172499750 Change-Id: I7a7c23b403f649c1bbec0bb068e1285e02fddd22
* Merge "Some cleanup of incoming call latency."Treehugger Robot2017-10-176-79/+67
|\
| * Some cleanup of incoming call latency.wangqi2017-10-176-79/+67
|/ | | | | | | | | | | | | 1. Only update secondary info when it's changed. 2. Removed redundant call to update notification on activity start (b/36649622) 3. Use same call back for notification update from contact info query to avoid duplicated call backs. The actual latency reduction is insignificant (<10%). Bug: 36649622,64542087 Test: manual PiperOrigin-RevId: 172475223 Change-Id: I1c91cb5715287991de774a1d9b95e4c8b722d28f
* Merge changes I84ec0ac5,I2b92e1e0,Ic30fa6c6Treehugger Robot2017-10-1720-102/+580
|\ | | | | | | | | | | | | * changes: Move Duo related constants out of interface Dismissing location prompt now actually prevents it from reshowing. Add GSM conference calling to simulator.
| * Move Duo related constants out of interfaceroldenburg2017-10-178-72/+63
| | | | | | | | | | | | | | | | | | Fixed notifying for Duo missed calls using the new constants to check if a call is a Duo call. Bug: 66946794 Test: existing tests, manual PiperOrigin-RevId: 172400311 Change-Id: I84ec0ac5c933cf1aec68b6d1f422c2effe6b69ec
| * Dismissing location prompt now actually prevents it from reshowing.calderwoodra2017-10-172-3/+9
| | | | | | | | | | | | | | Bug: 67709163 Test: NewSearchFragmentTest PiperOrigin-RevId: 172378559 Change-Id: I2b92e1e06057a57638d23a333d04239b2e288bc1
| * Add GSM conference calling to simulator.yueg2017-10-1710-27/+508
|/ | | | | | | | | | | | | This CL adds a new item to the simulator menu: - Add GSM conference The GSM conference action creates a conference with 5 phone calls. Users can individually separate or kick calls out of the conference. Hanging up the second last call finishes the conference. Bug: 67785540 Test: SimulatorConferenceTest PiperOrigin-RevId: 172377631 Change-Id: Ic30fa6c65cf782247f75bcdd1ecbd86b1c16f143
* Merge changes Iab543850,I305f8a0eTreehugger Robot2017-10-164-9/+18
|\ | | | | | | | | | | * changes: Keep promo state on rotate FAB is no longer visible on return to call dialog.
| * Keep promo state on rotateAndroid Dialer2017-10-163-4/+11
| | | | | | | | | | | | | | | | | | | | Promo was being collapsed because rotate causes list to be scrolled at IDLE state. Make the drag more explicit by including the fastScroller drag state instead manually verified fast scrolling still minimizes promo and rotating while promo is expanded keeps it expanded Bug: 67670326 Test: ContactsPromoFragmentTest PiperOrigin-RevId: 172352966 Change-Id: Iab5438501db1d54b7ffac3339faecde0256a3632
| * FAB is no longer visible on return to call dialog.calderwoodra2017-10-161-5/+7
| | | | | | | | | | | | | | Bug: 67419607 Test: manual PiperOrigin-RevId: 172349180 Change-Id: I305f8a0e5ae90b2e5e8f77772edfb0b973aca096
* | Merge "Finish AudioRouteSelectorActivity in onAudioRouteSelected."Treehugger Robot2017-10-161-0/+1
|\|
| * Finish AudioRouteSelectorActivity in onAudioRouteSelected.yueg2017-10-161-0/+1
|/ | | | | | | | | | In previous change, we use AudioRouteSelectorDialogFragment.onCancel() instead of onDismiss(). And selecting an item only calls onDismiss() instead of onCancel(), so the activity is not finished. In this change we finish the activity when an item is selected. Test: manual PiperOrigin-RevId: 172342660 Change-Id: I2d34874ae9e1a7e5ad858b4f1ba855b48647d995
* Merge "Rename Lightbringer to Duo"Treehugger Robot2017-10-1627-181/+163
|\
| * Rename Lightbringer to Duoroldenburg2017-10-1627-181/+163
|/ | | | | | | | | | | Now that our Duo integration is public, we no longer need a code name. To avoid any disruption, logging and config related names were not changed. Bug: 63753964 Test: manual, existing tests PiperOrigin-RevId: 172172738 Change-Id: Ib9d3d80761944d850c8c4886def9fef9a28539a4
* Merge changes If86250b1,Ib2a01013Treehugger Robot2017-10-143-20/+80
|\ | | | | | | | | | | * changes: Fixed crash which occurred when clearing call log containing enriched call data. Add config provider value for dynamic locales for assisted dialing.
| * Fixed crash which occurred when clearing call log containing enriched call data.zachh2017-10-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | There was a race where the dialog could sometimes get detached before the success callback finished. The callback would attempt to show a snackbar using [fragment.]getString(), which throws when the fragment is detached. The fix is to just use the activity to get the string (which has already been asserted to be valid). Bug: 65968151 Test: unit PiperOrigin-RevId: 172169503 Change-Id: If86250b14038958e6668b26d1f150619fe3eefae
| * Add config provider value for dynamic locales for assisted dialing.erfanian2017-10-132-19/+79
| | | | | | | | | | | | | | | | This is a dialer only feature and will not be available in the framework. Test: unit tests. PiperOrigin-RevId: 172166023 Change-Id: Ib2a0101386a9d892dab87c7c4fb8d4728d8c55f0
* | Merge "Bug fixes for new search ui w/ Dialpad."Treehugger Robot2017-10-142-3/+42
|\|
| * Bug fixes for new search ui w/ Dialpad.calderwoodra2017-10-132-3/+42
|/ | | | | | | | | | | | - Dialpad now hides if user tries to scroll w/ a search query. - Search now closes if the user touches the blank area w/o a search query. - Since we don't even show location results in dialpad search, we no longer request location permission in it. Bug: 67657783,67656915 Test: tba PiperOrigin-RevId: 172162620 Change-Id: I33a814797a053600e56fb163fd55b0c43e00a9c6
* Merge changes Iaf6e217d,Ib22e33de,If9fd6ca9Treehugger Robot2017-10-143-8/+7
|\ | | | | | | | | | | | | * changes: Do not load every DialtactsActivity fragment on app open Enable Lightbringer upgrades on M Fixing voicemail notification bug
| * Do not load every DialtactsActivity fragment on app openroldenburg2017-10-131-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With this change we now only load the Favorites and Call Log Fragments when the app opens. Paging to the CallLogFragment makes the ContactsFragment load as we would want. This should result in a faster app start time. I'll need to verify the impact of this using the same method as http://cl/170422671 I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the change, and only the expected 2 with this change. Bug: 64541209,65460373 Test: manual PiperOrigin-RevId: 172154863 Change-Id: Iaf6e217df284e6df6f13688ac6aa677481a575e0
| * Enable Lightbringer upgrades on Mroldenburg2017-10-131-6/+0
| | | | | | | | | | | | Test: existing tests, manual (tested on Nexus 6 running M) PiperOrigin-RevId: 172122858 Change-Id: Ib22e33de3ed134cf76a06af54d054dbb92f91039
| * Fixing voicemail notification bugmdooley2017-10-131-1/+2
|/ | | | | | | | | Added a check for null notification tags when updating voicemail notifications. Bug: 67607115 Test: manual and unit test PiperOrigin-RevId: 172121860 Change-Id: If9fd6ca972a5a1dbd48a9c529f3cb46c3c93fa2a
* Merge "Use CONTENT_URI_WITH_VOICEMAIL for SystemCallLogDataSource"Treehugger Robot2017-10-132-4/+28
|\
| * Use CONTENT_URI_WITH_VOICEMAIL for SystemCallLogDataSourceuabdullah2017-10-132-4/+28
|/ | | | | | | | | Currently the SystemCallLogDataSource queries the call log table with CONTENT_URI. This works for the call log tab, but will not work for the voicemail tab. To allow the voicemail tab to query annotated call log for voicemail information, we need to surface up voicemail data from the system call log data source into the annotated call log. Bug: 64882313,33006245 Test: Unit tests, also verified that in the call log only the non-voicemail entries show PiperOrigin-RevId: 172036196 Change-Id: Ieac855ae854a043207c9ae668280391c790ac33d
* Merge "Set the secondary action to be a voice call when the primary action ↵Treehugger Robot2017-10-131-12/+23
|\ | | | | | | is a video call."
| * Set the secondary action to be a voice call when the primary action is a ↵linyuh2017-10-121-12/+23
|/ | | | | | | | | video call. Bug: 67717800 Test: GoogleCallLogAdapterTest PiperOrigin-RevId: 172013208 Change-Id: I86c4ca1ef7caf1899cb9587d98233a9e707b7f3d
* Merge changes I14a2c0b6,Ic67566c2,Id0ef9164,Iec48f030,Ibe1f9de6, ...Treehugger Robot2017-10-1232-104/+200
|\ | | | | | | | | | | | | | | | | | | | | * changes: Handle invalid PhoneAccountHandle component name in MissedCallNotifier Use TelephonyManagerCompat for IS_REFRESH Updated animation to enter and exit search ui. Optimization for incoming call latency. Fix for voice screen showing for a short time when making a video call Fix incallui to use latest ux mocks for assisted dialing. Remove voicemail count changed check for legacy notifications
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 01:52:40 +0000