Fix DialtactsActivity leaks

The CallLogFragment attaches to ViewPager, and does not show by default,
so it still stay in pause status. If straight exiting Activity, the
method onPause is not called so that the query thread cannot be interrupted.
The class QueryThread is inner class that holds the instance of ContactInfoCache.
But the member mContactInfoHelper of ContactInfoCache already holds the context
of DialtactsActivity so that the instance of DialtactsActivity cannot be recycled.
In order to avoid it, must stop the query thread in the method onStop.

Change-Id: I0bbbf25b95ae82a2d67152edd07c4f7c14498917
CRs-Fixed: 1083453

2 files changed, 8 insertions, 2 deletions

diff --git a/src/com/android/dialer/calllog/CallLogAdapter.java b/src/com/android/dialer/calllog/CallLogAdapter.java
index 462b03681..a1ec0b358 100644
--- a/src/com/android/dialer/calllog/CallLogAdapter.java
+++ b/src/com/android/dialer/calllog/CallLogAdapter.java
@@ -380,6 +380,13 @@ public class CallLogAdapter extends GroupingListAdapter
         }
     }
 
+    public void onStop () {
+        pauseCache();
+        if (mHiddenItemUri != null) {
+            CallLogAsyncTaskUtil.deleteVoicemail(mContext, mHiddenItemUri, null);
+        }
+    }
+
     @VisibleForTesting
     /* package */ void pauseCache() {
         mContactInfoCache.stop();
diff --git a/src/com/android/dialer/calllog/CallLogFragment.java b/src/com/android/dialer/calllog/CallLogFragment.java
index b44d8ca6b..96551a4b4 100644
--- a/src/com/android/dialer/calllog/CallLogFragment.java
+++ b/src/com/android/dialer/calllog/CallLogFragment.java
@@ -354,14 +354,13 @@ public class CallLogFragment extends Fragment implements CallLogQueryHandler.Lis
     @Override
     public void onPause() {
         cancelDisplayUpdate();
-        mAdapter.onPause();
         super.onPause();
     }
 
     @Override
     public void onStop() {
         updateOnTransition();
-
+        mAdapter.onStop();
         super.onStop();
     }