summaryrefslogtreecommitdiffstats
path: root/java/com/android/dialer/lightbringer
diff options
context:
space:
mode:
authorroldenburg <roldenburg@google.com>2017-06-21 12:15:03 -0700
committerEric Erfanian <erfanian@google.com>2017-06-21 13:49:44 -0700
commit64ba7ccfacc75e0733de64c4df2be9f25aa811cb (patch)
tree1fa52bfc077ac8f72708a4bc7162978d642206f6 /java/com/android/dialer/lightbringer
parent22edf57d65dd1382128df841d7bfc4c74dc17814 (diff)
downloadandroid_packages_apps_Dialer-64ba7ccfacc75e0733de64c4df2be9f25aa811cb.tar.gz
android_packages_apps_Dialer-64ba7ccfacc75e0733de64c4df2be9f25aa811cb.tar.bz2
android_packages_apps_Dialer-64ba7ccfacc75e0733de64c4df2be9f25aa811cb.zip
Make Lightbringer getPackageName Nullable
An empty string isn't as clear and can lead to incorrectly matching other intents when just comparing package names. PiperOrigin-RevId: 159725546 Change-Id: I2943b3569fb6409f5c69deb2032f3d8248f6c14d
Diffstat (limited to 'java/com/android/dialer/lightbringer')
-rw-r--r--java/com/android/dialer/lightbringer/Lightbringer.java2
-rw-r--r--java/com/android/dialer/lightbringer/stub/LightbringerStub.java4
2 files changed, 3 insertions, 3 deletions
diff --git a/java/com/android/dialer/lightbringer/Lightbringer.java b/java/com/android/dialer/lightbringer/Lightbringer.java
index 510f8a9a7..669e571a0 100644
--- a/java/com/android/dialer/lightbringer/Lightbringer.java
+++ b/java/com/android/dialer/lightbringer/Lightbringer.java
@@ -53,7 +53,7 @@ public interface Lightbringer {
@MainThread
PhoneAccountHandle getPhoneAccountHandle();
- @NonNull
+ @Nullable
@MainThread
String getPackageName();
}
diff --git a/java/com/android/dialer/lightbringer/stub/LightbringerStub.java b/java/com/android/dialer/lightbringer/stub/LightbringerStub.java
index c835fea0f..1cb3c1ff0 100644
--- a/java/com/android/dialer/lightbringer/stub/LightbringerStub.java
+++ b/java/com/android/dialer/lightbringer/stub/LightbringerStub.java
@@ -92,9 +92,9 @@ public class LightbringerStub implements Lightbringer {
return null;
}
- @NonNull
+ @Nullable
@Override
public String getPackageName() {
- return "";
+ return null;
}
}