summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEthan Chen <intervigil@gmail.com>2014-10-21 14:12:04 -0700
committerEthan Chen <intervigil@gmail.com>2014-10-21 14:13:26 -0700
commit017cbbfc8506df53b9b21c833e210eabf17e76c9 (patch)
tree00a9491653734b904672f1a8fa999726cc6390a1
parent27a00503ab3319aa1ea07fd95355d27af6b26e13 (diff)
downloadandroid_packages_apps_Dialer-017cbbfc8506df53b9b21c833e210eabf17e76c9.tar.gz
android_packages_apps_Dialer-017cbbfc8506df53b9b21c833e210eabf17e76c9.tar.bz2
android_packages_apps_Dialer-017cbbfc8506df53b9b21c833e210eabf17e76c9.zip
Dialer: Fix possible crash in call details
* VOIP calling when multi-SIM is active can result in subscription being -1 at this point, resulting in array out of bounds when fetching the SIM icon. Change-Id: I1ce2c3bb0b27b26b61967dfe90b38cc9740a1f54
-rwxr-xr-xsrc/com/android/dialer/PhoneCallDetailsHelper.java6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/com/android/dialer/PhoneCallDetailsHelper.java b/src/com/android/dialer/PhoneCallDetailsHelper.java
index 394b4d6e0..64907055f 100755
--- a/src/com/android/dialer/PhoneCallDetailsHelper.java
+++ b/src/com/android/dialer/PhoneCallDetailsHelper.java
@@ -85,8 +85,10 @@ public class PhoneCallDetailsHelper {
// Display the icon for the last call sub.
if (MSimTelephonyManager.getDefault().isMultiSimEnabled()) {
views.subIconView.setVisibility(View.VISIBLE);
- views.subIconView.setImageDrawable(
- DialtactsActivity.getMultiSimIcon(mContext, details.subscription));
+ if (details.subscription >= 0) {
+ views.subIconView.setImageDrawable(
+ DialtactsActivity.getMultiSimIcon(mContext, details.subscription));
+ }
} else {
views.subIconView.setVisibility(View.GONE);
}