summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Find proper snippet in multi-line and large result.Chiao Cheng2012-12-2810-22/+464
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previous CL removed the use ContactsContract.snippetize(). This method found the proper line in a multi-line results and then snippetized the line if it was too long. This CL adds that functionality back without using snippetize(). This new code is faster because it only does text intensive processing when the text is long. The previous snippetize method did processing for all strings. In addition, the old method iterated over the snippet multiple times (i.e. first with contains, then subsequently tokenizes, etc). This change re-uses the initial search results and remembers the search information so multiple iterations are not necessary. In addition, tokenizing has been optimized based on the match. We only need to chop off excess content rather than tokenizing the whole string. This CL also makes snippet more friend to landscape mode. Previously, the number of snippet tokens shown was hard-coded to 2 on each side. Furthermore, this caused longer tokens to exceed screen real estate. Now the number of tokens shown are determined more accurately by character count versus real estate. In landscape mode, this allows us to show much more of the search result. Finally, fixed a highlight problem when the search query contained punctuation. For example, a search for {.ben.} would not match {ben}. This Cl resolves that issue by cleaning the search query. Bug: 5929143 Change-Id: I5c368e6de8b34ca912f86926f862a02f95199fa7
* Fix broken build.Chiao Cheng2012-12-261-14/+13
| | | | | | Related to I1883621bb64452726cd92035d30001c29b478574. Change-Id: I667fd3bd46f7884d3c38118fc72b227805127e29
* Fixing missing punctuation for punctuation search case.Chiao Cheng2012-12-266-18/+29
| | | | | | | | | | | | | | | | | | | Previous CL I9cbdf10d21c79f53bc621bacb7eeeb95a6a2435f fixed missing punctuation at the start when searching without punctuation. (e.g. {hello}) This CL fixes the case where leading punctuation is missing if you searched with a leading punctuation. (e.g. {'hello}). The content provider uses a different code path when it detects multi-words and snippeting is actually done in sqlite using the FTS snippet method. The check for multi-word was treating {'hello} as two words. This means that multi-word searches will still have this issue as it still uses the sqlite snippet method. Leaving this to a separate CL since it's a riskier change. Bug: 5929143 Change-Id: I1883621bb64452726cd92035d30001c29b478574
* Include starting and ending punctuation.Chiao Cheng2012-12-191-36/+76
| | | | | | | | | | | | | | The snippetize method was leaving out the delimiters at the start and end of the snippetized string. Upon further investigation, the snippetize method is not needed because showSnippet() always puts the string back into it's original form (i.e. it was undoing the work of snippetize) at the end of the method. The solution is to pass the original form into setSnippet() when deferred snippeting is requested. This eliminates a lot of unnecessary processing. Bug: 5929143 Change-Id: I9cbdf10d21c79f53bc621bacb7eeeb95a6a2435f
* Merge "Making sort order for strequent and starred consistent."Chiao Cheng2012-12-121-3/+6
|\
| * Making sort order for strequent and starred consistent.Chiao Cheng2012-12-111-3/+6
| | | | | | | | | | Bug: 5783101 Change-Id: Id70313d6bfc0425445c954d90bf9dac9c2b9a764
* | Merge "Log clean-up."Chiao Cheng2012-12-121-1/+3
|\ \
| * | Log clean-up.Chiao Cheng2012-12-121-1/+3
| |/ | | | | | | | | Bug: 5571947 Change-Id: I958311b44739fe8fedeb5fea0dd8e507837d8e31
* / Import translations. DO NOT MERGEBaligh Uddin2012-12-127-28/+28
|/ | | | | Change-Id: I6e6ca5b637bc445d7487ed7559c3ab7ae18fd3ff Auto-generated-cl: translation import
* Remove un-used footer panel.Chiao Cheng2012-12-112-47/+0
| | | | | Bug: 7710803 Change-Id: I476b49d25467af0bc3dc34945d84e6ff8735bc7c
* Merge "Add empty list message."Chiao Cheng2012-12-111-4/+0
|\
| * Add empty list message.Chiao Cheng2012-12-101-4/+0
| | | | | | | | | | Bug: 7403225 Change-Id: Ib57e5bbb17ac7f3a7a08c2c0b015d2bd7a61a459
* | Import translations. DO NOT MERGEBaligh Uddin2012-12-1047-7658/+3841
| | | | | | | | | | Change-Id: I622fe3629b3f2bf34f708629b299cb68b51d3400 Auto-generated-cl: translation import
* | Fixing bad import.Chiao Cheng2012-12-061-1/+1
|/ | | | | Bug: 6993891 Change-Id: I350d70a1edacfa3eaa6226e93a71981edacc0f40
* Merge "Moving ProportionalLayout to ContactsCommon."Chiao Cheng2012-12-061-0/+146
|\
| * Moving ProportionalLayout to ContactsCommon.Chiao Cheng2012-12-061-0/+146
| | | | | | | | | | Bug: 6993891 Change-Id: I6a9d7905daa3d412248c83878db747e08982cc42
* | Merge "Refactor editor layout file dependencies out of common."Chiao Cheng2012-12-0620-620/+33
|\ \
| * | Refactor editor layout file dependencies out of common.Chiao Cheng2012-12-0620-620/+33
| |/ | | | | | | | | | | | | | | | | | | | | | | Editor view layout files are only needed by the Contacts app. But they were being referenced from within AccountTypeManager and several other classes. These references are un-necessary and would have caused too many editor dependencies, such as the EditorView classes, to go into common. With the refactor, many layout files can move back into Contacts. Bug: 6993891 Change-Id: Ifb3ce45120ba2181cb02cac9820a30c185108739
* | Merge "Remove dead code"Yorke Lee2012-12-063-14/+0
|\ \
| * | Remove dead codeYorke Lee2012-12-063-14/+0
| | | | | | | | | | | | | | | Bug: 6148388 Change-Id: I5b08d6534a794361e67ba2ad72148fed10a5b148
* | | Import translations. DO NOT MERGEBaligh Uddin2012-12-0649-657/+1799
| |/ |/| | | | | | | Change-Id: I506e7958932cb16bada2c13618d15f53b7a7cfbf Auto-generated-cl: translation import
* | Merge "Moving quick contact resources into common."Chiao Cheng2012-12-051-0/+15
|\ \
| * | Moving quick contact resources into common.Chiao Cheng2012-12-051-0/+15
| |/ | | | | | | | | Bug: 6993891 Change-Id: I23d0f0f0a3df2994087a386f26a0d73e116faeae
* | Merge "Import translations. DO NOT MERGE"Baligh Uddin2012-12-0549-161/+6219
|\ \ | |/ |/|
| * Import translations. DO NOT MERGEBaligh Uddin2012-12-0549-161/+6219
| | | | | | | | | | Change-Id: I4cbb6a0eda3d1498c0ee02a593f483d796fbd599 Auto-generated-cl: translation import
* | Major resource move and clean-up.Chiao Cheng2012-12-0547-10/+605
|/ | | | | | | | Moving resources from Contacts to ContactsCommon and Dialer as necessary to remove dialer dependencies on contacts app. Bug: 6993891 Change-Id: I5ff17028cb675694809cdc08e5ee80c444ee8666
* Moving depedencies of DialtactsActivity into ContactsCommon.Chiao Cheng2012-12-044-0/+1227
| | | | | | | | This completes the clean-up of class depedencies for DialtactsActivity in the Dialer. Bug: 6993891 Change-Id: Ic22e5d6a643a569bfd76e5b913e6c45795ae80f2
* Moving ImportExportDialogFragment to ContactCommon.Chiao Cheng2012-12-044-0/+306
| | | | | | | | This completes the dependency clean-up of the PhoneFavoriteFragment in the dialer. Bug: 6993891 Change-Id: I76200a7b2f6bc3c8d5e229b70c3cdf9998d32ec2
* Moving SelectAccountDialogFragment to ContactsCommon.Chiao Cheng2012-12-046-0/+390
| | | | | | | | | In preparation to move ImportExportDialogFragment to common. Also moved a few more string resources left out from previous move. Bug: 6993891 Change-Id: I978e490d256cf783db91b52bca46f4a1c678e415
* Merge "Moving vcard UI to ContactsCommon."Chiao Cheng2012-12-0420-0/+3999
|\
| * Moving vcard UI to ContactsCommon.Chiao Cheng2012-12-0320-0/+3999
| | | | | | | | | | | | | | | | Moving all class in vcard directory in preparation to move ImportExportDialogFragment. Bug: 6993891 Change-Id: I4391c6e63d20ebe91e240001885a6ce18388e51f
* | Import translations. DO NOT MERGEBaligh Uddin2012-12-0449-0/+1568
|/ | | | | Change-Id: Ic79745f2ae9ccec18085e917b32be39c0b9e1956 Auto-generated-cl: translation import
* Fixing copyright years after accidental change during move.Chiao Cheng2012-12-0311-131/+131
| | | | | | | | Putting copyright years back to original. They were updated accidentally during the file moves. Also correcting style changes. Bug: 6993891 Change-Id: I6d6ba84a872c611d6bc8a436461b16b2336eb399
* Further clean-up of PhoneFavoriteFragment in Dialer app.Chiao Cheng2012-12-0339-12/+2749
| | | | | | | | Moving dependencies of Dialer PhoneFavoriteFragment. Mostly filtering dependencies. Bug: 6993891 Change-Id: Ic2b29b80ae2367f54e619b30bdb71b098c8a0deb
* Move ValuesDelta to ContactsCommon.Chiao Cheng2012-11-302-0/+658
| | | | | Bug: 6993891 Change-Id: Iaf94a00abfb64c9b0eb547dd446f743f6cd855ce
* Merge "Move AccountTypeManager to ContactsCommon."Chiao Cheng2012-11-263-0/+1195
|\
| * Move AccountTypeManager to ContactsCommon.Chiao Cheng2012-11-263-0/+1195
| | | | | | | | | | | | | | | | Moving AccountTypeManager to ContactsCommon so it can be shared by Contacts and Dialer. Bug: 6993891 Change-Id: If8bc8137b0b5800f21ee46aa4027b79e0048d32e
* | Import translations. DO NOT MERGEBaligh Uddin2012-11-2017-56/+56
|/ | | | | Change-Id: I129f88754967d36b7382a45d70227638b8cab6c6 Auto-generated-cl: translation import
* Merge "Import translations. DO NOT MERGE"Baligh Uddin2012-11-1649-303/+3062
|\
| * Import translations. DO NOT MERGEBaligh Uddin2012-11-1649-303/+3062
| | | | | | | | | | Change-Id: I215ad3464cb18f462e0f08a27006a0b678dc62e1 Auto-generated-cl: translation import
* | Merge "Final move of AccountTypeManager dependencies."Chiao Cheng2012-11-162-0/+53
|\ \ | |/ |/|
| * Final move of AccountTypeManager dependencies.Chiao Cheng2012-11-162-0/+53
| | | | | | | | | | | | | | After this change, AccountTypeManager can be moved into ContactsCommon. Bug: 6993891 Change-Id: I73974557274379fd307ed2b5e787f448fb1fc3c5
* | Merge "Import translations. DO NOT MERGE"Baligh Uddin2012-11-1549-0/+481
|\ \ | |/ |/|
| * Import translations. DO NOT MERGEBaligh Uddin2012-11-1449-0/+481
| | | | | | | | | | Change-Id: Ifd5bea5ccf849d0a8ef336b27c80b297115c0f0c Auto-generated-cl: translation import
* | Use Objects from guava library.Chiao Cheng2012-11-141-1/+1
| | | | | | | | | | | | | | Switch com.android.internal.util.Objects to com.google.common.base.Objects. Bug: 6948882 Change-Id: I3756c3db7fc95728c052529e69735c6ee8e28665
* | Merge "Move dependencies of AccountTypeManager into ContactsCommon."Chiao Cheng2012-11-1469-2/+6024
|\ \ | |/ |/|
| * Move dependencies of AccountTypeManager into ContactsCommon.Chiao Cheng2012-11-1369-2/+6024
| | | | | | | | | | | | | | Moving dependencies in preparation to move AccountTypeManager. Bug: 6993891 Change-Id: I10893209986efd288315dc6b51c7971838ac3923
* | Merge changes from conflicting accessibility change.Chiao Cheng2012-11-131-8/+3
|/ | | | | | | | Resolved conflict from 3c0e293e8fbcf2636f45e729f6102cc752c59119. File was deleted from Contacts and moved into ContactsCommon. Bug: 7486402 Change-Id: I685af18c3d85b25ae81a34daac0f42a93e00793b
* Merge "Further clean-up of PhoneFavoriteFragment."Chiao Cheng2012-11-1322-0/+1773
|\
| * Further clean-up of PhoneFavoriteFragment.Chiao Cheng2012-11-0922-0/+1773
| | | | | | | | | | | | | | Moving common dependencies from Contacts to ContactsCommon. Bug: 6993891 Change-Id: I7530d13771b65f17dafa3f4f8283965622b1c71e