From e4a8ad5bc71f8d2e84985ae7c1efbaa94849183b Mon Sep 17 00:00:00 2001 From: Wang Han <416810799@qq.com> Date: Wed, 12 Sep 2018 12:25:31 +0800 Subject: Camera2: Request for ACCESS_FINE_LOCATION permission * ACCESS_COARSE_LOCATION only allows to access approximate location. Change-Id: Ic512f574b32e01baa115a0a784f437c8225b85c3 --- AndroidManifest.xml | 1 - src/com/android/camera/CameraActivity.java | 2 +- src/com/android/camera/PermissionsActivity.java | 4 ++-- src/com/android/camera/app/FirstRunDialog.java | 4 ++-- src/com/android/camera/settings/CameraSettingsActivity.java | 4 ++-- 5 files changed, 7 insertions(+), 8 deletions(-) diff --git a/AndroidManifest.xml b/AndroidManifest.xml index 6da5c1d94..09f6ee6dc 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -8,7 +8,6 @@ android:minSdkVersion="19" android:targetSdkVersion="28" /> - diff --git a/src/com/android/camera/CameraActivity.java b/src/com/android/camera/CameraActivity.java index 2de3ae825..92f08107a 100644 --- a/src/com/android/camera/CameraActivity.java +++ b/src/com/android/camera/CameraActivity.java @@ -1956,7 +1956,7 @@ public class CameraActivity extends QuickActivity } if (!mHasCriticalPermissions || (mSettingsManager.getBoolean( SettingsManager.SCOPE_GLOBAL, Keys.KEY_RECORD_LOCATION) && - (checkSelfPermission(Manifest.permission.ACCESS_COARSE_LOCATION) + (checkSelfPermission(Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED) && !mSettingsManager.getBoolean(SettingsManager.SCOPE_GLOBAL, Keys.KEY_HAS_SEEN_PERMISSIONS_DIALOGS))) { diff --git a/src/com/android/camera/PermissionsActivity.java b/src/com/android/camera/PermissionsActivity.java index aca4778e6..48f262f6c 100644 --- a/src/com/android/camera/PermissionsActivity.java +++ b/src/com/android/camera/PermissionsActivity.java @@ -137,7 +137,7 @@ public class PermissionsActivity extends QuickActivity { if (mSettingsManager.getBoolean(SettingsManager.SCOPE_GLOBAL, Keys.KEY_RECORD_LOCATION) - && (checkSelfPermission(Manifest.permission.ACCESS_COARSE_LOCATION) + && (checkSelfPermission(Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED)) { mNumPermissionsToRequest++; mShouldRequestLocationPermission = true; @@ -182,7 +182,7 @@ public class PermissionsActivity extends QuickActivity { permissionsRequestIndex++; } if (mShouldRequestLocationPermission) { - permissionsToRequest[permissionsRequestIndex] = Manifest.permission.ACCESS_COARSE_LOCATION; + permissionsToRequest[permissionsRequestIndex] = Manifest.permission.ACCESS_FINE_LOCATION; mIndexPermissionRequestLocation = permissionsRequestIndex; } diff --git a/src/com/android/camera/app/FirstRunDialog.java b/src/com/android/camera/app/FirstRunDialog.java index 58e1fcbba..35330fa85 100644 --- a/src/com/android/camera/app/FirstRunDialog.java +++ b/src/com/android/camera/app/FirstRunDialog.java @@ -210,11 +210,11 @@ public class FirstRunDialog { } private void checkLocationPermission() { - if (mContext.checkSelfPermission(Manifest.permission.ACCESS_COARSE_LOCATION) + if (mContext.checkSelfPermission(Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED) { Activity activity = (Activity) mContext; activity.requestPermissions( - new String[] {Manifest.permission.ACCESS_COARSE_LOCATION}, + new String[] {Manifest.permission.ACCESS_FINE_LOCATION}, PERMISSION_REQUEST_CODE); mSettingsManager.set(SettingsManager.SCOPE_GLOBAL, Keys.KEY_HAS_SEEN_PERMISSIONS_DIALOGS, true); diff --git a/src/com/android/camera/settings/CameraSettingsActivity.java b/src/com/android/camera/settings/CameraSettingsActivity.java index a64770043..f6abc36cb 100644 --- a/src/com/android/camera/settings/CameraSettingsActivity.java +++ b/src/com/android/camera/settings/CameraSettingsActivity.java @@ -352,9 +352,9 @@ public class CameraSettingsActivity extends FragmentActivity { if (key.equals(Keys.KEY_RECORD_LOCATION) && sharedPreferences.getString(key, "0").equals("1")) { Context context = this.getActivity().getApplicationContext(); - if (context.checkSelfPermission(Manifest.permission.ACCESS_COARSE_LOCATION) + if (context.checkSelfPermission(Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED) { - requestPermissions(new String[] {Manifest.permission.ACCESS_COARSE_LOCATION}, + requestPermissions(new String[] {Manifest.permission.ACCESS_FINE_LOCATION}, PERMISSION_REQUEST_CODE); } } -- cgit v1.2.3