summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSpike Sprague <spikuru@google.com>2014-09-22 10:52:32 -0700
committerSpike Sprague <spikuru@google.com>2014-09-22 11:24:11 -0700
commit5cc48d6032b9412d5825c82ab70f145c3c3056a4 (patch)
treec531e73df9aa3fea6baba124a8e84884dd7770d8
parent02758e4c60ea1ff5a78c6d7d8d77ee353a2bf6f5 (diff)
downloadandroid_packages_apps_Camera2-5cc48d6032b9412d5825c82ab70f145c3c3056a4.tar.gz
android_packages_apps_Camera2-5cc48d6032b9412d5825c82ab70f145c3c3056a4.tar.bz2
android_packages_apps_Camera2-5cc48d6032b9412d5825c82ab70f145c3c3056a4.zip
monkey test NPE fix, another null check on mCameraDevice
bug: 17604028 Change-Id: I7b45c101045b765562146ebe2c779e227a6227bd
-rw-r--r--src/com/android/camera/PhotoModule.java6
1 files changed, 5 insertions, 1 deletions
diff --git a/src/com/android/camera/PhotoModule.java b/src/com/android/camera/PhotoModule.java
index ab6afdb2a..8f42014bd 100644
--- a/src/com/android/camera/PhotoModule.java
+++ b/src/com/android/camera/PhotoModule.java
@@ -2321,7 +2321,11 @@ public class PhotoModule
updateCameraParametersPreference();
}
- mCameraDevice.applySettings(mCameraSettings);
+ // some monkey tests can get here when shutting the app down
+ // make sure mCameraDevice is still valid, b/17604028
+ if (mCameraDevice != null) {
+ mCameraDevice.applySettings(mCameraSettings);
+ }
}
// If the Camera is idle, update the parameters immediately, otherwise