From 9675253917e4207a811386ace164f5238ec0d25c Mon Sep 17 00:00:00 2001 From: Paul Sliwowski Date: Mon, 20 May 2013 21:03:55 -0700 Subject: Remove dead code in AlarmService. Bug: 8766415 Only DismissAlarmsService handles DELETE_ALL_ACTION, so removing the handling out of AlarmService. Change-Id: I0c90033c5af16f02c72c81c5d407528ce644db58 --- src/com/android/calendar/alerts/AlertReceiver.java | 12 +++--------- src/com/android/calendar/alerts/DismissAlarmsService.java | 8 ++++++++ 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/src/com/android/calendar/alerts/AlertReceiver.java b/src/com/android/calendar/alerts/AlertReceiver.java index e1f7dec6..e34c533d 100644 --- a/src/com/android/calendar/alerts/AlertReceiver.java +++ b/src/com/android/calendar/alerts/AlertReceiver.java @@ -68,7 +68,6 @@ import java.util.regex.Pattern; public class AlertReceiver extends BroadcastReceiver { private static final String TAG = "AlertReceiver"; - private static final String DELETE_ALL_ACTION = "com.android.calendar.DELETEALL"; private static final String MAP_ACTION = "com.android.calendar.MAP"; private static final String CALL_ACTION = "com.android.calendar.CALL"; private static final String MAIL_ACTION = "com.android.calendar.MAIL"; @@ -103,13 +102,7 @@ public class AlertReceiver extends BroadcastReceiver { if (AlertService.DEBUG) { Log.d(TAG, "onReceive: a=" + intent.getAction() + " " + intent.toString()); } - if (DELETE_ALL_ACTION.equals(intent.getAction())) { - - // The user has dismissed a digest notification. - // TODO Grab a wake lock here? - Intent serviceIntent = new Intent(context, DismissAlarmsService.class); - context.startService(serviceIntent); - } else if (MAP_ACTION.equals(intent.getAction())) { + if (MAP_ACTION.equals(intent.getAction())) { // Try starting the map action. // If no map location is found (something changed since the notification was originally // fired), update the notifications to express this change. @@ -222,6 +215,7 @@ public class AlertReceiver extends BroadcastReceiver { boolean showEvent) { Intent intent = new Intent(); intent.setClass(context, DismissAlarmsService.class); + intent.setAction(DismissAlarmsService.DELETE_ALL_ACTION); intent.putExtra(AlertUtils.EVENT_ID_KEY, eventId); intent.putExtra(AlertUtils.EVENT_START_KEY, startMillis); intent.putExtra(AlertUtils.EVENT_END_KEY, endMillis); @@ -477,7 +471,7 @@ public class AlertReceiver extends BroadcastReceiver { // expired events. Intent deleteIntent = new Intent(); deleteIntent.setClass(context, DismissAlarmsService.class); - deleteIntent.setAction(DELETE_ALL_ACTION); + deleteIntent.setAction(DismissAlarmsService.DELETE_ALL_ACTION); deleteIntent.putExtra(AlertUtils.EVENT_IDS_KEY, eventIds); deleteIntent.putExtra(AlertUtils.EVENT_STARTS_KEY, startMillis); PendingIntent pendingDeleteIntent = PendingIntent.getService(context, 0, deleteIntent, diff --git a/src/com/android/calendar/alerts/DismissAlarmsService.java b/src/com/android/calendar/alerts/DismissAlarmsService.java index d5dfaf30..e4ab89f4 100644 --- a/src/com/android/calendar/alerts/DismissAlarmsService.java +++ b/src/com/android/calendar/alerts/DismissAlarmsService.java @@ -27,6 +27,7 @@ import android.os.IBinder; import android.provider.CalendarContract.CalendarAlerts; import android.support.v4.app.TaskStackBuilder; +import android.util.Log; import com.android.calendar.EventInfoActivity; import com.android.calendar.alerts.GlobalDismissManager.AlarmId; @@ -37,6 +38,9 @@ import java.util.List; * Service for asynchronously marking fired alarms as dismissed. */ public class DismissAlarmsService extends IntentService { + public static final String DELETE_ALL_ACTION = "com.android.calendar.DELETEALL"; + private static final String TAG = "DismissAlarmsService"; + private static final String[] PROJECTION = new String[] { CalendarAlerts.STATE, }; @@ -53,6 +57,10 @@ public class DismissAlarmsService extends IntentService { @Override public void onHandleIntent(Intent intent) { + if (!DELETE_ALL_ACTION.equals(intent.getAction())) { + Log.wtf(TAG, String.format("Unknown Action: %s", intent.getAction())); + return; + } long eventId = intent.getLongExtra(AlertUtils.EVENT_ID_KEY, -1); long eventStart = intent.getLongExtra(AlertUtils.EVENT_START_KEY, -1); -- cgit v1.2.3