aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fixed ANR & Memory Leak Associated with 3GPcaf/cm-12.0herriojr2015-08-053-3/+23
| | | | | | | | | | | We are now defaulting to treating 3GP files as video files for determining the default icon as it was parsing the video files for their metadata which was causing ANR problems. On top of this, it was discovered that the metadata parser was leaking memory. Change-Id: I88f6cf3d8ae1a62d1294bd3272b27715c2352525 Ticket: QRDL-931 (cherry picked from commit 6f6094da21960569b93f6171e39e211e8d37f41a)
* Fixed search to actually open the clicked folderherriojr2015-08-052-3/+8
| | | | | | | | | | | | | | When a folder was clicked in a search, what was happening is the refresh() in onStart() was being executed after onActivityResult(), so the changeCurrentDir() executed in onActivityResult() was being overriden by the refresh in onStart(). Since the mCurrentDir wasn't being set until the NavigationTask ends, it would always go back to the original directory. The change is to make the refresh not happen if a NavigationTask is currently under way. Change-Id: I5c354554c9b15fc9d14b4665852b40fb6a1f8853 Ticket: QRDL-932 (cherry picked from commit c740f92994c3e8dbbf985ef18d7d639756f1e0a9)
* Fixed ANR associated with SecureStorageherriojr2015-08-052-22/+17
| | | | | | | | | | | | | | An ANR was happening on SecureConsole when a very large item was added, canceled, and click the parent in the Secure folder. This is caused by the locking mechanism used by SecureConsole. Consoles, long-term, need to be refactored to not synchronize on the SecureConsole object itself during execute. The only fix we can do without full refactoring is to not allow cancelling the operation because the Console doesn't support the cancel operation. Change-Id: I845372567b8656d63192bfde27952240915ecfe6 Ticket: QRDL-971 (cherry picked from commit ddb22bba80ce56ca77eca2faeace1d33aff85cc1)
* Revert "Made NavigationView reliant on FileObserver to keep up to date."herriojr2015-08-056-234/+206
| | | | | | | This reverts commit 7b09bb0f1390b72d0ac18484721998eaf805e605. Change-Id: I24b6115c89e568f6895a3a9d0c074151b85c0be2 (cherry picked from commit cb05075905b8271204bc2f0306f36f92c35fff80)
* Made NavigationView reliant on FileObserver to keep up to date.herriojr2015-07-316-206/+234
| | | | | | | | | | | | | | We no longer deal with having to refresh a directory upon reentering. Instead we now just listen on the directory for changes and update as necessary. This will make it much more difficult to get out of sync with the file system in pretty much all situations. Changed per comments on patch to no longer do refreshes for the list when items change as the FileObserver handles all of this. Change-Id: I28a6af965708ce76107a09d6b931f4c7bafb8365 Ticket: QRDL-932 (cherry picked from commit 7b09bb0f1390b72d0ac18484721998eaf805e605)
* ANR Caused by passes over Data Set on notifyDataSetChanged()herriojr2015-07-301-196/+71
| | | | | | | | | | | | Logic existed which took a pass over the data on the UI thread each time notifyDataSetChange was called which can cause an ANR on a large data set. This fix removes a lot of the unnecessary logic associated with this and moves it to getView(). Performance still seems good on the OnePlus for scrolling. Change-Id: Idde74f0688fef0ba7e4b560b06d9494896a24174 Ticket: QRDL-931 (cherry picked from commit df55584ec69388fbc418c7236f20868e45f37caf)
* Fix Secure SD Card Entry to open folder.herriojr2015-07-271-2/+2
| | | | | | | | | | | | Whenever the secure folder was opened from the drawer, it would prompt for a password and then go to the root folder again. This was caused by the logic in onResume() which is all meant for when entering another activity and then coming back into this activity. This should really be the job on onStart() as onResume() also handles dialogs. Change-Id: I45e0e44e3e8f9031b0685628a3f24c02725e24e1 Ticket: QRDL-946 (cherry picked from commit 9426b243dd41dea57718efa922e9c5f345338472)
* Refactored the ImageLoader a bit, so that it doesn't have troubleherriojr2015-07-273-152/+157
| | | | | | | | | | | loading images. There were a couple of problem causing this, so I felt it best to change the implementation. Change-Id: Ic77a94681d77fa4fba49f3f24f40e260220b925a Ticket: QRDL-905 (cherry picked from commit c310a84552206b25705d2e7d2113c95ce29d8ecf)
* Moved the sort of the data set off the UI Thread.herriojr2015-07-221-9/+15
| | | | | | | | | For large data sets, this can cause slowdown on older devices or if you have a significant data set size. Change-Id: I1eeea9132df0d4e5c8dad17009b648826e3386c6 Ticket: QRDL-931 (cherry picked from commit 3303817816ef785de8d29d69dddd35b4fe22c5c4)
* configurationChanged: Don't handle the orientation change in our main ActivityStephen Bird2015-07-171-1/+1
| | | | | | | | Let file manager redraw its actionbar on rotate. Otherwise, strange things happen with popupwindows Change-Id: I3c88e6df92251e895030bb80e4f3d7417716f505 (cherry picked from commit 8cd911bf2fd48aa9a1479486bff82a702cc37165)
* Changed NavigationView.refresh() in onResume() of the activity to tryherriojr2015-07-161-1/+1
| | | | | | | | | | | | | to restore the original position. The only caveat is because the history items don't maintain the scroll offset, it's not a perfect restore. Ideally, we want to maintain the scroll offsets of the first item within the AdapterView and restore those as well. Change-Id: I69b01bef11e26a29aabd57d2bc3e7853b6f67e08 Ticket: QRDL-922 (cherry picked from commit 84ff5edc9e6f3331a5324e3f273998e4bed13b58)
* Preferences: Move huge paragraph description to own itemStephen Bird2015-07-161-1/+3
| | | | | | | | | | | In some languages, this doesn't fit well into the switch preference. This huge wall of text also looks pretty bad when it shares a row with the switch itself. On its own row, this fits quite nicely. Change-Id: I0b35d84965a800e578d3557bfc522f34aabb79f0 (cherry picked from commit b8aa362e3bce47d4d0cd91dd19dea47081f790a0) (cherry picked from commit 84f1c2f4920dc90c75b0d3e94ac8215c8e4de719)
* ProgressDialog: Require user to explicitly use the cancel button.Stephen Bird2015-07-161-0/+1
| | | | | | | | This prevents accidental touches outside of the dialog during long operations Change-Id: I5d903a56aa8e72963967629bd4d844d19e3922dc (cherry picked from commit 707e828f286373a2590ebf5e202afd3b9e854f02) (cherry picked from commit cea98f7514e93509855bf2f03d32051d53ef1642)
* Editor: Handle content uri's in the editorStephen Bird2015-07-161-58/+211
| | | | | | | | | | | | | | | | | | | Previously, files opened that were not contained inside the /data/media partition were considered invalid. Repo steps: - Open email with .txt attachment - Open attachment with Editor This also fixes similar issues all across the system where content uri's would not open in editor. Previously they would report that the user needed to gain root access. Change-Id: I15aa3fd81ae261f66920d253d6adebe28cf28e66 (cherry picked from commit e09d8433144ac84045e1fbd7bb4723c7cfb66c65) (cherry picked from commit be658840ab937f11cf74de61a9ed086bf2f6cec3)
* Secure Storage: Fix unlock buttonStephen Bird2015-07-101-3/+3
| | | | | | Change-Id: I852fff76aef4f47bbd6d809c64afcc2f77165553 (cherry picked from commit c2832885bd00d45ac7277930cff68063e1cb4d3a) (cherry picked from commit 383538f8276690ba272d5ff740ad021ad5c95ca8)
* Easy Mode: Fix exit on easy mode screenStephen Bird2015-07-101-4/+6
| | | | | | Change-Id: Iec39763194916c12c1947fb4f297e74c6dfa2f5f (cherry picked from commit b4d6b6ec45f4f3310220816a9ea85ac41b3b5995) (cherry picked from commit 924bfe5e339c0aa7b62b4a768762f36302f58d21)
* Search: Hide progress spinner if search failsStephen Bird2015-07-021-0/+2
| | | | | Change-Id: I883bd3587e91cfc6ee73eec45ea9840d781719bb (cherry picked from commit 76e0032448aa0ff667ea2c700cfed26941c413fd)
* [CMFileManager] Fix "File Manager isn't responding..." pops up after tapping ↵kai.cao2015-07-011-10/+10
| | | | | | | | | | | | | | | | "Secure storage" in File Manager Procedures 1.Go to “File Manager”. 2.Press "Menu" icon on upper left corner,and then tap "Secure storage". 3.Select "CANCEL" when the note "Create storage" pops up. 4.Repeat Step2 again,check the phone Have no response when pressing "Secure storage",wait about 10-20s,the note "File Manager isn't responding..." pops up. Change-Id: I8ce4b55002d6fc34f89c4a59404469e7f3637cbc (cherry picked from commit ebd0462a7320bf093d0209cfbbfa290df28cee69) (cherry picked from commit adfbdeec4e75b854dd9b016b67634371db24bc4f)
* ActionBar TextSelection: Prevent overlay of textfieldStephen Bird2015-06-302-6/+3
| | | | | | | | | | | | | | | Selected text in the actionbar would be covered by the actionbar options. Eg: Search Repro steps: - Click the search button in CMFM - Type something into the searchbox - Select that text - Text is covered Change-Id: Ie4978035b27d938becf847f6438baffd0a099f14 (cherry picked from commit dad28ad7e93f5bc28509387ff3404d053f575e1e) (cherry picked from commit 96808622be12964752cfc158d2afb0ddec177503)
* Invalidate preferences headers when resumingd34d2015-06-151-0/+7
| | | | | | | | | | | | If the use is in a sub settings, i.e. general settings, and changes their language. Upon returning to File Manager and pressing back to go to the main settings menu, the about text will remain in the previous language. This is easily reproduced when the intial language is set to Chinese and then switched to English. The about text will still be in Chinese. Change-Id: I1dff61a6a94e6aabf336d863e102c29044f3a649 (cherry picked from commit b35b682bd4d4a089d55fcf43a0711a9b9ca7c615)
* Properly validate fields when resetting passwordd34d2015-06-131-2/+3
| | | | | | | | | | | | The logic for validating secure storage passwords is designed for when a user creates a new password and not when they reset it. This causes the dialog to enable the "Reset" button prematurely. This patch adds the necessary checks for when mResetPassword is true Change-Id: I6d52865b2316ff6eeffeb5eaf61e787f6222e9f7 (cherry picked from commit 215e74651e478c148a92695d86e36d100711ab63) (cherry picked from commit 1359c13d2328a4746bf8bfe2552745233ea929b6)
* onResume: Refresh current viewStephen Bird2015-06-111-0/+1
| | | | | | | | | | | | Sometimes files get deleted while FM is in the background. Let's update the list of current items every time we resume just in case. Change-Id: Ib3076ec97d9a0af23f57bb83bff6e0de9c728285 (cherry picked from commit 039ec12aef45822b744d4297f8808ec74c0c2daf) (cherry picked from commit 1a897187749c43699cdeec5d6022b8381d277947) (cherry picked from commit 9231cf245bc0b3bd80ee5e3708f099dad3f76530)
* Sizes: Let disk usage show sizes as doublesStephen Bird2015-06-111-5/+9
| | | | | | | | | This way, weird file system sizes display nicely. Without this a mountpoint with a size of 1.68GB displays as 1GB. Change-Id: I72e0d8ff911dd942efd5860f2d86607ebbb30fcb (cherry picked from commit 98e6afe9fc09f9003d56e8b3afe91f10451811b9)
* MediaScanning: Update with calls to MediascannerStephen Bird2015-06-111-24/+21
| | | | | | | | | With older versions of android, updating with .delete was the proper way to remove these items The issue is that, doing this does not update MTP. Change-Id: I9b7098927fbda6e78a9baedb5e5e35968c082108 (cherry picked from commit c72bf8446312bb89a2cf61b4b960a2d2fd2bfb43)
* Delete destination file when copy failsd34d2015-06-111-0/+7
| | | | | Change-Id: Ic398a2eaa7ac06d8c2ffccc10033d2d32a0dba60 (cherry picked from commit 766c7ba627fb8d685408429ce027c6826bb9c2ab)
* [CMFileManager] Fix the filemanager can copy parent folder to child folderkai.cao2015-06-091-16/+19
| | | | | | | | | | | | Procedures 1.Go into filemanager and select a directory(such as Music). 2.enter the Music and copy the folder. The filemanager stay in "copying" interface. Change-Id: I9a765d1d89c4736b26d57bdf99237f04a810f254 (cherry picked from commit 226460f8724fdc3f74e59e92862dd88087385b70) (cherry picked from commit 7b411344db4857250b98f6f16a71f583aec9e979)
* Fix there are no folders in NavigationView Pinned file managerkai.cao2015-05-251-1/+5
| | | | | | | | | | | | | | | | | | Procedures 1.Go to Settings -> Security ->Screen pinning and Open the screen pinning. 2.Go to FileManager and Callout the Recents Task. 3.Press the screen pinning button and lock the CMFileManager screen. 4.Press back key sometimes when the scren pinning toast show. 5.Open DrawerLayout and Press the Internal storage 6.Press the All to enter NavigationView. There are no folders in NavigationView. Change-Id: I7bbdad87812a66c346c4632886b42c3c79540373 (cherry picked from commit b1bac2dda52f508a182746817df6228421839151) (cherry picked from commit 2fa646a48b3229b31e2e1ea1637e9582534005fb) (cherry picked from commit d9525ed362a2db57d7cda1efa3a3233906200d44)
* [CMFileManager]Fix CMFileManager sometimes crash.kai.cao2015-05-251-1/+5
| | | | | | | | sometimes,the CMFileManager crash. Change-Id: Id82ec92c680248539bb070c30b6bf45c2feab6ab (cherry picked from commit 9a75e1b333af5567c1c78dd4c7ee5b9d2101594b) (cherry picked from commit 830dad9f27c03ad54b7651e01e45aef032740f5a)
* Update Editor Activity to handle Content URIStephen Bird2015-05-191-0/+1
| | | | | | | | | This fixes a instance where the editor is an option for a file uri, but then is no longer an option once the uri is moved into an applications data storage. Change-Id: Ie7a55137bdce2fa78ba7ae71b48ef2ba8e68d5ff (cherry picked from commit 835447a2ac938f1a8a68e2539f63cd004acb5a6a)
* Prevent possible OutOfBoundsExceptionMartin Brabham2015-05-191-0/+6
| | | | | | | Change-Id: I8fc90a2ade069764732c35b71c5ae450d5d3cc5a (cherry picked from commit 08a24ffb2d942db4a051cfba9c25615abbd0fe2b) (cherry picked from commit b1faeb6510f65372a3d7e9f302becc4741acef6f) (cherry picked from commit a82eeb92b69a9bcbf3a0ec3670910dd196ccf920)
* Prevent possible OOBE when ran under monkey testMartin Brabham2015-05-191-0/+4
| | | | | Change-Id: I8ec74d9379ba68ad099d89ec7cd16f65e414a213 (cherry picked from commit da3e50d1e792f9a07419de5d096646f1e20c4401)
* Fix back arrow discoloration in action barStephen Bird2015-05-152-2/+6
| | | | | Change-Id: Ic428a0e4fb7802f1983e7c575adb904c1f6fd65d (cherry picked from commit 2ed65f043543b39ff45f33df83c878c1c9f62160)
* CM Easy Mode File Manager Navigation fixesStephen Bird2015-05-152-4/+40
| | | | | | | | | | | | | | | This patch fixes an issue where the user cannot get back to easy mode without exiting and re-entering the application in certain situations Repro Steps: 1) Select "All" in the easy mode list 2) Action Bar arrow is gone, pressing back on the navbar does not return you to easy mode Change-Id: I5f6b47b8b69e57cffac77f7bfa24f8a75d8ff1d4 (cherry picked from commit c5c685221337c3c0b1f13ef20423de56fdba8870) (cherry picked from commit 7cf35abef8a342effac7dff4b2b401a9d4514e89)
* [CMFileManager] Fix the DrawerLayout don't disapper after press back key.kai.cao2015-04-221-0/+4
| | | | | | | | | | | | Procedures 1.Go into filemanager and enter a directory(such as Music). 2.Open the menu Button in the top left corner and popup the drawerlayout. 3.press the back key. The DrawerLayout don't disapper and the navigation view back to the next higher level. Change-Id: I13c78491e2be767e7611d57c2c513013d96465eb (cherry picked from commit 34f4d1c880bd78482f6fa9dfc701692b8504ffd6)
* Enable ok button, filename is still valid.Martin Brabham2015-04-171-1/+1
| | | | | Change-Id: I38f3be02e60597a169850c2a47127dac5784236c (cherry picked from commit 16b30c40f8164c760d0e40c00e19bcc4dac67ccf)
* Make the new filename max length error message show.Martin Brabham2015-04-172-2/+2
| | | | Change-Id: Ic997110fb78d253c7d3602a5b81157fceb9f73b2
* Automatic translation importMichael Bestas2015-04-1762-239/+2567
| | | | Change-Id: I319e2b93d627e22280259c2691679445944ff4d6
* Support RTL layouts everywhere.Martin Brabham2015-04-1737-345/+324
| | | | | | | | | | | - Fix custom title text clipping. - Fix breadcrumbs - Remove FSO Dialog permission spinner width adjustment that did not function on RTL. - Fix history and bookmarks items to align properly. - Update layouts to function with RTL Change-Id: I3cd4032887371509ec2847bae6f889558664a356
* Implement a dialog that warns the user that we must expose the content of ↵Martin Brabham2015-04-1714-7/+537
| | | | | | | | | | the file by copying it out to an unsecure location in order to allow the external applications to read the files. Change-Id: I163ccd21678f413170e44cf3e8d341cd4747b1ac (cherry picked from commit 58928e7facbdd63d4320748b277e94417fe402bb)
* [CMFileManager] Always display searching progress after back to the search ↵jing.zhao2015-04-151-0/+2
| | | | | | | | | | | | | result view 1.Go into the root directory, click the search icon and input the directory name(Such as: dlt). 2.In Search results view, you can see the dlt directory, then click the directory. 3.press back key, back to the Search results view, the lower right corner's searching progress has always show. After Seaching, the searching progress shouldn't show. Change-Id: Id1a3291effcebcd7c9536dec74175d6d019e83f1 (cherry picked from commit 37e947a354edad76d4e91258b535c4658b54e2e9)
* CMFileManager: change dialog buttons to use dialog_text_color themeRaj Yengisetty2015-04-101-2/+1
| | | | | | | | Also remove themed button background for dialog buttons, causes the dialog buttons to appear too close to each other. Change-Id: I7059ad3da2b958aeca63d451fbd4cb1a26e792a4 (cherry picked from commit 1ac66923d6169e31eaccc148563f7116de894567)
* Fix deadlock when reading shell output.Matt Garnes2015-04-101-18/+5
| | | | | Change-Id: Ia38ac6c415506f21ffde5a4c3e658e810dea92da (cherry picked from commit 2f7e43ce8f37b61c2998aadc56c6323faae80c51)
* Update ShellConsole to pass original bytes of output.Roman Birg2015-04-1012-79/+104
| | | | | | | | - Use byte buffers to back ShellConsole instead of StringBuffers. - Allows the encoding of the output of commands to be preserved. Change-Id: I85fa567ef589a82f1c8604f1f215647376c31c9a (cherry picked from commit 55c55835d3bd685dde542b4f5952ce401542ab84)
* Do not show Toasts when file copy cancelled.Martin Brabham2015-04-093-5/+14
| | | | | | | - Bubble up CancelledOperationException when the Cancel/Move operation is cancelled. Handle cancellation differently than success. Change-Id: I0d7e01c66e2d0d2085b16e4f67cfc56894316a12
* Implement ability to cancel file copy.Martin Brabham2015-04-0911-22/+119
| | | | Change-Id: I3e4426aaccf42e12bf299041d489e72b3b76a626
* Detect text encoding with juniversalchardet.Matt Garnes2015-04-094-3/+505
| | | | | | | | | - When opening files in the built in editor for display, detect the encoding with juniversalchardet, so that the correct encoding will be used. - Only supported in the JavaConsole (non-privileged). Change-Id: If35229c4aee97526eab10be59a40d1dac3e43036
* Add character limit for name input dialog.Martin Brabham2015-04-033-3/+22
| | | | | Change-Id: I75539bbe90dbc278b360e1246c5218101d77abf7 (cherry picked from commit d34dfc6892760eb14a553bd9774a65aa211f6d7b)
* Fix support for USB OTG.Matt Garnes2015-04-024-16/+25
| | | | | | | | | Properly listen for the Broadcast with an IntentFilter that includes the path data scheme. Reload the mounted volumes upon ACTION_MEDIA_MOUNTED AND ACTION_MEDIA_UNMOUNTED. Change-Id: I71d90978fef05419d912ef2398bf99c23fdefee6 (cherry picked from commit e3922e43c8988c499c85115f1f14bef8c925e1ee)
* Catch RuntimeException when opening 3gp files for inspection.Matt Garnes2015-04-011-8/+18
| | | | | | | | | | | | When reading metadata from .3gp files, FileManager can crash if the file is unreadable. MediaMetaDataRetriever.setDataSource() throws RuntimeException if this happens. Catch it. Fixes NIGHTLIES-958. Change-Id: I465f7c961793b468e0469a5844894f3ed56b374c (cherry picked from commit 4bd0d070f76d5180e6de1d20843bb9c16a782f4c) (cherry picked from commit 839ffc3675664de26bd34337b41ef232f3076cc6)
* CMFileManager: change warning drawables used in dialogs for visibilityRaj Yengisetty2015-03-315-5/+9
| | | | Change-Id: I5256322a460f8fab268a6f36022aece2bdabd677