diff options
author | Flamefire <alex@grundis.de> | 2014-01-20 22:18:05 +0100 |
---|---|---|
committer | Flamefire <alex@grundis.de> | 2014-01-20 22:18:05 +0100 |
commit | 8dce36332dab83bb99760391b756099a0249f424 (patch) | |
tree | 25a75111974359842a97675b8ed72e912b64fe32 | |
parent | 51af4fccfdbb73eec677962ec138d7b435bcbc50 (diff) | |
download | android_hardware_samsung-8dce36332dab83bb99760391b756099a0249f424.tar.gz android_hardware_samsung-8dce36332dab83bb99760391b756099a0249f424.tar.bz2 android_hardware_samsung-8dce36332dab83bb99760391b756099a0249f424.zip |
Fix crash on bootcm-10.2.1stable/cm-10.2cm-10.2
There is a race condition where the sysfs-vsync thread accesses a value
(in particular a function ptr) that may not have been set yet as this
is done externally.
Change-Id: If1afb1533344e994398b9b6f5bd3dfb125313416
-rw-r--r-- | exynos4/hal/libhwcomposer/SecHWC.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/exynos4/hal/libhwcomposer/SecHWC.cpp b/exynos4/hal/libhwcomposer/SecHWC.cpp index 1831125..0951ba3 100644 --- a/exynos4/hal/libhwcomposer/SecHWC.cpp +++ b/exynos4/hal/libhwcomposer/SecHWC.cpp @@ -965,7 +965,8 @@ static void *hwc_vsync_sysfs_loop(void *data) do { ssize_t len = read(vsync_timestamp_fd, buf, sizeof(buf)); timestamp = strtoull(buf, NULL, 0); - ctx->procs->vsync(ctx->procs, 0, timestamp); + if(ctx->procs && ctx->procs->vsync) + ctx->procs->vsync(ctx->procs, 0, timestamp); select(vsync_timestamp_fd + 1, NULL, NULL, &exceptfds, NULL); lseek(vsync_timestamp_fd, 0, SEEK_SET); } while (1); |