diff options
-rw-r--r-- | CleanSpec.mk | 2 | ||||
-rw-r--r-- | include/libril/ril_ex.h | 2 | ||||
-rw-r--r-- | include/telephony/ril.h | 243 | ||||
-rw-r--r-- | libril/Android.mk | 3 | ||||
-rw-r--r-- | libril/RilSapSocket.h | 16 | ||||
-rw-r--r-- | libril/ril.cpp | 32 | ||||
-rw-r--r-- | libril/ril_commands.h | 3 | ||||
-rw-r--r-- | libril/ril_service.cpp | 282 | ||||
-rw-r--r-- | libril/ril_service.h | 22 | ||||
-rw-r--r-- | libril/ril_unsol_commands.h | 2 | ||||
-rw-r--r-- | libril/sap_service.cpp | 1 | ||||
-rw-r--r-- | librilutils/Android.mk | 7 | ||||
-rw-r--r-- | reference-ril/Android.mk | 5 | ||||
-rw-r--r-- | reference-ril/reference-ril.c | 32 | ||||
-rw-r--r-- | rild/Android.mk | 1 |
15 files changed, 560 insertions, 93 deletions
diff --git a/CleanSpec.mk b/CleanSpec.mk index ffa18d5..cca8c69 100644 --- a/CleanSpec.mk +++ b/CleanSpec.mk @@ -52,3 +52,5 @@ $(call add-clean-step, rm -rf $(PRODUCT_OUT)/system/bin/rild) $(call add-clean-step, rm -rf $(PRODUCT_OUT)/system/etc/init/rild.rc) $(call add-clean-step, rm -rf $(PRODUCT_OUT)/system/lib/libril.so) $(call add-clean-step, rm -rf $(PRODUCT_OUT)/system/lib64/libril.so) +$(call add-clean-step, rm -rf $(PRODUCT_OUT)/system/lib/librilutils.so) +$(call add-clean-step, rm -rf $(PRODUCT_OUT)/system/lib64/librilutils.so) diff --git a/include/libril/ril_ex.h b/include/libril/ril_ex.h index 251e8ff..757bcf9 100644 --- a/include/libril/ril_ex.h +++ b/include/libril/ril_ex.h @@ -22,6 +22,8 @@ #define NUM_ELEMS_SOCKET(a) (sizeof (a) / sizeof (a)[0]) +struct ril_event; + void rilEventAddWakeup_helper(struct ril_event *ev); int blockingWrite_helper(int fd, void* data, size_t len); diff --git a/include/telephony/ril.h b/include/telephony/ril.h index 5b1e2d6..277878a 100644 --- a/include/telephony/ril.h +++ b/include/telephony/ril.h @@ -77,7 +77,9 @@ extern "C" { * RIL_UNSOL_MODEM_RESTART, * RIL_REQUEST_SEND_DEVICE_STATE, * RIL_REQUEST_SET_UNSOLICITED_RESPONSE_FILTER, - * RIL_REQUEST_SET_SIM_CARD_POWER + * RIL_REQUEST_SET_SIM_CARD_POWER, + * RIL_REQUEST_SET_CARRIER_INFO_IMSI_ENCRYPTION, + * RIL_UNSOL_CARRIER_INFO_IMSI_ENCRYPTION * The new parameters for RIL_REQUEST_SETUP_DATA_CALL, * Updated data structures: RIL_DataProfileInfo_v15, RIL_InitialAttachApn_v15 * New data structure RIL_DataRegistrationStateResponse, @@ -85,6 +87,9 @@ extern "C" { * used in RIL_REQUEST_DATA_REGISTRATION_STATE and * RIL_REQUEST_VOICE_REGISTRATION_STATE respectively. * New data structure RIL_OpenChannelParams. + * RIL_REQUEST_START_NETWORK_SCAN + * RIL_REQUEST_STOP_NETWORK_SCAN + * RIL_UNSOL_NETWORK_SCAN_RESULT */ #define RIL_VERSION 12 #define LAST_IMPRECISE_RIL_VERSION 12 // Better self-documented name @@ -99,6 +104,9 @@ extern "C" { #define MAX_DEBUG_SOCKET_NAME_LENGTH 12 #define MAX_QEMU_PIPE_NAME_LENGTH 11 #define MAX_UUID_LENGTH 64 +#define MAX_BANDS 8 +#define MAX_CHANNELS 32 +#define MAX_RADIO_ACCESS_NETWORKS 8 typedef void * RIL_Token; @@ -743,6 +751,16 @@ typedef struct { */ } RIL_CarrierRestrictions; +typedef struct { + const uint8_t * carrierKey; /* Public Key from the Carrier used to encrypt the + * IMSI/IMPI. + */ + const char * KeyIdentifier; /* The keyIdentifier Attribute value pair that helps + * a server locate the private key to decrypt the + * permanent identity. + */ +} RIL_CarrierInfoForImsiEncryption; + /* See RIL_REQUEST_LAST_CALL_FAIL_CAUSE */ typedef enum { CALL_FAIL_UNOBTAINABLE_NUMBER = 1, @@ -2027,6 +2045,141 @@ typedef struct { P2Constants:NO_P2 if to be ignored */ } RIL_OpenChannelParams; +typedef enum { + RIL_ONE_SHOT = 0x01, // Performs the scan only once + RIL_PERIODIC = 0x02 // Performs the scan periodically until cancelled +} RIL_ScanType; + +typedef enum { + GERAN = 0x01, // GSM EDGE Radio Access Network + UTRAN = 0x02, // Universal Terrestrial Radio Access Network + EUTRAN = 0x03, // Evolved Universal Terrestrial Radio Access Network +} RIL_RadioAccessNetworks; + +typedef enum { + GERAN_BAND_T380 = 1, + GERAN_BAND_T410 = 2, + GERAN_BAND_450 = 3, + GERAN_BAND_480 = 4, + GERAN_BAND_710 = 5, + GERAN_BAND_750 = 6, + GERAN_BAND_T810 = 7, + GERAN_BAND_850 = 8, + GERAN_BAND_P900 = 9, + GERAN_BAND_E900 = 10, + GERAN_BAND_R900 = 11, + GERAN_BAND_DCS1800 = 12, + GERAN_BAND_PCS1900 = 13, + GERAN_BAND_ER900 = 14, +} RIL_GeranBands; + +typedef enum { + UTRAN_BAND_1 = 1, + UTRAN_BAND_2 = 2, + UTRAN_BAND_3 = 3, + UTRAN_BAND_4 = 4, + UTRAN_BAND_5 = 5, + UTRAN_BAND_6 = 6, + UTRAN_BAND_7 = 7, + UTRAN_BAND_8 = 8, + UTRAN_BAND_9 = 9, + UTRAN_BAND_10 = 10, + UTRAN_BAND_11 = 11, + UTRAN_BAND_12 = 12, + UTRAN_BAND_13 = 13, + UTRAN_BAND_14 = 14, + UTRAN_BAND_19 = 19, + UTRAN_BAND_20 = 20, + UTRAN_BAND_21 = 21, + UTRAN_BAND_22 = 22, + UTRAN_BAND_25 = 25, + UTRAN_BAND_26 = 26, +} RIL_UtranBands; + +typedef enum { + EUTRAN_BAND_1 = 1, + EUTRAN_BAND_2 = 2, + EUTRAN_BAND_3 = 3, + EUTRAN_BAND_4 = 4, + EUTRAN_BAND_5 = 5, + EUTRAN_BAND_6 = 6, + EUTRAN_BAND_7 = 7, + EUTRAN_BAND_8 = 8, + EUTRAN_BAND_9 = 9, + EUTRAN_BAND_10 = 10, + EUTRAN_BAND_11 = 11, + EUTRAN_BAND_12 = 12, + EUTRAN_BAND_13 = 13, + EUTRAN_BAND_14 = 14, + EUTRAN_BAND_17 = 17, + EUTRAN_BAND_18 = 18, + EUTRAN_BAND_19 = 19, + EUTRAN_BAND_20 = 20, + EUTRAN_BAND_21 = 21, + EUTRAN_BAND_22 = 22, + EUTRAN_BAND_23 = 23, + EUTRAN_BAND_24 = 24, + EUTRAN_BAND_25 = 25, + EUTRAN_BAND_26 = 26, + EUTRAN_BAND_27 = 27, + EUTRAN_BAND_28 = 28, + EUTRAN_BAND_30 = 30, + EUTRAN_BAND_31 = 31, + EUTRAN_BAND_33 = 33, + EUTRAN_BAND_34 = 34, + EUTRAN_BAND_35 = 35, + EUTRAN_BAND_36 = 36, + EUTRAN_BAND_37 = 37, + EUTRAN_BAND_38 = 38, + EUTRAN_BAND_39 = 39, + EUTRAN_BAND_40 = 40, + EUTRAN_BAND_41 = 41, + EUTRAN_BAND_42 = 42, + EUTRAN_BAND_43 = 43, + EUTRAN_BAND_44 = 44, + EUTRAN_BAND_45 = 45, + EUTRAN_BAND_46 = 46, + EUTRAN_BAND_47 = 47, + EUTRAN_BAND_48 = 48, + EUTRAN_BAND_65 = 65, + EUTRAN_BAND_66 = 66, + EUTRAN_BAND_68 = 68, + EUTRAN_BAND_70 = 70, +} RIL_EutranBands; + +typedef struct { + RIL_RadioAccessNetworks radio_access_network; // The type of network to scan. + uint32_t bands_length; // Length of bands + union { + RIL_GeranBands geran_bands[MAX_BANDS]; + RIL_UtranBands utran_bands[MAX_BANDS]; + RIL_EutranBands eutran_bands[MAX_BANDS]; + } bands; + uint32_t channels_length; // Length of channels + uint32_t channels[MAX_CHANNELS]; // Frequency channels to scan +} RIL_RadioAccessSpecifier; + +typedef struct { + RIL_ScanType type; // Type of the scan + int32_t interval; // Time interval in seconds + // between periodic scans, only + // valid when type=RIL_PERIODIC + uint32_t specifiers_length; // Length of specifiers + RIL_RadioAccessSpecifier specifiers[MAX_RADIO_ACCESS_NETWORKS]; // Radio access networks + // with bands/channels. +} RIL_NetworkScanRequest; + +typedef enum { + PARTIAL = 0x01, // The result contains a part of the scan results + COMPLETE = 0x02, // The result contains the last part of the scan results +} RIL_ScanStatus; + +typedef struct { + RIL_ScanStatus status; // The status of the scan + uint32_t network_infos_length; // Total length of RIL_CellInfo + RIL_CellInfo_v12* network_infos; // List of network information +} RIL_NetworkScanResult; + /** * RIL_REQUEST_GET_SIM_STATUS * @@ -5547,6 +5700,72 @@ typedef struct { * INVALID_ARGUMENTS */ #define RIL_REQUEST_SET_SIM_CARD_POWER 140 + +/** + * RIL_REQUEST_SET_CARRIER_INFO_IMSI_ENCRYPTION + * + * Provide Carrier specific information to the modem that will be used to + * encrypt the IMSI and IMPI. Sent by the framework during boot, carrier + * switch and everytime we receive a new certificate. + * + * "data" is the RIL_CarrierInfoForImsiEncryption * structure. + * + * "response" is NULL + * + * Valid errors: + * RIL_E_SUCCESS + * RIL_E_RADIO_NOT_AVAILABLE + * SIM_ABSENT + * RIL_E_REQUEST_NOT_SUPPORTED + * INVALID_ARGUMENTS + * MODEM_INTERNAL_FAILURE + */ +#define RIL_REQUEST_SET_CARRIER_INFO_IMSI_ENCRYPTION 141 + +/** + * RIL_REQUEST_START_NETWORK_SCAN + * + * Starts a new network scan + * + * Request to start a network scan with specified radio access networks with frequency bands and/or + * channels. + * + * "data" is a const RIL_NetworkScanRequest *. + * "response" is NULL + * + * Valid errors: + * SUCCESS + * RADIO_NOT_AVAILABLE + * OPERATION_NOT_ALLOWED + * DEVICE_IN_USE + * INTERNAL_ERR + * NO_MEMORY + * MODEM_ERR + * INVALID_ARGUMENTS + * REQUEST_NOT_SUPPORTED + * + */ +#define RIL_REQUEST_START_NETWORK_SCAN 142 + +/** + * RIL_REQUEST_STOP_NETWORK_SCAN + * + * Stops an ongoing network scan + * + * Request to stop the ongoing network scan. Since the modem can only perform one scan at a time, + * there is no parameter for this request. + * + * "data" is NULL + * "response" is NULL + * + * Valid errors: + * SUCCESS + * INTERNAL_ERR + * MODEM_ERR + * + */ +#define RIL_REQUEST_STOP_NETWORK_SCAN 143 + /***********************************************************************/ /** @@ -6201,6 +6420,28 @@ typedef struct { */ #define RIL_UNSOL_MODEM_RESTART 1047 +/** + * RIL_UNSOL_CARRIER_INFO_IMSI_ENCRYPTION + * + * Called when the modem needs Carrier specific information that will + * be used to encrypt IMSI and IMPI. + * + * "data" is NULL + * + */ +#define RIL_UNSOL_CARRIER_INFO_IMSI_ENCRYPTION 1048 + +/** + * RIL_UNSOL_NETWORK_SCAN_RESULT + * + * Returns incremental result for the network scan which is started by + * RIL_REQUEST_START_NETWORK_SCAN, sent to report results, status, or errors. + * + * "data" is NULL + * "response" is a const RIL_NetworkScanResult * + */ +#define RIL_UNSOL_NETWORK_SCAN_RESULT 1049 + /***********************************************************************/ diff --git a/libril/Android.mk b/libril/Android.mk index 3ba5bba..5264a81 100644 --- a/libril/Android.mk +++ b/libril/Android.mk @@ -19,6 +19,7 @@ LOCAL_SHARED_LIBRARIES := \ libhardware_legacy \ librilutils \ android.hardware.radio@1.0 \ + android.hardware.radio@1.1 \ android.hardware.radio.deprecated@1.0 \ libhidlbase \ libhidltransport \ @@ -27,7 +28,7 @@ LOCAL_SHARED_LIBRARIES := \ LOCAL_STATIC_LIBRARIES := \ libprotobuf-c-nano-enable_malloc \ -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += -Wall -Wextra -Wno-unused-parameter -Werror ifeq ($(SIM_COUNT), 2) LOCAL_CFLAGS += -DANDROID_MULTI_SIM -DDSDA_RILD1 diff --git a/libril/RilSapSocket.h b/libril/RilSapSocket.h index 1f6163e..8c8c4bc 100644 --- a/libril/RilSapSocket.h +++ b/libril/RilSapSocket.h @@ -36,22 +36,6 @@ */ class RilSapSocket : public RilSocket { /** - * Function pointer to the ril initialization funtion. - * - * @param Ril environment variable with place request and - * response handlers and timeout handler. - * - * @param Number of arguements for the initialization function. - * - * @param Arguements to the initialization function used to - * generate instance id of the ril daemon. - * - * @return Radio functions with handlers for onRequest, onStateRequest, - * supports, onCancel and getVersion. - */ - RIL_RadioFunctions *(*UimInit)(const struct RIL_Env *, int argc, char **argv); - - /** * Place holder for the radio functions returned by the initialization * function. Currenty only onRequest handler is being used. */ diff --git a/libril/ril.cpp b/libril/ril.cpp index 6366920..6d375ca 100644 --- a/libril/ril.cpp +++ b/libril/ril.cpp @@ -114,12 +114,8 @@ RIL_RadioFunctions s_callbacks = {0, NULL, NULL, NULL, NULL, NULL}; static int s_registerCalled = 0; static pthread_t s_tid_dispatch; -static pthread_t s_tid_reader; static int s_started = 0; -static int s_fdDebug = -1; -static int s_fdDebug_socket2 = -1; - static int s_fdWakeupRead; static int s_fdWakeupWrite; @@ -128,44 +124,30 @@ int s_wakelock_count = 0; static struct ril_event s_wakeupfd_event; static pthread_mutex_t s_pendingRequestsMutex = PTHREAD_MUTEX_INITIALIZER; -static pthread_mutex_t s_writeMutex = PTHREAD_MUTEX_INITIALIZER; static pthread_mutex_t s_wakeLockCountMutex = PTHREAD_MUTEX_INITIALIZER; static RequestInfo *s_pendingRequests = NULL; #if (SIM_COUNT >= 2) static pthread_mutex_t s_pendingRequestsMutex_socket2 = PTHREAD_MUTEX_INITIALIZER; -static pthread_mutex_t s_writeMutex_socket2 = PTHREAD_MUTEX_INITIALIZER; static RequestInfo *s_pendingRequests_socket2 = NULL; #endif #if (SIM_COUNT >= 3) static pthread_mutex_t s_pendingRequestsMutex_socket3 = PTHREAD_MUTEX_INITIALIZER; -static pthread_mutex_t s_writeMutex_socket3 = PTHREAD_MUTEX_INITIALIZER; static RequestInfo *s_pendingRequests_socket3 = NULL; #endif #if (SIM_COUNT >= 4) static pthread_mutex_t s_pendingRequestsMutex_socket4 = PTHREAD_MUTEX_INITIALIZER; -static pthread_mutex_t s_writeMutex_socket4 = PTHREAD_MUTEX_INITIALIZER; static RequestInfo *s_pendingRequests_socket4 = NULL; #endif -static struct ril_event s_wake_timeout_event; -static struct ril_event s_debug_event; - - static const struct timeval TIMEVAL_WAKE_TIMEOUT = {ANDROID_WAKE_LOCK_SECS,ANDROID_WAKE_LOCK_USECS}; static pthread_mutex_t s_startupMutex = PTHREAD_MUTEX_INITIALIZER; static pthread_cond_t s_startupCond = PTHREAD_COND_INITIALIZER; -static pthread_mutex_t s_dispatchMutex = PTHREAD_MUTEX_INITIALIZER; -static pthread_cond_t s_dispatchCond = PTHREAD_COND_INITIALIZER; - -static RequestInfo *s_toDispatchHead = NULL; -static RequestInfo *s_toDispatchTail = NULL; - static UserCallbackInfo *s_last_wake_timeout_info = NULL; static void *s_lastNITZTimeData = NULL; @@ -435,9 +417,6 @@ extern "C" void RIL_setcallbacks (const RIL_RadioFunctions *callbacks) { extern "C" void RIL_register (const RIL_RadioFunctions *callbacks) { - int ret; - int flags; - RLOGI("SIM_COUNT: %d", SIM_COUNT); if (callbacks == NULL) { @@ -573,9 +552,7 @@ checkAndDequeueRequestInfoIfAck(struct RequestInfo *pRI, bool isAck) { extern "C" void RIL_onRequestAck(RIL_Token t) { RequestInfo *pRI; - int ret; - size_t errorOffset; RIL_SOCKET_ID socket_id = RIL_SOCKET_1; pRI = (RequestInfo *)t; @@ -609,7 +586,6 @@ extern "C" void RIL_onRequestComplete(RIL_Token t, RIL_Errno e, void *response, size_t responselen) { RequestInfo *pRI; int ret; - size_t errorOffset; RIL_SOCKET_ID socket_id = RIL_SOCKET_1; pRI = (RequestInfo *)t; @@ -827,7 +803,7 @@ void RIL_onUnsolicitedResponse(int unsolResponse, const void *data, } #if VDBG - RLOGI("%s UNSOLICITED: %s length:%d", rilSocketIdToString(soc_id), + RLOGI("%s UNSOLICITED: %s length:%zu", rilSocketIdToString(soc_id), requestToString(unsolResponse), datalen); #endif @@ -955,7 +931,7 @@ failCauseToString(RIL_Errno e) { case RIL_E_SIM_FULL: return "E_SIM_FULL"; case RIL_E_NETWORK_REJECT: return "E_NETWORK_REJECT"; case RIL_E_OPERATION_NOT_ALLOWED: return "E_OPERATION_NOT_ALLOWED"; - case RIL_E_EMPTY_RECORD: "E_EMPTY_RECORD"; + case RIL_E_EMPTY_RECORD: return "E_EMPTY_RECORD"; case RIL_E_INVALID_SMS_FORMAT: return "E_INVALID_SMS_FORMAT"; case RIL_E_ENCODING_ERR: return "E_ENCODING_ERR"; case RIL_E_INVALID_SMSC_ADDRESS: return "E_INVALID_SMSC_ADDRESS"; @@ -1170,6 +1146,7 @@ requestToString(int request) { case RIL_REQUEST_GET_ACTIVITY_INFO: return "GET_ACTIVITY_INFO"; case RIL_REQUEST_SET_CARRIER_RESTRICTIONS: return "SET_CARRIER_RESTRICTIONS"; case RIL_REQUEST_GET_CARRIER_RESTRICTIONS: return "GET_CARRIER_RESTRICTIONS"; + case RIL_REQUEST_SET_CARRIER_INFO_IMSI_ENCRYPTION: return "SET_CARRIER_INFO_IMSI_ENCRYPTION"; case RIL_RESPONSE_ACKNOWLEDGEMENT: return "RESPONSE_ACKNOWLEDGEMENT"; case RIL_UNSOL_RESPONSE_RADIO_STATE_CHANGED: return "UNSOL_RESPONSE_RADIO_STATE_CHANGED"; case RIL_UNSOL_RESPONSE_CALL_STATE_CHANGED: return "UNSOL_RESPONSE_CALL_STATE_CHANGED"; @@ -1215,6 +1192,7 @@ requestToString(int request) { case RIL_UNSOL_DC_RT_INFO_CHANGED: return "UNSOL_DC_RT_INFO_CHANGED"; case RIL_UNSOL_RADIO_CAPABILITY: return "UNSOL_RADIO_CAPABILITY"; case RIL_UNSOL_MODEM_RESTART: return "UNSOL_MODEM_RESTART"; + case RIL_UNSOL_CARRIER_INFO_IMSI_ENCRYPTION: return "UNSOL_CARRIER_INFO_IMSI_ENCRYPTION"; case RIL_UNSOL_ON_SS: return "UNSOL_ON_SS"; case RIL_UNSOL_STK_CC_ALPHA_NOTIFY: return "UNSOL_STK_CC_ALPHA_NOTIFY"; case RIL_UNSOL_LCEDATA_RECV: return "UNSOL_LCEDATA_RECV"; @@ -1246,4 +1224,4 @@ rilSocketIdToString(RIL_SOCKET_ID socket_id) } } -} /* namespace android */
\ No newline at end of file +} /* namespace android */ diff --git a/libril/ril_commands.h b/libril/ril_commands.h index c9ec0cc..de73936 100644 --- a/libril/ril_commands.h +++ b/libril/ril_commands.h @@ -155,3 +155,6 @@ {RIL_REQUEST_SEND_DEVICE_STATE, radio::sendDeviceStateResponse}, {RIL_REQUEST_SET_UNSOLICITED_RESPONSE_FILTER, radio::setIndicationFilterResponse}, {RIL_REQUEST_SET_SIM_CARD_POWER, radio::setSimCardPowerResponse}, + {RIL_REQUEST_SET_CARRIER_INFO_IMSI_ENCRYPTION, radio::setCarrierInfoForImsiEncryptionResponse}, + {RIL_REQUEST_START_NETWORK_SCAN, radio::startNetworkScanResponse}, + {RIL_REQUEST_STOP_NETWORK_SCAN, radio::stopNetworkScanResponse}, diff --git a/libril/ril_service.cpp b/libril/ril_service.cpp index e2fb254..f67575b 100644 --- a/libril/ril_service.cpp +++ b/libril/ril_service.cpp @@ -16,7 +16,11 @@ #define LOG_TAG "RILC" -#include <android/hardware/radio/1.0/IRadio.h> +#include <android/hardware/radio/1.1/IRadio.h> +#include <android/hardware/radio/1.1/IRadioResponse.h> +#include <android/hardware/radio/1.1/IRadioIndication.h> +#include <android/hardware/radio/1.1/types.h> + #include <android/hardware/radio/deprecated/1.0/IOemHook.h> #include <hwbinder/IPCThreadState.h> @@ -28,9 +32,7 @@ #define INVALID_HEX_CHAR 16 -// Enable verbose logging -#define VDBG 0 - +using namespace android::hardware::radio; using namespace android::hardware::radio::V1_0; using namespace android::hardware::radio::deprecated::V1_0; using ::android::hardware::configureRpcThreadpool; @@ -39,6 +41,7 @@ using ::android::hardware::Return; using ::android::hardware::hidl_string; using ::android::hardware::hidl_vec; using ::android::hardware::hidl_array; +using ::android::hardware::radio::V1_1::NetworkScanRequest; using ::android::hardware::Void; using android::CommandInfo; using android::RequestInfo; @@ -108,10 +111,12 @@ void convertRilDataCallListToHal(void *response, size_t responseLen, void convertRilCellInfoListToHal(void *response, size_t responseLen, hidl_vec<CellInfo>& records); -struct RadioImpl : public IRadio { +struct RadioImpl : public V1_1::IRadio { int32_t mSlotId; sp<IRadioResponse> mRadioResponse; sp<IRadioIndication> mRadioIndication; + sp<V1_1::IRadioResponse> mRadioResponseV1_1; + sp<V1_1::IRadioIndication> mRadioIndicationV1_1; Return<void> setResponseFunctions( const ::android::sp<IRadioResponse>& radioResponse, @@ -242,6 +247,10 @@ struct RadioImpl : public IRadio { Return<void> getAvailableNetworks(int32_t serial); + Return<void> startNetworkScan(int32_t serial, const NetworkScanRequest& request); + + Return<void> stopNetworkScan(int32_t serial); + Return<void> startDtmf(int32_t serial, const ::android::hardware::hidl_string& s); @@ -431,9 +440,15 @@ struct RadioImpl : public IRadio { Return<void> setIndicationFilter(int32_t serial, int32_t indicationFilter); Return<void> setSimCardPower(int32_t serial, bool powerUp); + Return<void> setSimCardPower_1_1(int32_t serial, + const V1_1::CardPowerState state); Return<void> responseAcknowledgement(); + Return<void> setCarrierInfoForImsiEncryption(int32_t serial, + const ::android::hardware::hidl_vec<uint8_t>& carrierKey, + const hidl_string& keyIdentifier); + void checkReturnStatus(Return<void>& ret); }; @@ -460,8 +475,8 @@ void memsetAndFreeStrings(int numPointers, ...) { char *ptr = va_arg(ap, char *); if (ptr) { #ifdef MEMSET_FREED - // TODO: Should pass in the maximum length of the string - memsetString(ptr); +#define MAX_STRING_LENGTH 4096 + memset(ptr, 0, strnlen(ptr, MAX_STRING_LENGTH)); #endif free(ptr); } @@ -732,6 +747,8 @@ void checkReturnStatus(int32_t slotId, Return<void>& ret, bool isRadioService) { if (isRadioService) { radioService[slotId]->mRadioResponse = NULL; radioService[slotId]->mRadioIndication = NULL; + radioService[slotId]->mRadioResponseV1_1 = NULL; + radioService[slotId]->mRadioIndicationV1_1 = NULL; } else { oemHookService[slotId]->mOemHookResponse = NULL; oemHookService[slotId]->mOemHookIndication = NULL; @@ -767,6 +784,13 @@ Return<void> RadioImpl::setResponseFunctions( mRadioResponse = radioResponseParam; mRadioIndication = radioIndicationParam; + mRadioResponseV1_1 = V1_1::IRadioResponse::castFrom(mRadioResponse).withDefault(nullptr); + mRadioIndicationV1_1 = V1_1::IRadioIndication::castFrom(mRadioIndication).withDefault(nullptr); + if (mRadioResponseV1_1 == nullptr || mRadioIndicationV1_1 == nullptr) { + mRadioResponseV1_1 = nullptr; + mRadioIndicationV1_1 = nullptr; + } + mCounterRadio[mSlotId]++; ret = pthread_rwlock_unlock(radioServiceRwlockPtr); @@ -1315,6 +1339,78 @@ Return<void> RadioImpl::getAvailableNetworks(int32_t serial) { return Void(); } +Return<void> RadioImpl::startNetworkScan(int32_t serial, const NetworkScanRequest& request) { +#if VDBG + RLOGD("startNetworkScan: serial %d", serial); +#endif + + RequestInfo *pRI = android::addRequestToList(serial, mSlotId, RIL_REQUEST_START_NETWORK_SCAN); + if (pRI == NULL) { + return Void(); + } + + if (request.specifiers.size() > MAX_RADIO_ACCESS_NETWORKS) { + sendErrorResponse(pRI, RIL_E_INVALID_ARGUMENTS); + return Void(); + } + + RIL_NetworkScanRequest scan_request = {}; + + scan_request.type = (RIL_ScanType) request.type; + scan_request.interval = request.interval; + scan_request.specifiers_length = request.specifiers.size(); + for (size_t i = 0; i < request.specifiers.size(); ++i) { + if (request.specifiers[i].geranBands.size() > MAX_BANDS || + request.specifiers[i].utranBands.size() > MAX_BANDS || + request.specifiers[i].eutranBands.size() > MAX_BANDS || + request.specifiers[i].channels.size() > MAX_CHANNELS) { + sendErrorResponse(pRI, RIL_E_INVALID_ARGUMENTS); + return Void(); + } + const V1_1::RadioAccessSpecifier& ras_from = + request.specifiers[i]; + RIL_RadioAccessSpecifier& ras_to = scan_request.specifiers[i]; + + ras_to.radio_access_network = (RIL_RadioAccessNetworks) ras_from.radioAccessNetwork; + ras_to.channels_length = ras_from.channels.size(); + + std::copy(ras_from.channels.begin(), ras_from.channels.end(), ras_to.channels); + const std::vector<uint32_t> * bands = nullptr; + switch (request.specifiers[i].radioAccessNetwork) { + case V1_1::RadioAccessNetworks::GERAN: + ras_to.bands_length = ras_from.geranBands.size(); + bands = (std::vector<uint32_t> *) &ras_from.geranBands; + break; + case V1_1::RadioAccessNetworks::UTRAN: + ras_to.bands_length = ras_from.utranBands.size(); + bands = (std::vector<uint32_t> *) &ras_from.utranBands; + break; + case V1_1::RadioAccessNetworks::EUTRAN: + ras_to.bands_length = ras_from.eutranBands.size(); + bands = (std::vector<uint32_t> *) &ras_from.eutranBands; + break; + default: + sendErrorResponse(pRI, RIL_E_INVALID_ARGUMENTS); + return Void(); + } + // safe to copy to geran_bands because it's a union member + std::memcpy(&ras_to.bands.geran_bands, bands, ras_to.bands_length * sizeof(uint32_t)); + } + + CALL_ONREQUEST(RIL_REQUEST_START_NETWORK_SCAN, &scan_request, sizeof(scan_request), pRI, + mSlotId); + + return Void(); +} + +Return<void> RadioImpl::stopNetworkScan(int32_t serial) { +#if VDBG + RLOGD("stopNetworkScan: serial %d", serial); +#endif + dispatchVoid(serial, mSlotId, RIL_REQUEST_STOP_NETWORK_SCAN); + return Void(); +} + Return<void> RadioImpl::startDtmf(int32_t serial, const hidl_string& s) { #if VDBG RLOGD("startDtmf: serial %d", serial); @@ -1401,7 +1497,6 @@ Return<void> RadioImpl::writeSmsToSim(int32_t serial, const SmsWriteArgs& smsWri RIL_SMS_WriteArgs args; args.status = (int) smsWriteArgs.status; - int len; if (!copyHidlStringToRil(&args.pdu, smsWriteArgs.pdu, pRI)) { return Void(); } @@ -2033,7 +2128,7 @@ bool dispatchImsGsmSms(const ImsSmsMessage& message, RequestInfo *pRI) { if (!copyHidlStringToRil(&pStrings[0], message.gsmMessage[0].smscPdu, pRI)) { #ifdef MEMSET_FREED - memset(pStrings, 0, datalen); + memset(pStrings, 0, dataLen); #endif free(pStrings); return false; @@ -2042,7 +2137,7 @@ bool dispatchImsGsmSms(const ImsSmsMessage& message, RequestInfo *pRI) { if (!copyHidlStringToRil(&pStrings[1], message.gsmMessage[0].pdu, pRI)) { memsetAndFreeStrings(1, pStrings[0]); #ifdef MEMSET_FREED - memset(pStrings, 0, datalen); + memset(pStrings, 0, dataLen); #endif free(pStrings); return false; @@ -2057,7 +2152,7 @@ bool dispatchImsGsmSms(const ImsSmsMessage& message, RequestInfo *pRI) { } #ifdef MEMSET_FREED - memset(pStrings, 0, datalen); + memset(pStrings, 0, dataLen); #endif free(pStrings); @@ -2285,7 +2380,6 @@ Return<void> RadioImpl::requestIccSimAuthentication(int32_t serial, int32_t auth pf.authContext = authContext; - int len; if (!copyHidlStringToRil(&pf.authData, authData, pRI)) { return Void(); } @@ -2684,6 +2778,14 @@ Return<void> RadioImpl::setSimCardPower(int32_t serial, bool powerUp) { return Void(); } +Return<void> RadioImpl::setSimCardPower_1_1(int32_t serial, const V1_1::CardPowerState state) { +#if VDBG + RLOGD("setSimCardPower_1_1: serial %d state %d", serial, state); +#endif + dispatchInts(serial, mSlotId, RIL_REQUEST_SET_SIM_CARD_POWER, 1, state); + return Void(); +} + Return<void> RadioImpl::responseAcknowledgement() { android::releaseWakeLock(); return Void(); @@ -2727,6 +2829,14 @@ Return<void> OemHookImpl::sendRequestStrings(int32_t serial, return Void(); } +Return<void> RadioImpl::setCarrierInfoForImsiEncryption(int32_t serial, + const ::android::hardware::hidl_vec<uint8_t>& carrierKey, + const hidl_string& keyIdentifier) { + RLOGD("setCarrierInfoForImsiEncryption: serial %d", serial); + dispatchRaw(serial, mSlotId, RIL_REQUEST_SET_CARRIER_INFO_IMSI_ENCRYPTION, carrierKey); + return Void(); +} + /*************************************************************************************************** * RESPONSE FUNCTIONS * Functions above are used for requests going from framework to vendor code. The ones below are @@ -4243,7 +4353,6 @@ int radio::getNetworkSelectionModeResponse(int slotId, RadioResponseInfo responseInfo = {}; populateResponseInfo(responseInfo, serial, responseType, e); bool manual = false; - int serviceClass; if (response == NULL || responseLen != sizeof(int)) { RLOGE("getNetworkSelectionModeResponse Invalid response: NULL"); if (e == RIL_E_SUCCESS) responseInfo.error = RadioError::INVALID_RESPONSE; @@ -4478,7 +4587,6 @@ int radio::getMuteResponse(int slotId, RadioResponseInfo responseInfo = {}; populateResponseInfo(responseInfo, serial, responseType, e); bool enable = false; - int serviceClass; if (response == NULL || responseLen != sizeof(int)) { RLOGE("getMuteResponse Invalid response: NULL"); if (e == RIL_E_SUCCESS) responseInfo.error = RadioError::INVALID_RESPONSE; @@ -6343,6 +6451,23 @@ int radio::sendDeviceStateResponse(int slotId, return 0; } +int radio::setCarrierInfoForImsiEncryptionResponse(int slotId, + int responseType, int serial, RIL_Errno e, + void *response, size_t responseLen) { + RLOGD("setCarrierInfoForImsiEncryptionResponse: serial %d", serial); + if (radioService[slotId]->mRadioResponseV1_1 != NULL) { + RadioResponseInfo responseInfo = {}; + populateResponseInfo(responseInfo, serial, responseType, e); + Return<void> retStatus = radioService[slotId]->mRadioResponseV1_1-> + setCarrierInfoForImsiEncryptionResponse(responseInfo); + radioService[slotId]->checkReturnStatus(retStatus); + } else { + RLOGE("setCarrierInfoForImsiEncryptionResponse: radioService[%d]->mRadioResponseV1_1 == " + "NULL", slotId); + } + return 0; +} + int radio::setIndicationFilterResponse(int slotId, int responseType, int serial, RIL_Errno e, void *response, size_t responselen) { @@ -6364,7 +6489,6 @@ int radio::setIndicationFilterResponse(int slotId, return 0; } - int radio::setSimCardPowerResponse(int slotId, int responseType, int serial, RIL_Errno e, void *response, size_t responseLen) { @@ -6372,14 +6496,61 @@ int radio::setSimCardPowerResponse(int slotId, RLOGD("setSimCardPowerResponse: serial %d", serial); #endif - if (radioService[slotId]->mRadioResponse != NULL) { + if (radioService[slotId]->mRadioResponse != NULL + || radioService[slotId]->mRadioResponseV1_1 != NULL) { + RadioResponseInfo responseInfo = {}; + populateResponseInfo(responseInfo, serial, responseType, e); + if (radioService[slotId]->mRadioResponseV1_1 != NULL) { + Return<void> retStatus = radioService[slotId]->mRadioResponseV1_1-> + setSimCardPowerResponse_1_1(responseInfo); + radioService[slotId]->checkReturnStatus(retStatus); + } else { + RLOGD("setSimCardPowerResponse: radioService[%d]->mRadioResponseV1_1 == NULL", + slotId); + Return<void> retStatus + = radioService[slotId]->mRadioResponse->setSimCardPowerResponse(responseInfo); + radioService[slotId]->checkReturnStatus(retStatus); + } + } else { + RLOGE("setSimCardPowerResponse: radioService[%d]->mRadioResponse == NULL && " + "radioService[%d]->mRadioResponseV1_1 == NULL", slotId, slotId); + } + return 0; +} + +int radio::startNetworkScanResponse(int slotId, int responseType, int serial, RIL_Errno e, + void *response, size_t responseLen) { +#if VDBG + RLOGD("startNetworkScanResponse: serial %d", serial); +#endif + + if (radioService[slotId]->mRadioResponseV1_1 != NULL) { RadioResponseInfo responseInfo = {}; populateResponseInfo(responseInfo, serial, responseType, e); Return<void> retStatus - = radioService[slotId]->mRadioResponse->setSimCardPowerResponse(responseInfo); + = radioService[slotId]->mRadioResponseV1_1->startNetworkScanResponse(responseInfo); radioService[slotId]->checkReturnStatus(retStatus); } else { - RLOGE("setSimCardPowerResponse: radioService[%d]->mRadioResponse == NULL", slotId); + RLOGE("startNetworkScanResponse: radioService[%d]->mRadioResponseV1_1 == NULL", slotId); + } + + return 0; +} + +int radio::stopNetworkScanResponse(int slotId, int responseType, int serial, RIL_Errno e, + void *response, size_t responseLen) { +#if VDBG + RLOGD("stopNetworkScanResponse: serial %d", serial); +#endif + + if (radioService[slotId]->mRadioResponseV1_1 != NULL) { + RadioResponseInfo responseInfo = {}; + populateResponseInfo(responseInfo, serial, responseType, e); + Return<void> retStatus + = radioService[slotId]->mRadioResponseV1_1->stopNetworkScanResponse(responseInfo); + radioService[slotId]->checkReturnStatus(retStatus); + } else { + RLOGE("stopNetworkScanResponse: radioService[%d]->mRadioResponseV1_1 == NULL", slotId); } return 0; @@ -6932,7 +7103,7 @@ int radio::simRefreshInd(int slotId, int indicationType, SimRefreshResult refreshResult = {}; RIL_SimRefreshResponse_v7 *simRefreshResponse = ((RIL_SimRefreshResponse_v7 *) response); refreshResult.type = - (android::hardware::radio::V1_0::SimRefreshType) simRefreshResponse->result; + (V1_0::SimRefreshType) simRefreshResponse->result; refreshResult.efId = simRefreshResponse->ef_id; refreshResult.aid = convertCharPtrToHidlString(simRefreshResponse->aid); @@ -7017,18 +7188,18 @@ int radio::cdmaNewSmsInd(int slotId, int indicationType, msg.isServicePresent = rilMsg->bIsServicePresent; msg.serviceCategory = rilMsg->uServicecategory; msg.address.digitMode = - (android::hardware::radio::V1_0::CdmaSmsDigitMode) rilMsg->sAddress.digit_mode; + (V1_0::CdmaSmsDigitMode) rilMsg->sAddress.digit_mode; msg.address.numberMode = - (android::hardware::radio::V1_0::CdmaSmsNumberMode) rilMsg->sAddress.number_mode; + (V1_0::CdmaSmsNumberMode) rilMsg->sAddress.number_mode; msg.address.numberType = - (android::hardware::radio::V1_0::CdmaSmsNumberType) rilMsg->sAddress.number_type; + (V1_0::CdmaSmsNumberType) rilMsg->sAddress.number_type; msg.address.numberPlan = - (android::hardware::radio::V1_0::CdmaSmsNumberPlan) rilMsg->sAddress.number_plan; + (V1_0::CdmaSmsNumberPlan) rilMsg->sAddress.number_plan; int digitLimit = MIN((rilMsg->sAddress.number_of_digits), RIL_CDMA_SMS_ADDRESS_MAX); msg.address.digits.setToExternal(rilMsg->sAddress.digits, digitLimit); - msg.subAddress.subaddressType = (android::hardware::radio::V1_0::CdmaSmsSubaddressType) + msg.subAddress.subaddressType = (V1_0::CdmaSmsSubaddressType) rilMsg->sSubAddress.subaddressType; msg.subAddress.odd = rilMsg->sSubAddress.odd; @@ -7805,10 +7976,10 @@ int radio::hardwareConfigChangedInd(int slotId, void convertRilRadioCapabilityToHal(void *response, size_t responseLen, RadioCapability& rc) { RIL_RadioCapability *rilRadioCapability = (RIL_RadioCapability *) response; rc.session = rilRadioCapability->session; - rc.phase = (android::hardware::radio::V1_0::RadioCapabilityPhase) rilRadioCapability->phase; + rc.phase = (V1_0::RadioCapabilityPhase) rilRadioCapability->phase; rc.raf = rilRadioCapability->rat; rc.logicalModemUuid = convertCharPtrToHidlString(rilRadioCapability->logicalModemUuid); - rc.status = (android::hardware::radio::V1_0::RadioCapabilityStatus) rilRadioCapability->status; + rc.status = (V1_0::RadioCapabilityStatus) rilRadioCapability->status; } int radio::radioCapabilityIndicationInd(int slotId, @@ -8035,6 +8206,62 @@ int radio::modemResetInd(int slotId, return 0; } +int radio::networkScanResultInd(int slotId, + int indicationType, int token, RIL_Errno e, void *response, + size_t responseLen) { +#if VDBG + RLOGD("networkScanResultInd"); +#endif + if (radioService[slotId] != NULL && radioService[slotId]->mRadioIndicationV1_1 != NULL) { + if (response == NULL || responseLen == 0) { + RLOGE("networkScanResultInd: invalid response"); + return 0; + } + RLOGD("networkScanResultInd"); + +#if VDBG + RLOGD("networkScanResultInd"); +#endif + + RIL_NetworkScanResult *networkScanResult = (RIL_NetworkScanResult *) response; + + V1_1::NetworkScanResult result; + result.status = (V1_1::ScanStatus) networkScanResult->status; + result.error = (RadioError) e; + convertRilCellInfoListToHal( + networkScanResult->network_infos, + networkScanResult->network_infos_length * sizeof(RIL_CellInfo_v12), + result.networkInfos); + + Return<void> retStatus = radioService[slotId]->mRadioIndicationV1_1->networkScanResult( + convertIntToRadioIndicationType(indicationType), result); + radioService[slotId]->checkReturnStatus(retStatus); + } else { + RLOGE("networkScanResultInd: radioService[%d]->mRadioIndicationV1_1 == NULL", slotId); + } + return 0; +} + +int radio::carrierInfoForImsiEncryption(int slotId, + int indicationType, int token, RIL_Errno e, void *response, + size_t responseLen) { + if (radioService[slotId] != NULL && radioService[slotId]->mRadioIndicationV1_1 != NULL) { + if (response == NULL || responseLen == 0) { + RLOGE("carrierInfoForImsiEncryption: invalid response"); + return 0; + } + RLOGD("carrierInfoForImsiEncryption"); + Return<void> retStatus = radioService[slotId]->mRadioIndicationV1_1-> + carrierInfoForImsiEncryption(convertIntToRadioIndicationType(indicationType)); + radioService[slotId]->checkReturnStatus(retStatus); + } else { + RLOGE("carrierInfoForImsiEncryption: radioService[%d]->mRadioIndicationV1_1 == NULL", + slotId); + } + + return 0; +} + int radio::oemHookRawInd(int slotId, int indicationType, int token, RIL_Errno e, void *response, size_t responseLen) { @@ -8089,7 +8316,8 @@ void radio::registerService(RIL_RadioFunctions *callbacks, CommandInfo *commands radioService[i]->mSlotId = i; oemHookService[i] = new OemHookImpl; oemHookService[i]->mSlotId = i; - RLOGD("registerService: starting IRadio %s", serviceNames[i]); + RLOGD("registerService: starting android::hardware::radio::V1_1::IRadio %s", + serviceNames[i]); android::status_t status = radioService[i]->registerAsService(serviceNames[i]); status = oemHookService[i]->registerAsService(serviceNames[i]); diff --git a/libril/ril_service.h b/libril/ril_service.h index 441b587..be7cc2d 100644 --- a/libril/ril_service.h +++ b/libril/ril_service.h @@ -199,6 +199,14 @@ int getAvailableNetworksResponse(int slotId, int responseType, int serial, RIL_Errno e, void *response, size_t responselen); +int startNetworkScanResponse(int slotId, + int responseType, int serial, RIL_Errno e, void *response, + size_t responselen); + +int stopNetworkScanResponse(int slotId, + int responseType, int serial, RIL_Errno e, void *response, + size_t responselen); + int startDtmfResponse(int slotId, int responseType, int serial, RIL_Errno e, void *response, size_t responselen); @@ -701,6 +709,10 @@ int modemResetInd(int slotId, int indicationType, int token, RIL_Errno e, void *response, size_t responselen); +int networkScanResultInd(int slotId, + int indicationType, int token, RIL_Errno e, void *response, + size_t responselen); + int sendRequestRawResponse(int slotId, int responseType, int serial, RIL_Errno e, void *response, size_t responseLen); @@ -709,8 +721,16 @@ int sendRequestStringsResponse(int slotId, int responseType, int serial, RIL_Errno e, void *response, size_t responseLen); +int setCarrierInfoForImsiEncryptionResponse(int slotId, + int responseType, int serial, RIL_Errno e, + void *response, size_t responseLen); + +int carrierInfoForImsiEncryption(int slotId, + int responseType, int serial, RIL_Errno e, + void *response, size_t responseLen); + pthread_rwlock_t * getRadioServiceRwlock(int slotId); } // namespace radio -#endif // RIL_SERVICE_H
\ No newline at end of file +#endif // RIL_SERVICE_H diff --git a/libril/ril_unsol_commands.h b/libril/ril_unsol_commands.h index 948eaeb..bd2cf70 100644 --- a/libril/ril_unsol_commands.h +++ b/libril/ril_unsol_commands.h @@ -62,3 +62,5 @@ {RIL_UNSOL_LCEDATA_RECV, radio::lceDataInd, WAKE_PARTIAL}, {RIL_UNSOL_PCO_DATA, radio::pcoDataInd, WAKE_PARTIAL}, {RIL_UNSOL_MODEM_RESTART, radio::modemResetInd, WAKE_PARTIAL}, + {RIL_UNSOL_CARRIER_INFO_IMSI_ENCRYPTION, radio::carrierInfoForImsiEncryption, WAKE_PARTIAL}, + {RIL_UNSOL_NETWORK_SCAN_RESULT, radio::networkScanResultInd, WAKE_PARTIAL}, diff --git a/libril/sap_service.cpp b/libril/sap_service.cpp index 7bed05a..254d000 100644 --- a/libril/sap_service.cpp +++ b/libril/sap_service.cpp @@ -532,7 +532,6 @@ Return<void> SapImpl::setTransferProtocolReq(int32_t token, SapTransferProtocol void *sapDecodeMessage(MsgId msgId, MsgType msgType, uint8_t *payloadPtr, size_t payloadLen) { void *responsePtr = NULL; - bool decodeStatus = false; pb_istream_t stream; /* Create the stream */ diff --git a/librilutils/Android.mk b/librilutils/Android.mk index 455f9bc..275fea9 100644 --- a/librilutils/Android.mk +++ b/librilutils/Android.mk @@ -14,9 +14,12 @@ LOCAL_C_INCLUDES += \ LOCAL_EXPORT_C_INCLUDE_DIRS := \ $(LOCAL_PATH)/../include +LOCAL_CFLAGS := -Wall -Wextra -Werror + LOCAL_PROTOC_OPTIMIZE_TYPE := nanopb-c-enable_malloc LOCAL_MODULE:= librilutils +LOCAL_VENDOR_MODULE:= true include $(BUILD_SHARED_LIBRARY) @@ -36,9 +39,12 @@ LOCAL_C_INCLUDES += \ LOCAL_EXPORT_C_INCLUDE_DIRS := \ $(LOCAL_PATH)/../include +LOCAL_CFLAGS : -Wall -Wextra -Werror + LOCAL_PROTOC_OPTIMIZE_TYPE := nanopb-c-enable_malloc LOCAL_MODULE:= librilutils_static +LOCAL_VENDOR_MODULE:= true include $(BUILD_STATIC_LIBRARY) @@ -49,6 +55,7 @@ include $(CLEAR_VARS) src_proto := $(LOCAL_PATH) LOCAL_MODULE := sap-api-java-static LOCAL_SRC_FILES := proto/sap-api.proto +LOCAL_CFLAGS := -Wall -Wextra -Werror LOCAL_PROTOC_OPTIMIZE_TYPE := micro include $(BUILD_STATIC_JAVA_LIBRARY) diff --git a/reference-ril/Android.mk b/reference-ril/Android.mk index d9908c1..6afdbd3 100644 --- a/reference-ril/Android.mk +++ b/reference-ril/Android.mk @@ -14,8 +14,11 @@ LOCAL_SRC_FILES:= \ LOCAL_SHARED_LIBRARIES := \ liblog libcutils libutils libril librilutils +LOCAL_STATIC_LIBRARIES := libqemu_pipe libbase + # for asprinf LOCAL_CFLAGS := -D_GNU_SOURCE +LOCAL_CFLAGS += -Wall -Wextra -Wno-unused-variable -Wno-unused-function -Werror LOCAL_C_INCLUDES := @@ -31,6 +34,8 @@ ifeq ($(TARGET_DEVICE),dream) LOCAL_CFLAGS += -DPOLL_CALL_STATE -DUSE_QMI endif +LOCAL_VENDOR_MODULE:= true + ifeq (foo,foo) #build shared library LOCAL_SHARED_LIBRARIES += \ diff --git a/reference-ril/reference-ril.c b/reference-ril/reference-ril.c index 9b9c624..f451fb0 100644 --- a/reference-ril/reference-ril.c +++ b/reference-ril/reference-ril.c @@ -37,7 +37,7 @@ #include <cutils/sockets.h> #include <sys/system_properties.h> #include <termios.h> -#include <system/qemu_pipe.h> +#include <qemu_pipe.h> #include "ril.h" @@ -606,8 +606,7 @@ static void requestOrSendDataCallList(RIL_Token *t) } responses[i].dnses = dnslist; - /* There is only on gateway in the emulator */ - responses[i].gateways = "10.0.2.2"; + responses[i].gateways = "10.0.2.2 fe80::2"; responses[i].mtu = DEFAULT_MTU; } else { @@ -803,9 +802,11 @@ static void requestGetCurrentCalls(void *data __unused, size_t datalen __unused, } return; +#ifdef WORKAROUND_ERRONEOUS_ANSWER error: RIL_onRequestComplete(t, RIL_E_GENERIC_FAILURE, NULL, 0); at_response_free(p_response); +#endif } static void requestDial(void *data, size_t datalen __unused, RIL_Token t) @@ -888,9 +889,13 @@ static void requestSignalStrength(void *data __unused, size_t datalen __unused, ATResponse *p_response = NULL; int err; char *line; - int count =0; - int numofElements=sizeof(RIL_SignalStrength_v6)/sizeof(int); - int response[numofElements]; + int count = 0; + // Accept a response that is at least v6, and up to v10 + int minNumOfElements=sizeof(RIL_SignalStrength_v6)/sizeof(int); + int maxNumOfElements=sizeof(RIL_SignalStrength_v10)/sizeof(int); + int response[maxNumOfElements]; + + memset(response, 0, sizeof(response)); err = at_send_command_singleline("AT+CSQ", "+CSQ:", &p_response); @@ -904,9 +909,9 @@ static void requestSignalStrength(void *data __unused, size_t datalen __unused, err = at_tok_start(&line); if (err < 0) goto error; - for (count =0; count < numofElements; count ++) { + for (count = 0; count < maxNumOfElements; count++) { err = at_tok_nextint(&line, &(response[count])); - if (err < 0) goto error; + if (err < 0 && count < minNumOfElements) goto error; } RIL_onRequestComplete(t, RIL_E_SUCCESS, response, sizeof(response)); @@ -1075,12 +1080,6 @@ static void requestCdmaDeviceIdentity(int request __unused, void *data __unused, RIL_onRequestComplete(t, RIL_E_SUCCESS, responseStr, count*sizeof(char*)); at_response_free(p_response); - - return; -error: - RLOGE("requestCdmaDeviceIdentity must never return an error when radio is on"); - at_response_free(p_response); - RIL_onRequestComplete(t, RIL_E_GENERIC_FAILURE, NULL, 0); } static void requestCdmaGetSubscriptionSource(int request __unused, void *data, @@ -1169,11 +1168,6 @@ static void requestCdmaSubscription(int request __unused, void *data __unused, responseStr[3] = "8587777777"; // MIN responseStr[4] = "1"; // PRL Version RIL_onRequestComplete(t, RIL_E_SUCCESS, responseStr, count*sizeof(char*)); - - return; -error: - RLOGE("requestRegistrationState must never return an error when radio is on"); - RIL_onRequestComplete(t, RIL_E_GENERIC_FAILURE, NULL, 0); } static void requestCdmaGetRoamingPreference(int request __unused, void *data __unused, diff --git a/rild/Android.mk b/rild/Android.mk index 4f5802b..7ac505c 100644 --- a/rild/Android.mk +++ b/rild/Android.mk @@ -17,6 +17,7 @@ LOCAL_WHOLE_STATIC_LIBRARIES := \ librilutils_static LOCAL_CFLAGS := -DRIL_SHLIB +LOCAL_CFLAGS += -Wall -Wextra -Werror ifeq ($(SIM_COUNT), 2) LOCAL_CFLAGS += -DANDROID_MULTI_SIM |