Fix pthread_create error handling in ril harder.

The previous patch fixed the behavior _if_ something goes wrong...
...but didn't fix the check for whether something went wrong.
pthread_create isn't a regular Unix "return -1 and set errno" kind
of function; it returns 0 on success and an error number (without
setting errno) on failure.

Bug: https://code.google.com/p/android/issues/detail?id=64189
Change-Id: I335af890885d6a672d7bac746fdfea3ed3995360

1 files changed, 3 insertions, 3 deletions

diff --git a/libril/ril.cpp b/libril/ril.cpp
index 0ac698e..03a075f 100644
--- a/libril/ril.cpp
+++ b/libril/ril.cpp
@@ -3184,9 +3184,9 @@ RIL_startEventLoop(void) {
     pthread_attr_init(&attr);
     pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED);
 
-    int ret = pthread_create(&s_tid_dispatch, &attr, eventLoop, NULL);
-    if (ret < 0) {
-        RLOGE("Failed to create dispatch thread: %s", strerror(errno));
+    int result = pthread_create(&s_tid_dispatch, &attr, eventLoop, NULL);
+    if (result != 0) {
+        RLOGE("Failed to create dispatch thread: %s", strerror(result));
         goto done;
     }