diff options
author | Paras Nagda <pnagda@codeaurora.org> | 2014-04-21 19:53:01 +0530 |
---|---|---|
committer | Gerrit - the friendly Code Review server <code-review@localhost> | 2014-04-21 07:25:44 -0700 |
commit | 0e8f203774864ef550445d951e2191dd9fb6fe96 (patch) | |
tree | 2949b4c7e65bdc8dd532d9b5abe226523e69a6e9 | |
parent | eedac24dab93fb31bf71de53075e184b43d83740 (diff) | |
download | android_hardware_qcom_media-0e8f203774864ef550445d951e2191dd9fb6fe96.tar.gz android_hardware_qcom_media-0e8f203774864ef550445d951e2191dd9fb6fe96.tar.bz2 android_hardware_qcom_media-0e8f203774864ef550445d951e2191dd9fb6fe96.zip |
mm-video: vdec : Avoid updating stride in flushing state
-omx component is accessing the buffer after fill_buffer_done call
on the client. This is to update the stride value for smooth
streaming.
- During flushing scenario, buffers are returned to the client through
fill_buffer_done call and client is expected to the free the buffers
in the same context. Accessing the buffer in this scenario is leading
to a crash during testH264_adaptiveSmallDrc.
- Fix is to avoid updating stride value when in flushing state.
CRs-fixed: 651562
Change-Id: Ibe79fad264f42da8a356ef6b43793203035bced7
-rw-r--r-- | mm-video/vidc/vdec/src/omx_vdec.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm-video/vidc/vdec/src/omx_vdec.cpp b/mm-video/vidc/vdec/src/omx_vdec.cpp index 5bb28a8c..55ac1bbb 100644 --- a/mm-video/vidc/vdec/src/omx_vdec.cpp +++ b/mm-video/vidc/vdec/src/omx_vdec.cpp @@ -7158,7 +7158,7 @@ OMX_ERRORTYPE omx_vdec::fill_buffer_done(OMX_HANDLETYPE hComp, } // update buffer stride so display can interpret the buffer correctly - if (m_use_smoothstreaming) { + if (m_use_smoothstreaming && !output_flush_progress) { OMX_U32 buf_index = buffer - m_out_mem_ptr; private_handle_t * handle = NULL; BufferDim_t dim; |