From 7bb0f627d3915da1ffacf0a57b8ebd302853af27 Mon Sep 17 00:00:00 2001 From: Kamal Negi Date: Fri, 18 Nov 2016 10:39:51 +0530 Subject: Memset structure values to 0 before sending an IOCTL Memset ext_ctl and v4l2_ctls structure values to 0 before processing it. If not set, unassigned values can have garbage values and that can lead to functional/feature failure. CRs-Fixed: 1091284 Change-Id: Ice666cddd8e734d2d91053c30c42493315292841 --- jni/FmIoctlsInterface.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/jni/FmIoctlsInterface.cpp b/jni/FmIoctlsInterface.cpp index 046ca1e..640a90f 100644 --- a/jni/FmIoctlsInterface.cpp +++ b/jni/FmIoctlsInterface.cpp @@ -111,6 +111,9 @@ int FmIoctlsInterface :: set_calibration struct v4l2_ext_controls v4l2_ctls; char cal_data[CAL_DATA_SIZE] = {0}; + memset(&v4l2_ctls, 0, sizeof(v4l2_ctls)); + memset(&ext_ctl, 0, sizeof(ext_ctl)); + cal_fp = fopen(CALIB_DATA_NAME, "r"); if(cal_fp != NULL) { if(fread(&cal_data[0], 1, CAL_DATA_SIZE, cal_fp) -- cgit v1.2.3