summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrago <rago@google.com>2016-08-22 17:59:38 -0700
committerJessica Wagantall <jwagantall@cyngn.com>2016-11-16 15:26:35 -0700
commit8fdae414dbd93abefeb07a78cd3c5ba211462ac0 (patch)
tree98c139a57517c07e6e77213645e17e7bae0ae9f8
parent85a58146f9776b47f6a133fe2fe73ba7c32c710f (diff)
downloadandroid_hardware_qcom_audio-stable/cm-12.1-caf-8916-YOG7D.tar.gz
android_hardware_qcom_audio-stable/cm-12.1-caf-8916-YOG7D.tar.bz2
android_hardware_qcom_audio-stable/cm-12.1-caf-8916-YOG7D.zip
Fix potential overflow in Visualizer effectstable/cm-12.1-caf-8916-YOG7D
CYNGNOS-3303 Bug: 30229821 Change-Id: Iea1c4a21735e893aeded95b980044ec0861a7ea8 (cherry picked from commit 2fa52194ef64843c2908c69527384c6c2fcdbafa) (cherry picked from commit 57ac66340ad488a17fc285b6fc2635cb7375d72b) (cherry picked from commit ae92537deb2006b163d8d9c8e0ff37848475931a)
-rw-r--r--visualizer/offload_visualizer.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/visualizer/offload_visualizer.c b/visualizer/offload_visualizer.c
index 94c44a59..f4cad35a 100644
--- a/visualizer/offload_visualizer.c
+++ b/visualizer/offload_visualizer.c
@@ -846,6 +846,14 @@ int visualizer_command(effect_context_t * context, uint32_t cmdCode, uint32_t cm
break;
case VISUALIZER_CMD_MEASURE: {
+ if (pReplyData == NULL || replySize == NULL ||
+ *replySize < (sizeof(int32_t) * MEASUREMENT_COUNT)) {
+ ALOGV("%s VISUALIZER_CMD_MEASURE error *replySize %d <"
+ "(sizeof(int32_t) * MEASUREMENT_COUNT) %d",
+ __func__, *replySize, sizeof(int32_t) * MEASUREMENT_COUNT);
+ android_errorWriteLog(0x534e4554, "30229821");
+ return -EINVAL;
+ }
uint16_t peak_u16 = 0;
float sum_rms_squared = 0.0f;
uint8_t nb_valid_meas = 0;