SupplicantStaIfaceHal: Always check for existing ifaces

Couple of methods in SupplicantStaIfaceHal are missing checks to ensure
if the iface specified exists or not. Adding them.

Bug: 73496702
Test: Unit tests

Change-Id: I7e7f37683c8da60723dfa84f60c12e27538b7866

1 files changed, 22 insertions, 0 deletions

diff --git a/tests/wifitests/src/com/android/server/wifi/SupplicantStaIfaceHalTest.java b/tests/wifitests/src/com/android/server/wifi/SupplicantStaIfaceHalTest.java
index e0e296fa5..d3f044f83 100644
--- a/tests/wifitests/src/com/android/server/wifi/SupplicantStaIfaceHalTest.java
+++ b/tests/wifitests/src/com/android/server/wifi/SupplicantStaIfaceHalTest.java
@@ -272,6 +272,19 @@ public class SupplicantStaIfaceHalTest {
     }
 
     /**
+     * Ensures that reject addition of an existing iface.
+     */
+    @Test
+    public void testDuplicateSetupIfaceV1_1_Fails() throws Exception {
+        mISupplicantMockV1_1 = mock(android.hardware.wifi.supplicant.V1_1.ISupplicant.class);
+        executeAndValidateInitializationSequenceV1_1(false, false);
+
+        // Trying setting up the wlan0 interface again & ensure it fails.
+        assertFalse(mDut.setupIface(WLAN0_IFACE_NAME));
+        verifyNoMoreInteractions(mISupplicantMockV1_1);
+    }
+
+    /**
      * Sunny day scenario for SupplicantStaIfaceHal interface teardown.
      */
     @Test
@@ -301,6 +314,15 @@ public class SupplicantStaIfaceHalTest {
     }
 
     /**
+     * Ensures that we reject removal of an invalid iface.
+     */
+    @Test
+    public void testInvalidTeardownInterfaceV1_1_Fails() throws Exception {
+        assertFalse(mDut.teardownIface(WLAN0_IFACE_NAME));
+        verifyNoMoreInteractions(mISupplicantMock);
+    }
+
+    /**
      * Sunny day scenario for SupplicantStaIfaceHal initialization
      * Asserts successful initialization of second interface
      */