summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRaph Levien <raph@google.com>2014-05-27 15:51:43 +0000
committerAndroid Git Automerger <android-git-automerger@android.com>2014-05-27 15:51:43 +0000
commitfb9c6e2e4e82c1eadfa9d560b4aa79b5f3fbe863 (patch)
tree958a4b94155bc2ad64a92d6214e8b27cf96f5288
parent8eef0a2ebf9fc8bf9933adc59d0580d15a90b0bb (diff)
parent7c382381191b2280b53c375fe83dfc6217bbdfa9 (diff)
downloadandroid_frameworks_minikin-fb9c6e2e4e82c1eadfa9d560b4aa79b5f3fbe863.tar.gz
android_frameworks_minikin-fb9c6e2e4e82c1eadfa9d560b4aa79b5f3fbe863.tar.bz2
android_frameworks_minikin-fb9c6e2e4e82c1eadfa9d560b4aa79b5f3fbe863.zip
am 7c382381: Fix for bug 15252902 native crash in Minikin
* commit '7c382381191b2280b53c375fe83dfc6217bbdfa9': Fix for bug 15252902 native crash in Minikin
-rw-r--r--libs/minikin/Layout.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/libs/minikin/Layout.cpp b/libs/minikin/Layout.cpp
index 886b7d1..3935eb7 100644
--- a/libs/minikin/Layout.cpp
+++ b/libs/minikin/Layout.cpp
@@ -615,13 +615,13 @@ void Layout::doLayoutRun(const uint16_t* buf, size_t start, size_t count, size_t
float y = 0;
for (size_t run_ix = 0; run_ix < items.size(); run_ix++) {
FontCollection::Run &run = items[run_ix];
+ if (run.font == NULL) {
+ ALOGE("no font for run starting u+%04x length %d", buf[run.start], run.end - run.start);
+ continue;
+ }
int font_ix = findFace(run.font, ctx);
ctx->paint.font = mFaces[font_ix];
hb_font_t* hbFont = ctx->hbFonts[font_ix];
- if (ctx->paint.font == NULL) {
- // TODO: should log what went wrong
- continue;
- }
#ifdef VERBOSE
std::cout << "Run " << run_ix << ", font " << font_ix <<
" [" << run.start << ":" << run.end << "]" << std::endl;