1 files changed, 17 insertions, 5 deletions
diff --git a/camera2/portability/src/com/android/ex/camera2/portability/AndroidCamera2Settings.java b/camera2/portability/src/com/android/ex/camera2/portability/AndroidCamera2Settings.java
index 0d3ef26..0062097 100644
--- a/camera2/portability/src/com/android/ex/camera2/portability/AndroidCamera2Settings.java
+++ b/camera2/portability/src/com/android/ex/camera2/portability/AndroidCamera2Settings.java
@@ -206,7 +206,7 @@ public class AndroidCamera2Settings extends CameraSettings {
         } else if (setting == CONTROL_AF_REGIONS) {
             return mFocusAreas.size() == 0;
         } else if (setting == CONTROL_AE_TARGET_FPS_RANGE) {
-            Range defaultFpsRange = mTemplateSettings.get(CONTROL_AE_TARGET_FPS_RANGE);
+            Range<Integer> defaultFpsRange = mTemplateSettings.get(CONTROL_AE_TARGET_FPS_RANGE);
             return (mPreviewFpsRangeMin == 0 && mPreviewFpsRangeMax == 0) ||
                     (defaultFpsRange != null && mPreviewFpsRangeMin == defaultFpsRange.getLower() &&
                             mPreviewFpsRangeMax == defaultFpsRange.getUpper());
@@ -228,6 +228,11 @@ public class AndroidCamera2Settings extends CameraSettings {
         } else if (setting == CONTROL_AWB_LOCK) {
             return Objects.equals(mAutoWhiteBalanceLocked, mTemplateSettings.get(CONTROL_AWB_LOCK));
         } else if (setting == JPEG_THUMBNAIL_SIZE) {
+            if (mExifThumbnailSize == null) {
+                // It doesn't matter if this is true or false since setting this
+                // to null in the request settings will use the default anyway.
+                return false;
+            }
             android.util.Size defaultThumbnailSize = mTemplateSettings.get(JPEG_THUMBNAIL_SIZE);
             return (mExifThumbnailSize.width() == 0 && mExifThumbnailSize.height() == 0) ||
                     (defaultThumbnailSize != null &&
@@ -273,9 +278,13 @@ public class AndroidCamera2Settings extends CameraSettings {
         updateRequestSettingOrForceToDefault(CONTROL_AWB_LOCK, mAutoWhiteBalanceLocked);
         // TODO: mRecordingHintEnabled
         updateRequestGpsData();
-        updateRequestSettingOrForceToDefault(JPEG_THUMBNAIL_SIZE,
-                new android.util.Size(
-                        mExifThumbnailSize.width(), mExifThumbnailSize.height()));
+        if (mExifThumbnailSize != null) {
+            updateRequestSettingOrForceToDefault(JPEG_THUMBNAIL_SIZE,
+                    new android.util.Size(
+                            mExifThumbnailSize.width(), mExifThumbnailSize.height()));
+        } else {
+            updateRequestSettingOrForceToDefault(JPEG_THUMBNAIL_SIZE, null);
+        }
 
         return mRequestSettings;
     }
@@ -419,7 +428,10 @@ public class AndroidCamera2Settings extends CameraSettings {
                     mode = CONTROL_SCENE_MODE_FIREWORKS;
                     break;
                 }
-                // TODO: We cannot support HDR
+                case HDR: {
+                    mode = LegacyVendorTags.CONTROL_SCENE_MODE_HDR;
+                    break;
+                }
                 case LANDSCAPE: {
                     mode = CONTROL_SCENE_MODE_LANDSCAPE;
                     break;