1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
|
/*
* Copyright (C) 2014 The CyanogenMod Project
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations under
* the License.
*/
#include <utils/String8.h>
#include <gtest/gtest.h>
#include <gmock/gmock.h>
#include <utils/KeyedVector.h>
#include "mocks/MockZipFile.h"
#include "mocks/MockZipEntry.h"
#include "AaptConfig.h"
#include "ConfigDescription.h"
#include "TestHelper.h"
#include "AaptAssets.h"
using android::String8;
using namespace testing;
// A path to an apk that would be considered valid
#define VALID_APK_FILE "/valid/valid.apk"
// Internal zip path to a dir that aapt is being asked to compile
#define COMPILING_OVERLAY_DIR "/assets/overlays/com.interesting.app"
// Internal zip path to a valid resource. aapt is expected to compile this resource.
#define COMPILING_OVERLAY_FILE COMPILING_OVERLAY_DIR "/res/drawable-xxhdpi/foo.png";
// Internal zip path to another overlay dir that is NOT being compiled
#define NOT_COMPILING_OVERLAY_DIR "/assets/overlays/com.boring.app"
// Internal zip path to a resource for an overlay that is NOT compiling. aapt is expected to ignore
#define NOT_COMPILING_OVERLAY_FILE COMPILING_OVERLAY_DIR "/assets/overlays/com.boring.app"
static ::testing::AssertionResult TestParse(const String8& input, ConfigDescription* config=NULL) {
if (AaptConfig::parse(String8(input), config)) {
return ::testing::AssertionSuccess() << input << " was successfully parsed";
}
return ::testing::AssertionFailure() << input << " could not be parsed";
}
static ::testing::AssertionResult TestParse(const char* input, ConfigDescription* config=NULL) {
return TestParse(String8(input), config);
}
TEST(ZipReadingTest, TestValidZipEntryIsAdded) {
MockZipFile zip;
MockZipEntry entry1;
const char* zipFile = VALID_APK_FILE;
const char* validFilename = COMPILING_OVERLAY_FILE;
EXPECT_CALL(entry1, getFileName())
.WillRepeatedly(Return(validFilename));
EXPECT_CALL(zip, getNumEntries())
.Times(1)
.WillRepeatedly(Return(1));
EXPECT_CALL(zip, getEntryByIndex(_))
.Times(1)
.WillOnce(Return(&entry1));
sp<AaptAssets> assets = new AaptAssets();
Bundle bundle;
bundle.setInternalZipPath(COMPILING_OVERLAY_DIR);
ssize_t count = assets->slurpResourceZip(&bundle, &zip, zipFile);
Vector<sp<AaptDir> > dirs = assets->resDirs();
EXPECT_EQ(1, dirs.size());
EXPECT_EQ(1, count);
}
TEST(ZipReadingTest, TestDifferentThemeEntryNotAdded) {
MockZipFile zip;
MockZipEntry entry1;
const char* zipFile = VALID_APK_FILE;
const char* invalidFile = NOT_COMPILING_OVERLAY_FILE;
EXPECT_CALL(entry1, getFileName())
.WillRepeatedly(Return(invalidFile));
EXPECT_CALL(zip, getNumEntries())
.WillRepeatedly(Return(1));
EXPECT_CALL(zip, getEntryByIndex(_))
.Times(1)
.WillOnce(Return(&entry1));
sp<AaptAssets> assets = new AaptAssets();
Bundle bundle;
bundle.setInternalZipPath(COMPILING_OVERLAY_DIR);
ssize_t count = assets->slurpResourceZip(&bundle, &zip, zipFile);
Vector<sp<AaptDir> > dirs = assets->resDirs();
EXPECT_EQ(0, dirs.size());
EXPECT_EQ(0, count);
}
TEST(ZipReadingTest, TestOutsideEntryMarkedInvalid) {
Bundle bundle;
bundle.setInternalZipPath("VALID_OVERLAY_DIR");
MockZipEntry invalidEntry;
const char* invalidFile = NOT_COMPILING_OVERLAY_FILE;
EXPECT_CALL(invalidEntry, getFileName())
.WillRepeatedly(Return(invalidFile));
sp<AaptAssets> assets = new AaptAssets();
bool result = assets->isEntryValid(&bundle, &invalidEntry);
EXPECT_FALSE(result);
}
TEST(ZipReadingTest, TestNullEntryIsInvalid) {
Bundle bundle;
bundle.setInternalZipPath(COMPILING_OVERLAY_DIR);
MockZipEntry invalidEntry;
const char* invalidFile = NOT_COMPILING_OVERLAY_FILE;
EXPECT_CALL(invalidEntry, getFileName())
.WillRepeatedly(Return(invalidFile));
sp<AaptAssets> assets = new AaptAssets();
bool result = assets->isEntryValid(&bundle, NULL);
EXPECT_FALSE(result);
}
TEST(ZipReadingTest, TestDirectoryEntryMarkedInvalid) {
Bundle bundle;
bundle.setInternalZipPath(COMPILING_OVERLAY_DIR);
MockZipEntry invalidEntry2;
// Add a "/" signifying this is a dir entry not a file entry.
const char* dir2 = COMPILING_OVERLAY_DIR"/";
EXPECT_CALL(invalidEntry2, getFileName())
.WillRepeatedly(Return(dir2));
sp<AaptAssets> assets = new AaptAssets();
bool result2 = assets->isEntryValid(&bundle, &invalidEntry2);
EXPECT_FALSE(result2);
}
|
