diff options
| author | Jouni Malinen <j@w1.fi> | 2015-05-02 19:23:04 +0300 |
|---|---|---|
| committer | Michael Bestas <mikeioannina@gmail.com> | 2015-11-11 19:39:36 +0200 |
| commit | dcf16cc5145ca4983555b750d56c897f1686c6e4 (patch) | |
| tree | 081b6acb9dfd9e2f7f98d0119048258a21260e70 | |
| parent | b80a22d054ee8e7522fc0053338c27701c472d0b (diff) | |
| download | android_external_wpa_supplicant_8-dcf16cc5145ca4983555b750d56c897f1686c6e4.tar.gz android_external_wpa_supplicant_8-dcf16cc5145ca4983555b750d56c897f1686c6e4.tar.bz2 android_external_wpa_supplicant_8-dcf16cc5145ca4983555b750d56c897f1686c6e4.zip | |
EAP-pwd peer: Fix Total-Length parsing for fragment reassembly
The remaining number of bytes in the message could be smaller than the
Total-Length field size, so the length needs to be explicitly checked
prior to reading the field and decrementing the len variable. This could
have resulted in the remaining length becoming negative and interpreted
as a huge positive integer.
In addition, check that there is no already started fragment in progress
before allocating a new buffer for reassembling fragments. This avoid a
potential memory leak when processing invalid message.
Change-Id: Iff93a6434df546f093eb192e999e82f999abb96e
Signed-off-by: Jouni Malinen <j@w1.fi>
| -rw-r--r-- | src/eap_peer/eap_pwd.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/src/eap_peer/eap_pwd.c b/src/eap_peer/eap_pwd.c index 5d6e9e7f..871bb685 100644 --- a/src/eap_peer/eap_pwd.c +++ b/src/eap_peer/eap_pwd.c @@ -774,9 +774,21 @@ eap_pwd_process(struct eap_sm *sm, void *priv, struct eap_method_ret *ret, * if it's the first fragment there'll be a length field */ if (EAP_PWD_GET_LENGTH_BIT(lm_exch)) { + if (len < 2) { + wpa_printf(MSG_DEBUG, + "EAP-pwd: Frame too short to contain Total-Length field"); + ret->ignore = TRUE; + return NULL; + } tot_len = WPA_GET_BE16(pos); wpa_printf(MSG_DEBUG, "EAP-pwd: Incoming fragments whose " "total length = %d", tot_len); + if (data->inbuf) { + wpa_printf(MSG_DEBUG, + "EAP-pwd: Unexpected new fragment start when previous fragment is still in use"); + ret->ignore = TRUE; + return NULL; + } data->inbuf = wpabuf_alloc(tot_len); if (data->inbuf == NULL) { wpa_printf(MSG_INFO, "Out of memory to buffer " |