summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWei Jia <wjia@google.com>2017-02-13 22:41:25 +0000
committerAndroid (Google) Code Review <android-gerrit@google.com>2017-02-13 22:41:25 +0000
commit008d81708eb81a0879fa25a80ae20253a0116592 (patch)
treeb023e57bb4146596a08770fd590cabeaebb07c4a
parent6e988ba8325243acbf1a5b60d2ab2f36a9d61199 (diff)
parent56d153259cc3e16a6a0014199a2317dde333c978 (diff)
downloadandroid_external_sonivox-008d81708eb81a0879fa25a80ae20253a0116592.tar.gz
android_external_sonivox-008d81708eb81a0879fa25a80ae20253a0116592.tar.bz2
android_external_sonivox-008d81708eb81a0879fa25a80ae20253a0116592.zip
Merge "eas_mdls: fix OOB read." into klp-dev
-rw-r--r--arm-wt-22k/lib_src/eas_mdls.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/arm-wt-22k/lib_src/eas_mdls.c b/arm-wt-22k/lib_src/eas_mdls.c
index e2cb688..296d783 100644
--- a/arm-wt-22k/lib_src/eas_mdls.c
+++ b/arm-wt-22k/lib_src/eas_mdls.c
@@ -114,6 +114,8 @@
/* this define allows us to use the sndlib.h structures as RW memory */
#define SCNST
+#include "log/log.h"
+
#include "eas_data.h"
#include "eas_host.h"
#include "eas_mdls.h"
@@ -2086,8 +2088,11 @@ static EAS_RESULT PushcdlStack (EAS_U32 *pStack, EAS_INT *pStackPtr, EAS_U32 val
{
/* stack overflow, return an error */
- if (*pStackPtr >= CDL_STACK_SIZE)
+ if (*pStackPtr >= (CDL_STACK_SIZE - 1)) {
+ ALOGE("b/34031018, stackPtr(%d)", *pStackPtr);
+ android_errorWriteLog(0x534e4554, "34031018");
return EAS_ERROR_FILE_FORMAT;
+ }
/* push the value onto the stack */
*pStackPtr = *pStackPtr + 1;