aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Veillard <veillard@redhat.com>2012-10-26 13:50:47 +0800
committerDaniel Veillard <veillard@redhat.com>2012-10-26 13:50:47 +0800
commit153cf15905cf4ec080612ada6703757d10caba1e (patch)
treeda38d77f2b5a563fcae61b533fcfc17d21c594e7
parent711b15d545713b3a34a51ce8163d1162533647c9 (diff)
downloadandroid_external_libxml2-153cf15905cf4ec080612ada6703757d10caba1e.tar.gz
android_external_libxml2-153cf15905cf4ec080612ada6703757d10caba1e.tar.bz2
android_external_libxml2-153cf15905cf4ec080612ada6703757d10caba1e.zip
Fix large parse of file from memory
https://bugzilla.redhat.com/show_bug.cgi?id=862969 The new code trying to detect excessive input lookup would just get wrong sometimes in the case of very large file parsed directly from memory.
-rw-r--r--libxml.h2
-rw-r--r--parser.c1
-rw-r--r--xmlIO.c2
3 files changed, 4 insertions, 1 deletions
diff --git a/libxml.h b/libxml.h
index efe285bc..7558b5f0 100644
--- a/libxml.h
+++ b/libxml.h
@@ -91,6 +91,8 @@ void __xmlGlobalInitMutexDestroy(void);
int __xmlRandom(void);
#endif
+int xmlNop(void);
+
#ifdef IN_LIBXML
#ifdef __GNUC__
#ifdef PIC
diff --git a/parser.c b/parser.c
index 43f53d9d..0d8d7f2e 100644
--- a/parser.c
+++ b/parser.c
@@ -2025,6 +2025,7 @@ static void xmlSHRINK (xmlParserCtxtPtr ctxt) {
static void xmlGROW (xmlParserCtxtPtr ctxt) {
if ((((ctxt->input->end - ctxt->input->cur) > XML_MAX_LOOKUP_LIMIT) ||
((ctxt->input->cur - ctxt->input->base) > XML_MAX_LOOKUP_LIMIT)) &&
+ ((ctxt->input->buf) && (ctxt->input->buf->readcallback != xmlNop)) &&
((ctxt->options & XML_PARSE_HUGE) == 0)) {
xmlFatalErr(ctxt, XML_ERR_INTERNAL_ERROR, "Huge input lookup");
ctxt->instate = XML_PARSER_EOF;
diff --git a/xmlIO.c b/xmlIO.c
index f8f438b7..44254e4c 100644
--- a/xmlIO.c
+++ b/xmlIO.c
@@ -800,7 +800,7 @@ xmlCheckFilename (const char *path)
return 1;
}
-static int
+int
xmlNop(void) {
return(0);
}