diff options
| author | Mark Wielaard <mjw@redhat.com> | 2015-06-18 11:07:41 +0200 |
|---|---|---|
| committer | Mark Wielaard <mjw@redhat.com> | 2015-06-19 12:33:27 +0200 |
| commit | 9beaa94e56fb8b717f838e02905e100647138bf9 (patch) | |
| tree | 1deb205bc0e50ffbf8548320b853ea4f8f34ef7e /src/ChangeLog | |
| parent | afd11605de0d2e16e8a2fa3094fa468b1901cd5e (diff) | |
| download | android_external_elfutils-9beaa94e56fb8b717f838e02905e100647138bf9.tar.gz android_external_elfutils-9beaa94e56fb8b717f838e02905e100647138bf9.tar.bz2 android_external_elfutils-9beaa94e56fb8b717f838e02905e100647138bf9.zip | |
nm: Fix typo in size check to determine whether we stack allocated memory.
We allocate GElf_SymX entries, which are larger than plain GElf_Sym structs.
The check to see whether we could use stack allocation used the correct
sizeof (GElf_SymX), but the check to see if we needed to free was using
the incorrect sizeof (GElf_Sym). Which could cause us to leak memory.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Diffstat (limited to 'src/ChangeLog')
| -rw-r--r-- | src/ChangeLog | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/ChangeLog b/src/ChangeLog index 3d7761f9..dbd1e44e 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,5 +1,10 @@ 2015-06-18 Mark Wielaard <mjw@redhat.com> + * nm.c (show_symbols): Check sizeof (sym_mem[0]), not GElf_Sym to + known whether or not we stack allocated memory. + +2015-06-18 Mark Wielaard <mjw@redhat.com> + * strings.c (readelf): Use "<unknown>" if we cannot retrieve section name. |