| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the value being printed has embedded quotes ("), then printing
those quotes could confuse other tools when parsing the value.
This is the simplest CL to fix the security issue, and we can circle
back to think about more robust escaping in a future CL.
Bug: 80436257
Test: manual
Change-Id: Ica17f2c5701573bceafe34f20110d230a3925483
(cherry picked from commit efe90c297a8df591c051fdbfacb92b5283390bba)
|
|
|
|
|
|
| |
Backported from mainline util-linux
Change-Id: I3afb543ed027786ee20c3e7c9093ff7f5af54a04
|
|\
| |
| |
| | |
Android 4.4.1 Release 1
|
| |
| |
| |
| |
| |
| |
| |
| | |
When calculating time diffs, use difftime() instead of risking
integer overflow. Also build a "blkid" binary.
Bug: 11175082
Change-Id: I23521f45204574bb32f152926401c2cbad93175b
|
|\|
| |
| |
| | |
Android 4.4 Release 1.0
|
| |
| |
| |
| |
| |
| |
| |
| | |
They are not installed in any build by default, but can now
be easily made with mm if they are needed for debugging
filesystem corruption issues.
Change-Id: I32a118ba4e504f344c936451f5e22ecd73302c06
|
| |
| |
| |
| |
| |
| |
| | |
* e2fsprogs can't currently detect exFAT filesystems.
* Apply patch from GoogleTV to add support.
Change-Id: Ib08bdb1d13e995d133a62539e3bfa0e3a22eeead
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
dev->bid_time was initialized to INT_MIN causing an
overflow in cache age calculation, which in turn
caused a new device structure to not be filled with
data due to assumed up-to-date values.
Change-Id: I232e0a57d52777cf0ae6f5f7d01cbf8601a9011f
|
|\|
| |
| |
| | |
https://android.googlesource.com/platform/external/e2fsprogs into mr1-staging
|
| |\
| | |
| | |
| | |
| | |
| | |
| | | |
superblock
* commit '5886dc5cdcccd3d09a208d41d8c23748c25a2a22':
e2fsck: correctly propagate error from journal to superblock
|
| | |\
| | | |
| | | |
| | | |
| | | | |
* commit 'fada366033e80c119867eb303e8b48a8e027a9be':
e2fsck: correctly propagate error from journal to superblock
|
| |\| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
non-zero s_error field
* commit '0a02698f2851f419aa75536afb5f040a5c9ce002':
e2fsck: handle an already recovered journal with a non-zero s_error field
|
| | |\ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
s_error field
* commit 'df5d2e2b942bb263972fe30a4baafd68056e02bd':
e2fsck: handle an already recovered journal with a non-zero s_error field
|
| |\| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
journal has recorded an error"
* commit '493c82bb54397d2f46d2067bcedf966ea6da691f':
Revert "Fix e2fsck to run a full check if only the journal has recorded an error"
|
| | |\ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
recorded an error"
* commit '97bd1b76758fc5c78b000df9a8bc3840e4f1d31c':
Revert "Fix e2fsck to run a full check if only the journal has recorded an error"
|
| |\| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
superblock if err set in journal superblock."
* commit '766baba9d08c13ec364f20ad70ca36303f186038':
Revert "Better fix for marking fs err in superblock if err set in journal superblock."
|
| | |\ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
in journal superblock."
* commit 'a8948fce2be374a697f38bcefc8c33271b83b432':
Revert "Better fix for marking fs err in superblock if err set in journal superblock."
|
| |\| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
set in journal superblock.
* commit '1f0e651eb5b5d45bb68ef3902c40d9c32399bc9f':
Better fix for marking fs err in superblock if err set in journal superblock.
|
| | |\ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
journal superblock.
* commit '46e96be157785a3582844efb27f4eef38943400b':
Better fix for marking fs err in superblock if err set in journal superblock.
|
| |\| | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
has recorded an error
* commit '82ca75b8ac7270a54aa5349a76e1df618023997d':
Fix e2fsck to run a full check if only the journal has recorded an error
|
| | |\ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
an error
* commit '8c157a2c73b27b3f3ae566be78279460a35ccbc1':
Fix e2fsck to run a full check if only the journal has recorded an error
|
| |\| | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
* commit 'a2e05ead45f57030aa86a82bbaf891f28f7d5a58':
Xcode 4.3 compatibility checkin
|
| | |\ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
* commit '3e60e44fae35febb9da905394698b21b45ad7301':
Xcode 4.3 compatibility checkin
|
| | | |\ \ \ \ \ \ \ |
|
| | | |/ / / / / / /
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Compilation on Xcode 4.3 does not handle inlined functions well and so the
compile fails.
This patch ensures that inlines are not used on that compiler.
Signed-off-by: Al Sutton <al@funkyandroid.com>
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Android builds for MacOS 10.5. The new version version of e2fsprogs requires
posix_memalign(), which was added in MacOS 10.6. Since MacOS doesn't provide
memalign() either, the only option is to use valloc(). This patch was inspired
by a patch to e2fsprogs that came from the macports port of e2fsprogs.
Change-Id: If1334ce409985c1bdba4384ada8ecbc3dec56d81
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Mac OS doesn't support the O_DIRECT flag, so use the F_NOCACHE
option of fcntl() instead. Fix taken from the libext2 project
on soruceforge.
Change-Id: I1e88a95e53f1bbbd8dbcfc7aa43a27443dfd6807
|
| |/ / / / / / / /
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Change-Id: Ia1ae1df03ba5ae95f9437686285a6f5119c5aa9b
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Change-Id: I8725cc296be8967265261e92da743c149e9ec45b
|
| |_|_|_|_|_|_|/
|/| | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
change makefies to build static mke2fs and tune2fs and place them in
$(PRODUCT_OUT)/utilities
Conflicts:
e2fsck/Android.mk
lib/blkid/Android.mk
lib/ext2fs/Android.mk
misc/Android.mk
Change-Id: I0139b3dcfe64a4031db7719ddd71120d174d1990
|
| |_|_|_|_|_|/
|/| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
If the file system is mounted read-only after a file system error has
been detected, the fact that an error occurred is written to the
journal. This is important because while the journal is getting
replayed, the error indication in the superblock may very well get
overwritten.
Unfortunately, the code to propagate the error indication from the
journal to superblock was broken because this was being done before
the old file system handle is thrown away and the file system is
re-opened to ensure that no stale data is in the file system handle.
As a result, the error indication in the superblock was never written
out.
To fix this, we need to move the check if the journal's error
indicator has been set after the file system has been freed and
re-open.
Reported-by: Ken Sumrall <ksumrall@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
|
| |_|_|_|_|/
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
If a file system was remounted read-only after a file system
corruption is detected, and then that file system is mounted and
unmounted by the kernel, the journal would have been recovered, but
the kernel currently leaves the s_errno field still set. This is
arguably a bug, since it has already propgated the non-zero s_errno
field to the file system superblock, where it will be retained until
e2fsck has been run.
However, e2fsck should handle this case for existing kernel by
checking the journal superblock's s_errno field even if journal
recovery is not required.
Without this commit, e2fsck would not notice anything wrong with the
file system, but a subsequent mount of the file system by the kernel
would mark the file system's superblock as needing checking (since the
journal's s_errno field would still be set), resulting an full e2fsck
run at the next reboot, which would find nothing wrong --- and then
when the file system was mounted, the whole cycle would repeat again.
I had seen reports of this in the past, but it wasn't until recently
that I realized exactly how this had come about, since normally e2fsck
would be run automatically before the file system is mounted again,
thus avoiding this problem. However, a user using a rescue CD who
didn't run e2fsck before mounting the a file system in this condition
could trigger this situation, and unfortunately, with previous
versions of e2fsprogs and the kernel, there would be no way out no
matter what the user tried to do.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
|
| |_|_|_|/
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
error"
This reverts commit 8c157a2c73b27b3f3ae566be78279460a35ccbc1.
|
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | | |
superblock."
This reverts commit 46e96be157785a3582844efb27f4eef38943400b.
|
| |_|/
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The previous fix of flushing out the superblock after setting the
EXT2_ERROR_FS flag was erroneous because running the journal could have
updated the superblock (but not the in-memory copy the code referenced).
So instead, check the journal error conditions after running the journal
and freeing and re-opening the filesystem. Also, make sure to flush
the error state of the superblock to disk before clearing the error state
of the journal.
Change-Id: Ia5cde1a367d86992c9bd3bca652a1289935d1380
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
If only the journal superblock had recorded an error, but not the ext4
superblock, e2fsck would mark the superblock as containing an error.
However, it was never flushed to disk before e2fsck restarted itself
after recovering the journal, and the full check didn't happen.
Change-Id: I2952b50d3f27c6b72b6167903dbc5a26c188df0c
|
|/
|
|
|
|
|
|
|
| |
Bug: 5573756
The uses of LOCAL_MODULE_STEM are unnecessary here.
To implement the feature requested by bug 5573756, we need library
name to be the same as its module name.
Change-Id: Ibbea9c1e1f4f8f2f5af0b467787ccb214c47d3fd
|
|\
| |
| |
| |
| | |
* commit 'e20724c9c530e03bdeaf3f6ff31f2334ea7ffc72':
Change systembuilder tag to optional
|
| |\
| | |
| | |
| | | |
Change-Id: I9f547b2e5ea97a503abd7a6a18811af309913345
|
| | |\ |
|
| | |/
| | |
| | |
| | |
| | | |
Orig-Change-Id: Ieb530c78ddd3968760eea209a4f02c9e9b781134
Signed-off-by: Bruce Beare <brucex.j.beare@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Bug: 5010576
Change-Id: I335bcedd2aeab7da8e26ba975de6e02bfc062ee8
|
| | |
| | |
| | |
| | | |
This reverts commit 89a994149ee53292ea7d9557f20d3828dc4aad3d.
|
|/ /
| |
| |
| |
| | |
Change-Id: Ic60cf9128945baa7319253e63b12b97ad230dc40
Signed-off-by: Iliyan Malchev <malchev@google.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
A typo in the build target tags was causing them all to be
left blank. use_e2fsprogs_module_tags is unused now, so
change all targets to optional.
Change-Id: Ie6cf18b8443c9b09b8b9e88fac3569b5527fec64
|
|\ \
| | |
| | |
| | | |
Change-Id: I3238fb8cf7fcf6a20c53b59e27bcb68af7d44060
|
| |/
| |
| |
| |
| | |
Change-Id: Ieb530c78ddd3968760eea209a4f02c9e9b781134
Signed-off-by: Bruce Beare <brucex.j.beare@intel.com>
|
| |
| |
| |
| | |
Change-Id: I7aa64ec932982ec22febe7300750da50525a71c6
|
| |
| |
| |
| | |
Change-Id: I7c73c5c99b25e66ead23e3201790bb9735f36ce5
|
| |
| |
| |
| | |
Change-Id: I7e4a7893b5b30ca4117b659e2a6b339c1c278c24
|