From e62a21de02586e1654cc460326383e6a5a9fd033 Mon Sep 17 00:00:00 2001 From: Sergio Giro Date: Tue, 12 Apr 2016 14:52:31 +0100 Subject: EC: add bug number in TODO comment about registrations failing Bug: 20447540 Bug: 26929227 Change-Id: I390fb8f70aa5ce982e54cdc7068d47af2c5f7a0a --- .../java/org/bouncycastle/jcajce/provider/asymmetric/EC.java | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/bcprov/src/main/java/org/bouncycastle/jcajce/provider/asymmetric/EC.java b/bcprov/src/main/java/org/bouncycastle/jcajce/provider/asymmetric/EC.java index 43cc555..99a27bf 100644 --- a/bcprov/src/main/java/org/bouncycastle/jcajce/provider/asymmetric/EC.java +++ b/bcprov/src/main/java/org/bouncycastle/jcajce/provider/asymmetric/EC.java @@ -83,12 +83,17 @@ public class EC // registerOid(provider, SECObjectIdentifiers.dhSinglePass_stdDH_sha512kdf_scheme, "EC", new KeyFactorySpi.EC()); // registerOid(provider, SECObjectIdentifiers.dhSinglePass_cofactorDH_sha512kdf_scheme, "EC", new KeyFactorySpi.EC()); // - // // Android comment: the registration below is causing CTS tests to fail and doesn't seem - // // to be implemented by bouncycastle (so looks like an bug in bouncycastle). - // // TODO(26929227): check this still happens + // END android-removed + // BEGIN android-removed + // // Android comment: the registrations in this block are causing CTS tests to fail + // // and don't seem to be implemented by bouncycastle (so looks like an bug in + // // bouncycastle). + // // TODO(20447540): check if this occurs in upstream bouncycastle and report accordingly // registerOidAlgorithmParameters(provider, X9ObjectIdentifiers.id_ecPublicKey, "EC"); // // registerOidAlgorithmParameters(provider, X9ObjectIdentifiers.dhSinglePass_stdDH_sha1kdf_scheme, "EC"); + // END android-removed + // BEGIN android-removed // registerOidAlgorithmParameters(provider, X9ObjectIdentifiers.dhSinglePass_cofactorDH_sha1kdf_scheme, "EC"); // // registerOidAlgorithmParameters(provider, SECObjectIdentifiers.dhSinglePass_stdDH_sha224kdf_scheme, "EC"); -- cgit v1.2.3