diff options
| author | huans <huans@google.com> | 2018-08-01 15:06:44 -0700 |
|---|---|---|
| committer | huans <huans@google.com> | 2018-08-01 15:11:57 -0700 |
| commit | 0d147bd9fba79b9e00047cc16550903e8b57b745 (patch) | |
| tree | 9197fe9906b11d0602e3966aafea29a82a6c27d1 | |
| parent | 58b29027df7586aebdc37f92e8e54ffabdc06c71 (diff) | |
| download | android_device_generic_goldfish-0d147bd9fba79b9e00047cc16550903e8b57b745.tar.gz android_device_generic_goldfish-0d147bd9fba79b9e00047cc16550903e8b57b745.tar.bz2 android_device_generic_goldfish-0d147bd9fba79b9e00047cc16550903e8b57b745.zip | |
Fix sanity check for configureStream.
bug: 111658209
Test: run vts -m VtsHalCameraProviderV2_4Target
Change-Id: I0ca633510a525368d5a2b0277b265ec141505d2f
| -rw-r--r-- | camera/EmulatedFakeCamera3.cpp | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/camera/EmulatedFakeCamera3.cpp b/camera/EmulatedFakeCamera3.cpp index 96c2350..625a0f1 100644 --- a/camera/EmulatedFakeCamera3.cpp +++ b/camera/EmulatedFakeCamera3.cpp @@ -265,7 +265,7 @@ status_t EmulatedFakeCamera3::configureStreams( } ALOGV("%s: Stream %p (id %zu), type %d, usage 0x%x, format 0x%x " - "width %d, height %d", + "width 0x%x, height 0x%x", __FUNCTION__, newStream, i, newStream->stream_type, newStream->usage, newStream->format, @@ -291,10 +291,9 @@ status_t EmulatedFakeCamera3::configureStreams( } } - if (newStream->width <= 0 || - (int32_t)newStream->width > mSensorWidth || - newStream->height <= 0 || - (int32_t)newStream->height > mSensorHeight) { + if (newStream->width == 0 || newStream->height == 0 || + newStream->width > (uint32_t)mSensorWidth || + newStream->height > (uint32_t)mSensorHeight) { ALOGE("%s: Unsupported stream width 0x%x height 0x%x", __FUNCTION__, newStream->width, newStream->height); return BAD_VALUE; |