summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorAurimas Liutikas <aurimas@google.com>2016-02-08 12:57:52 -0800
committerAurimas Liutikas <aurimas@google.com>2016-02-08 22:29:03 +0000
commit9b1ba578d72bd8748f2fb49f812d48f7b03c6a57 (patch)
tree599e787a54d96d9aca333a567b905a26056203c3 /tools
parentd2a8a47bc4f7514c4730606fe1ee1f921880d805 (diff)
downloadandroid_development-9b1ba578d72bd8748f2fb49f812d48f7b03c6a57.tar.gz
android_development-9b1ba578d72bd8748f2fb49f812d48f7b03c6a57.tar.bz2
android_development-9b1ba578d72bd8748f2fb49f812d48f7b03c6a57.zip
Add new rules to Checkstyle config.
Add the following new checks: - JavadocMethod - MissingDeprecated - MissingOverride - OneTopLevelClass - StringLiteralEquality - ArrayTypeStyle - RedundantModifier - NewlineAtEndOfFile Bug: 27051781 Change-Id: I4d34278f73ee821cd6cfea705cf949881eaebfc2
Diffstat (limited to 'tools')
-rw-r--r--tools/checkstyle/android-style.xml24
1 files changed, 23 insertions, 1 deletions
diff --git a/tools/checkstyle/android-style.xml b/tools/checkstyle/android-style.xml
index 7e4ea52d3..2d11bf5ed 100644
--- a/tools/checkstyle/android-style.xml
+++ b/tools/checkstyle/android-style.xml
@@ -32,8 +32,9 @@
<message key="javadoc.missing" value="Public classes and interfaces require JavaDoc comments."/>
</module>
<module name="JavadocMethod">
- <property name="severity" value="info"/>
+ <property name="severity" value="error"/>
<property name="scope" value="public"/>
+ <property name="tokens" value="METHOD_DEF"/>
<property name="allowMissingParamTags" value="true"/>
<property name="allowMissingPropertyJavadoc" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
@@ -197,11 +198,32 @@
<property name="tokens" value="COMMA"/>
<property name="option" value="EOL"/>
</module>
+ <module name="MissingDeprecated">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="MissingOverride">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="OneTopLevelClass">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="StringLiteralEquality">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="ArrayTypeStyle">
+ <property name="severity" value="error"/>
+ </module>
+ <module name="RedundantModifier">
+ <property name="severity" value="error"/>
+ </module>
<module name="FileContentsHolder"/>
</module>
<module name="FileTabCharacter">
<property name="severity" value="error"/>
</module>
+ <module name="NewlineAtEndOfFile">
+ <property name="severity" value="error"/>
+ </module>
<module name="RegexpSingleline">
<property name="severity" value="error"/>
<property name="format" value="[ \t]+$"/>