diff options
author | Dan Bornstein <danfuzz@android.com> | 2011-05-26 10:11:58 -0700 |
---|---|---|
committer | Dan Bornstein <danfuzz@android.com> | 2011-05-26 10:11:58 -0700 |
commit | 60fc806b679a3655c228b4093058c59941a49cfe (patch) | |
tree | 06b08460aa3a4c5a56b553b6cb90a0f607beef18 /vm/interp | |
parent | d9d1a8685a394c7fd67d87aa52e826b88c981994 (diff) | |
download | android_dalvik-60fc806b679a3655c228b4093058c59941a49cfe.tar.gz android_dalvik-60fc806b679a3655c228b4093058c59941a49cfe.tar.bz2 android_dalvik-60fc806b679a3655c228b4093058c59941a49cfe.zip |
Further conservation of newlines.
Friends don't let friends end LOG() strings with newlines.
Change-Id: I5a18c766c90c4ab5f03caa6acd601d34d91beb00
Diffstat (limited to 'vm/interp')
-rw-r--r-- | vm/interp/Interp.cpp | 72 | ||||
-rw-r--r-- | vm/interp/Stack.cpp | 58 |
2 files changed, 65 insertions, 65 deletions
diff --git a/vm/interp/Interp.cpp b/vm/interp/Interp.cpp index 7c68e903c..32ae3ec6f 100644 --- a/vm/interp/Interp.cpp +++ b/vm/interp/Interp.cpp @@ -243,7 +243,7 @@ static bool dvmBreakpointSetAdd(BreakpointSet* pSet, Method* method, int newSize = pSet->alloc + kBreakpointGrowth; Breakpoint* newVec; - LOGV("+++ increasing breakpoint set size to %d\n", newSize); + LOGV("+++ increasing breakpoint set size to %d", newSize); /* pSet->breakpoints will be NULL on first entry */ newVec = (Breakpoint*)realloc(pSet->breakpoints, newSize * sizeof(Breakpoint)); @@ -275,10 +275,10 @@ static bool dvmBreakpointSetAdd(BreakpointSet* pSet, Method* method, */ assert(*(u1*)addr != OP_BREAKPOINT); if (dvmIsClassVerified(method->clazz)) { - LOGV("Class %s verified, adding breakpoint at %p\n", + LOGV("Class %s verified, adding breakpoint at %p", method->clazz->descriptor, addr); if (instructionIsMagicNop(addr)) { - LOGV("Refusing to set breakpoint on %04x at %s.%s + 0x%x\n", + LOGV("Refusing to set breakpoint on %04x at %s.%s + 0x%x", *addr, method->clazz->descriptor, method->name, instrOffset); } else { @@ -287,7 +287,7 @@ static bool dvmBreakpointSetAdd(BreakpointSet* pSet, Method* method, OP_BREAKPOINT); } } else { - LOGV("Class %s NOT verified, deferring breakpoint at %p\n", + LOGV("Class %s NOT verified, deferring breakpoint at %p", method->clazz->descriptor, addr); } } else { @@ -317,11 +317,11 @@ static void dvmBreakpointSetRemove(BreakpointSet* pSet, Method* method, if (idx < 0) { /* breakpoint not found in set -- unexpected */ if (*(u1*)addr == OP_BREAKPOINT) { - LOGE("Unable to restore breakpoint opcode (%s.%s +0x%x)\n", + LOGE("Unable to restore breakpoint opcode (%s.%s +0x%x)", method->clazz->descriptor, method->name, instrOffset); dvmAbort(); } else { - LOGW("Breakpoint was already restored? (%s.%s +0x%x)\n", + LOGW("Breakpoint was already restored? (%s.%s +0x%x)", method->clazz->descriptor, method->name, instrOffset); } } else { @@ -372,10 +372,10 @@ static void dvmBreakpointSetFlush(BreakpointSet* pSet, ClassObject* clazz) * It might already be there or it might not; either way, * flush it out. */ - LOGV("Flushing breakpoint at %p for %s\n", + LOGV("Flushing breakpoint at %p for %s", pBreak->addr, clazz->descriptor); if (instructionIsMagicNop(pBreak->addr)) { - LOGV("Refusing to flush breakpoint on %04x at %s.%s + 0x%x\n", + LOGV("Refusing to flush breakpoint on %04x at %s.%s + 0x%x", *pBreak->addr, pBreak->method->clazz->descriptor, pBreak->method->name, pBreak->addr - pBreak->method->insns); } else { @@ -396,7 +396,7 @@ void dvmInitBreakpoints() BreakpointSet* pSet = gDvm.breakpointSet; dvmBreakpointSetLock(pSet); if (dvmBreakpointSetCount(pSet) != 0) { - LOGW("WARNING: %d leftover breakpoints\n", dvmBreakpointSetCount(pSet)); + LOGW("WARNING: %d leftover breakpoints", dvmBreakpointSetCount(pSet)); /* generally not good, but we can keep going */ } dvmBreakpointSetUnlock(pSet); @@ -462,7 +462,7 @@ u1 dvmGetOriginalOpcode(const u2* addr) if (!dvmBreakpointSetOriginalOpcode(pSet, addr, &orig)) { orig = *(u1*)addr; if (orig == OP_BREAKPOINT) { - LOGE("GLITCH: can't find breakpoint, opcode is still set\n"); + LOGE("GLITCH: can't find breakpoint, opcode is still set"); dvmAbort(); } } @@ -505,7 +505,7 @@ bool dvmAddSingleStep(Thread* thread, int size, int depth) StepControl* pCtrl = &gDvm.stepControl; if (pCtrl->active && thread != pCtrl->thread) { - LOGW("WARNING: single-step active for %p; adding %p\n", + LOGW("WARNING: single-step active for %p; adding %p", pCtrl->thread, thread); /* @@ -552,7 +552,7 @@ bool dvmAddSingleStep(Thread* thread, int size, int depth) prevFp = fp; } if (fp == NULL) { - LOGW("Unexpected: step req in native-only threadid=%d\n", + LOGW("Unexpected: step req in native-only threadid=%d", thread->threadId); return false; } @@ -562,7 +562,7 @@ bool dvmAddSingleStep(Thread* thread, int size, int depth) * frames are only inserted when calling from native->interp, so we * don't need to worry about one being here. */ - LOGV("##### init step while in native method\n"); + LOGV("##### init step while in native method"); fp = prevFp; assert(!dvmIsBreakFrame((u4*)fp)); assert(dvmIsNativeMethod(SAVEAREA_FROM_FP(fp)->method)); @@ -592,7 +592,7 @@ bool dvmAddSingleStep(Thread* thread, int size, int depth) dvmComputeVagueFrameDepth(thread, thread->interpSave.curFrame); pCtrl->active = true; - LOGV("##### step init: thread=%p meth=%p '%s' line=%d frameDepth=%d depth=%s size=%s\n", + LOGV("##### step init: thread=%p meth=%p '%s' line=%d frameDepth=%d depth=%s size=%s", pCtrl->thread, pCtrl->method, pCtrl->method->name, pCtrl->line, pCtrl->frameDepth, dvmJdwpStepDepthStr(pCtrl->depth), @@ -754,7 +754,7 @@ static void updateDebugger(const Method* method, const u2* pc, const u4* fp, * we may or may not actually send a message to the debugger. */ if (GET_OPCODE(*pc) == OP_BREAKPOINT) { - LOGV("+++ breakpoint hit at %p\n", pc); + LOGV("+++ breakpoint hit at %p", pc); eventFlags |= DBG_BREAKPOINT; } @@ -829,7 +829,7 @@ static void updateDebugger(const Method* method, const u2* pc, const u4* fp, } if (doStop) { - LOGV("#####S %s\n", msg); + LOGV("#####S %s", msg); eventFlags |= DBG_SINGLE_STEP; } } @@ -865,7 +865,7 @@ static void updateDebugger(const Method* method, const u2* pc, const u4* fp, * during single-step. */ char* desc = dexProtoCopyMethodDescriptor(&method->prototype); - LOGE("HEY: invalid 'this' ptr %p (%s.%s %s)\n", thisPtr, + LOGE("HEY: invalid 'this' ptr %p (%s.%s %s)", thisPtr, method->clazz->descriptor, method->name, desc); free(desc); dvmAbort(); @@ -920,15 +920,15 @@ void dvmInterpCheckTrackedRefs(Thread* self, const Method* method, count = dvmReferenceTableEntries(&self->internalLocalRefTable); - LOGE("TRACK: unreleased internal reference (prev=%d total=%d)\n", + LOGE("TRACK: unreleased internal reference (prev=%d total=%d)", debugTrackedRefStart, count); desc = dexProtoCopyMethodDescriptor(&method->prototype); - LOGE(" current method is %s.%s %s\n", method->clazz->descriptor, + LOGE(" current method is %s.%s %s", method->clazz->descriptor, method->name, desc); free(desc); top = self->internalLocalRefTable.table + debugTrackedRefStart; while (top < self->internalLocalRefTable.nextEntry) { - LOGE(" %p (%s)\n", + LOGE(" %p (%s)", *top, ((*top)->clazz != NULL) ? (*top)->clazz->descriptor : ""); top++; @@ -937,7 +937,7 @@ void dvmInterpCheckTrackedRefs(Thread* self, const Method* method, dvmAbort(); } - //LOGI("TRACK OK\n"); + //LOGI("TRACK OK"); } #endif @@ -952,14 +952,14 @@ void dvmDumpRegs(const Method* method, const u4* framePtr, bool inOnly) localCount = method->registersSize - method->insSize; - LOG(LOG_VERBOSE, LOG_TAG"i", "Registers (fp=%p):\n", framePtr); + LOG(LOG_VERBOSE, LOG_TAG"i", "Registers (fp=%p):", framePtr); for (i = method->registersSize-1; i >= 0; i--) { if (i >= localCount) { - LOG(LOG_VERBOSE, LOG_TAG"i", " v%-2d in%-2d : 0x%08x\n", + LOG(LOG_VERBOSE, LOG_TAG"i", " v%-2d in%-2d : 0x%08x", i, i-localCount, framePtr[i]); } else { if (inOnly) { - LOG(LOG_VERBOSE, LOG_TAG"i", " [...]\n"); + LOG(LOG_VERBOSE, LOG_TAG"i", " [...]"); break; } const char* name = ""; @@ -976,7 +976,7 @@ void dvmDumpRegs(const Method* method, const u4* framePtr, bool inOnly) } } #endif - LOG(LOG_VERBOSE, LOG_TAG"i", " v%-2d : 0x%08x %s\n", + LOG(LOG_VERBOSE, LOG_TAG"i", " v%-2d : 0x%08x %s", i, framePtr[i], name); } } @@ -1043,7 +1043,7 @@ s4 dvmInterpHandlePackedSwitch(const u2* switchData, s4 testVal) firstKey |= (*switchData++) << 16; if (testVal < firstKey || testVal >= firstKey + size) { - LOGVV("Value %d not found in switch (%d-%d)\n", + LOGVV("Value %d not found in switch (%d-%d)", testVal, firstKey, firstKey+size-1); return kInstrLen; } @@ -1055,7 +1055,7 @@ s4 dvmInterpHandlePackedSwitch(const u2* switchData, s4 testVal) assert(((u4)entries & 0x3) == 0); assert(testVal - firstKey >= 0 && testVal - firstKey < size); - LOGVV("Value %d found in slot %d (goto 0x%02x)\n", + LOGVV("Value %d found in slot %d (goto 0x%02x)", testVal, testVal - firstKey, s4FromSwitchData(&entries[testVal - firstKey])); return s4FromSwitchData(&entries[testVal - firstKey]); @@ -1120,13 +1120,13 @@ s4 dvmInterpHandleSparseSwitch(const u2* switchData, s4 testVal) } else if (testVal > foundVal) { lo = mid + 1; } else { - LOGVV("Value %d found in entry %d (goto 0x%02x)\n", + LOGVV("Value %d found in entry %d (goto 0x%02x)", testVal, mid, s4FromSwitchData(&entries[mid])); return s4FromSwitchData(&entries[mid]); } } - LOGVV("Value %d not found in switch\n", testVal); + LOGVV("Value %d not found in switch", testVal); return kInstrLen; } @@ -1179,7 +1179,7 @@ static void copySwappedArrayData(void* dest, const u2* src, u4 size, u2 width) } break; default: - LOGE("Unexpected width %d in copySwappedArrayData\n", width); + LOGE("Unexpected width %d in copySwappedArrayData", width); dvmAbort(); break; } @@ -1251,7 +1251,7 @@ Method* dvmInterpFindInterfaceMethod(ClassObject* thisClass, u4 methodIdx, if (absMethod == NULL) { absMethod = dvmResolveInterfaceMethod(method->clazz, methodIdx); if (absMethod == NULL) { - LOGV("+ unknown method\n"); + LOGV("+ unknown method"); return NULL; } } @@ -1298,7 +1298,7 @@ Method* dvmInterpFindInterfaceMethod(ClassObject* thisClass, u4 methodIdx, methodToCall->nativeFunc != NULL); #endif - LOGVV("+++ interface=%s.%s concrete=%s.%s\n", + LOGVV("+++ interface=%s.%s concrete=%s.%s", absMethod->clazz->descriptor, absMethod->name, methodToCall->clazz->descriptor, methodToCall->name); assert(methodToCall != NULL); @@ -1361,7 +1361,7 @@ static char* fieldNameFromIndex(const Method* method, int ref, const char* fieldName; if (refType != VERIFY_ERROR_REF_FIELD) { - LOGW("Expected ref type %d, got %d\n", VERIFY_ERROR_REF_FIELD, refType); + LOGW("Expected ref type %d, got %d", VERIFY_ERROR_REF_FIELD, refType); return NULL; /* no message */ } @@ -1395,7 +1395,7 @@ static char* methodNameFromIndex(const Method* method, int ref, const char* methodName; if (refType != VERIFY_ERROR_REF_METHOD) { - LOGW("Expected ref type %d, got %d\n", VERIFY_ERROR_REF_METHOD,refType); + LOGW("Expected ref type %d, got %d", VERIFY_ERROR_REF_METHOD,refType); return NULL; /* no message */ } @@ -1743,7 +1743,7 @@ void dvmCheckBefore(const u2 *pc, u4 *fp, Thread* self) strcmp(method->name, mn) == 0 && strcmp(method->shorty, sg) == 0) { - LOGW("Reached %s.%s, enabling verbose mode\n", + LOGW("Reached %s.%s, enabling verbose mode", method->clazz->descriptor, method->name); android_setMinPriority(LOG_TAG"i", ANDROID_LOG_VERBOSE); dumpRegs(method, fp, true); @@ -1964,7 +1964,7 @@ void dvmInterpret(Thread* self, const Method* method, JValue* pResult) if (method->clazz->status < CLASS_INITIALIZING || method->clazz->status == CLASS_ERROR) { - LOGE("ERROR: tried to execute code in unprepared class '%s' (%d)\n", + LOGE("ERROR: tried to execute code in unprepared class '%s' (%d)", method->clazz->descriptor, method->clazz->status); dvmDumpThread(self, false); dvmAbort(); diff --git a/vm/interp/Stack.cpp b/vm/interp/Stack.cpp index c65a78e13..9f6c1cf7a 100644 --- a/vm/interp/Stack.cpp +++ b/vm/interp/Stack.cpp @@ -114,7 +114,7 @@ static bool dvmPushInterpFrame(Thread* self, const Method* method) saveBlock->xtra.currentPc = NULL; // not required? saveBlock->method = method; - LOGVV("PUSH frame: old=%p new=%p (size=%d)\n", + LOGVV("PUSH frame: old=%p new=%p (size=%d)", self->interpSave.curFrame, FP_FROM_SAVEAREA(saveBlock), (u1*)self->interpSave.curFrame - (u1*)FP_FROM_SAVEAREA(saveBlock)); @@ -193,7 +193,7 @@ bool dvmPushJNIFrame(Thread* self, const Method* method) saveBlock->xtra.localRefCookie = self->jniLocalRefTable.segmentState.all; saveBlock->method = method; - LOGVV("PUSH JNI frame: old=%p new=%p (size=%d)\n", + LOGVV("PUSH JNI frame: old=%p new=%p (size=%d)", self->interpSave.curFrame, FP_FROM_SAVEAREA(saveBlock), (u1*)self->interpSave.curFrame - (u1*)FP_FROM_SAVEAREA(saveBlock)); @@ -253,7 +253,7 @@ bool dvmPushLocalFrame(Thread* self, const Method* method) saveBlock->xtra.localRefCookie = self->jniLocalRefTable.segmentState.all; saveBlock->method = method; - LOGVV("PUSH JNI local frame: old=%p new=%p (size=%d)\n", + LOGVV("PUSH JNI local frame: old=%p new=%p (size=%d)", self->interpSave.curFrame, FP_FROM_SAVEAREA(saveBlock), (u1*)self->interpSave.curFrame - (u1*)FP_FROM_SAVEAREA(saveBlock)); @@ -284,7 +284,7 @@ bool dvmPopLocalFrame(Thread* self) return false; } - LOGVV("POP JNI local frame: removing %s, now %s\n", + LOGVV("POP JNI local frame: removing %s, now %s", saveBlock->method->name, SAVEAREA_FROM_FP(saveBlock->prevFrame)->method->name); dvmPopJniLocals(self, saveBlock); @@ -320,7 +320,7 @@ static bool dvmPopFrame(Thread* self) /* probably a native->native JNI call */ if (dvmIsNativeMethod(saveBlock->method)) { - LOGVV("Popping JNI stack frame for %s.%s%s\n", + LOGVV("Popping JNI stack frame for %s.%s%s", saveBlock->method->clazz->descriptor, saveBlock->method->name, (SAVEAREA_FROM_FP(saveBlock->prevFrame)->method == NULL) ? @@ -331,12 +331,12 @@ static bool dvmPopFrame(Thread* self) saveBlock = SAVEAREA_FROM_FP(saveBlock->prevFrame); } if (saveBlock->method != NULL) { - LOGE("PopFrame missed the break\n"); + LOGE("PopFrame missed the break"); assert(false); dvmAbort(); // stack trashed -- nowhere to go in this thread } - LOGVV("POP frame: cur=%p new=%p\n", + LOGVV("POP frame: cur=%p new=%p", self->interpSave.curFrame, saveBlock->prevFrame); self->interpSave.curFrame = saveBlock->prevFrame; @@ -355,7 +355,7 @@ static ClassObject* callPrep(Thread* self, const Method* method, Object* obj, #ifndef NDEBUG if (self->status != THREAD_RUNNING) { - LOGW("threadid=%d: status=%d on call to %s.%s -\n", + LOGW("threadid=%d: status=%d on call to %s.%s -", self->threadId, self->status, method->clazz->descriptor, method->name); } @@ -371,7 +371,7 @@ static ClassObject* callPrep(Thread* self, const Method* method, Object* obj, IF_LOGVV() { char* desc = dexProtoCopyMethodDescriptor(&method->prototype); - LOGVV("thread=%d native code calling %s.%s %s\n", self->threadId, + LOGVV("thread=%d native code calling %s.%s %s", self->threadId, clazz->descriptor, method->name, desc); free(desc); } @@ -451,7 +451,7 @@ void dvmCallMethodV(Thread* self, const Method* method, Object* obj, ins = ((u4*)self->interpSave.curFrame) + (method->registersSize - method->insSize); - //LOGD(" FP is %p, INs live at >= %p\n", self->interpSave.curFrame, ins); + //LOGD(" FP is %p, INs live at >= %p", self->interpSave.curFrame, ins); /* put "this" pointer into in0 if appropriate */ if (!dvmIsStaticMethod(method)) { @@ -501,7 +501,7 @@ void dvmCallMethodV(Thread* self, const Method* method, Object* obj, #ifndef NDEBUG if (verifyCount != method->insSize) { - LOGE("Got vfycount=%d insSize=%d for %s.%s\n", verifyCount, + LOGE("Got vfycount=%d insSize=%d for %s.%s", verifyCount, method->insSize, clazz->descriptor, method->name); assert(false); goto bail; @@ -597,7 +597,7 @@ void dvmCallMethodA(Thread* self, const Method* method, Object* obj, *ins++ = args->z; /* 8 bits, zero or non-zero */ break; default: - LOGE("Invalid char %c in short signature of %s.%s\n", + LOGE("Invalid char %c in short signature of %s.%s", *(desc-1), clazz->descriptor, method->name); assert(false); goto bail; @@ -609,7 +609,7 @@ void dvmCallMethodA(Thread* self, const Method* method, Object* obj, #ifndef NDEBUG if (verifyCount != method->insSize) { - LOGE("Got vfycount=%d insSize=%d for %s.%s\n", verifyCount, + LOGE("Got vfycount=%d insSize=%d for %s.%s", verifyCount, method->insSize, clazz->descriptor, method->name); assert(false); goto bail; @@ -692,7 +692,7 @@ Object* dvmInvokeMethod(Object* obj, const Method* method, (method->registersSize - method->insSize); verifyCount = 0; - //LOGD(" FP is %p, INs live at >= %p\n", self->interpSave.curFrame, ins); + //LOGD(" FP is %p, INs live at >= %p", self->interpSave.curFrame, ins); /* put "this" pointer into in0 if appropriate */ if (!dvmIsStaticMethod(method)) { @@ -722,7 +722,7 @@ Object* dvmInvokeMethod(Object* obj, const Method* method, #ifndef NDEBUG if (verifyCount != method->insSize) { - LOGE("Got vfycount=%d insSize=%d for %s.%s\n", verifyCount, + LOGE("Got vfycount=%d insSize=%d for %s.%s", verifyCount, method->insSize, clazz->descriptor, method->name); assert(false); goto bail; @@ -1012,22 +1012,22 @@ void dvmHandleStackOverflow(Thread* self, const Method* method) /* * Already did, nothing to do but bail. */ - LOGE("DalvikVM: double-overflow of stack in threadid=%d; aborting\n", + LOGE("DalvikVM: double-overflow of stack in threadid=%d; aborting", self->threadId); dvmDumpThread(self, false); dvmAbort(); } /* open it up to the full range */ - LOGI("threadid=%d: stack overflow on call to %s.%s:%s\n", + LOGI("threadid=%d: stack overflow on call to %s.%s:%s", self->threadId, method->clazz->descriptor, method->name, method->shorty); StackSaveArea* saveArea = SAVEAREA_FROM_FP(self->interpSave.curFrame); - LOGI(" method requires %d+%d+%d=%d bytes, fp is %p (%d left)\n", + LOGI(" method requires %d+%d+%d=%d bytes, fp is %p (%d left)", method->registersSize * 4, sizeof(StackSaveArea), method->outsSize * 4, (method->registersSize + method->outsSize) * 4 + sizeof(StackSaveArea), saveArea, (u1*) saveArea - self->interpStackEnd); - LOGI(" expanding stack end (%p to %p)\n", self->interpStackEnd, + LOGI(" expanding stack end (%p to %p)", self->interpStackEnd, self->interpStackStart - self->interpStackSize); //dvmDumpThread(self, false); self->interpStackEnd = self->interpStackStart - self->interpStackSize; @@ -1041,7 +1041,7 @@ void dvmHandleStackOverflow(Thread* self, const Method* method) */ Object* excep = dvmGetException(self); if (excep != NULL) { - LOGW("Stack overflow while throwing exception\n"); + LOGW("Stack overflow while throwing exception"); dvmClearException(self); } dvmThrowChainedException(gDvm.exStackOverflowError, NULL, excep); @@ -1065,7 +1065,7 @@ void dvmCleanupStackOverflow(Thread* self, const Object* exception) newStackEnd = (self->interpStackStart - self->interpStackSize) + STACK_OVERFLOW_RESERVE; if ((u1*)self->interpSave.curFrame <= newStackEnd) { - LOGE("Can't shrink stack: curFrame is in reserved area (%p %p)\n", + LOGE("Can't shrink stack: curFrame is in reserved area (%p %p)", self->interpStackEnd, self->interpSave.curFrame); dvmDumpThread(self, false); dvmAbort(); @@ -1074,7 +1074,7 @@ void dvmCleanupStackOverflow(Thread* self, const Object* exception) self->interpStackEnd = newStackEnd; self->stackOverflowed = false; - LOGI("Shrank stack (to %p, curFrame is %p)\n", self->interpStackEnd, + LOGI("Shrank stack (to %p, curFrame is %p)", self->interpStackEnd, self->interpSave.curFrame); } @@ -1105,7 +1105,7 @@ static bool extractMonitorEnterObject(Thread* thread, Object** pLockObj, /* check Method* */ if (!dvmLinearAllocContains(method, sizeof(Method))) { - LOGD("ExtrMon: method %p not valid\n", method); + LOGD("ExtrMon: method %p not valid", method); return false; } @@ -1114,14 +1114,14 @@ static bool extractMonitorEnterObject(Thread* thread, Object** pLockObj, if (currentPc < method->insns || currentPc >= method->insns + insnsSize) { - LOGD("ExtrMon: insns %p not valid (%p - %p)\n", + LOGD("ExtrMon: insns %p not valid (%p - %p)", currentPc, method->insns, method->insns + insnsSize); return false; } /* check the instruction */ if ((*currentPc & 0xff) != OP_MONITOR_ENTER) { - LOGD("ExtrMon: insn at %p is not monitor-enter (0x%02x)\n", + LOGD("ExtrMon: insn at %p is not monitor-enter (0x%02x)", currentPc, *currentPc & 0xff); return false; } @@ -1129,7 +1129,7 @@ static bool extractMonitorEnterObject(Thread* thread, Object** pLockObj, /* get and check the register index */ unsigned int reg = *currentPc >> 8; if (reg >= method->registersSize) { - LOGD("ExtrMon: invalid register %d (max %d)\n", + LOGD("ExtrMon: invalid register %d (max %d)", reg, method->registersSize); return false; } @@ -1138,7 +1138,7 @@ static bool extractMonitorEnterObject(Thread* thread, Object** pLockObj, u4* fp = (u4*) framePtr; Object* obj = (Object*) fp[reg]; if (!dvmIsValidObject(obj)) { - LOGD("ExtrMon: invalid object %p at %p[%d]\n", obj, fp, reg); + LOGD("ExtrMon: invalid object %p at %p[%d]", obj, fp, reg); return false; } *pLockObj = obj; @@ -1288,7 +1288,7 @@ static void dumpFrames(const DebugOutputTarget* target, void* framePtr, first = false; if (saveArea->prevFrame != NULL && saveArea->prevFrame <= framePtr) { - LOGW("Warning: loop in stack trace at frame %d (%p -> %p)\n", + LOGW("Warning: loop in stack trace at frame %d (%p -> %p)", checkCount, framePtr, saveArea->prevFrame); break; } @@ -1358,7 +1358,7 @@ void dvmDumpRunningThreadStack(const DebugOutputTarget* target, Thread* thread) /* * Run through the stack and rewrite the "prev" pointers. */ - //LOGI("DR: fpOff=%d (from %p %p)\n",fpOffset, origStack, + //LOGI("DR: fpOff=%d (from %p %p)",fpOffset, origStack, // thread->interpSave.curFrame); fp = stackCopy + fpOffset; while (true) { |