diff options
| author | Andy McFadden <fadden@android.com> | 2009-10-28 17:39:02 -0700 |
|---|---|---|
| committer | Andy McFadden <fadden@android.com> | 2009-11-16 12:37:25 -0800 |
| commit | 96516932f1557d8f48a8b2dbbb885af01a11ef6e (patch) | |
| tree | a4bac9fd87ab5e88dfaaa92c84d99b6195fdc0fe /vm/LinearAlloc.h | |
| parent | 62beb8b347e9e578de1844d56ce08f1d536e9c28 (diff) | |
| download | android_dalvik-96516932f1557d8f48a8b2dbbb885af01a11ef6e.tar.gz android_dalvik-96516932f1557d8f48a8b2dbbb885af01a11ef6e.tar.bz2 android_dalvik-96516932f1557d8f48a8b2dbbb885af01a11ef6e.zip | |
Change the way breakpoints work.
This replaces the breakpoint mechanism with a more efficient approach.
We now insert breakpoint instructions into the bytecode stream instead of
maintaining a table. This requires mapping DEX files as private instead
of shared, which allows copy-on-write to work. mprotect() is used to
guard the pages against inadvertent writes.
Unused opcode EC is now OP_BREAKPOINT. It's not recognized by dexdump or
any interpreter except portdbg, but it can be encountered by the bytecode
verifier (the debugger can request breakpoints in unverified code).
Breakpoint changes are blocked while the verifier runs to avoid races.
This eliminates method->debugBreakpointCount, which is no longer needed.
(Also, it clashed with LinearAlloc's read-only mode.)
The deferred verification error mechanism was using a code-copying
approach to modify the bytecode stream. That has been changed to use
the same copy-on-write modification mechanism.
Also, normalized all PAGE_SIZE/PAGESIZE references to a single
SYSTEM_PAGE_SIZE define.
Simple Fibonacci computation test times (opal-eng):
JIT, no debugger: 10.6ms
Fast interp, no debugger: 36ms
Portable interp, no debugger: 43.8ms
ORIG debug interp, no breakpoints set: 458ms
ORIG debug interp, breakpoint set nearby: 697ms
NEW debug interp, no breakpoints set: 341ms
NEW debug interp, breakpoints set nearby: 341ms
Where "nearby" means there's a breakpoint in the method doing the
computation that isn't actually hit -- the VM had an optimization where
it flagged methods with breakpoints and skipped some of the processing
when possible.
The bottom line is that code should run noticeably faster while a
debugger is attached.
Diffstat (limited to 'vm/LinearAlloc.h')
| -rw-r--r-- | vm/LinearAlloc.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/vm/LinearAlloc.h b/vm/LinearAlloc.h index a390ee37e..aa33fe1fc 100644 --- a/vm/LinearAlloc.h +++ b/vm/LinearAlloc.h @@ -22,7 +22,6 @@ /* * If this is set, we create additional data structures and make many * additional mprotect() calls. - * (this breaks the debugger because the debugBreakpointCount cannot be updated) */ #define ENFORCE_READ_ONLY false |