diff options
author | Fumitoshi Ukai <fumitoshi.ukai@gmail.com> | 2015-04-30 10:20:18 +0900 |
---|---|---|
committer | Fumitoshi Ukai <fumitoshi.ukai@gmail.com> | 2015-04-30 13:25:12 +0900 |
commit | 0b9e8132b64a22fb037313dcbecd8d84a9d3689a (patch) | |
tree | 7cc36fb73cbd63caaaeb4ff348cb69c267be8907 /eval.go | |
parent | 89215d0641e70f9b0e31af0c7f52e181d4a0a20f (diff) | |
download | android_build_kati-0b9e8132b64a22fb037313dcbecd8d84a9d3689a.tar.gz android_build_kati-0b9e8132b64a22fb037313dcbecd8d84a9d3689a.tar.bz2 android_build_kati-0b9e8132b64a22fb037313dcbecd8d84a9d3689a.zip |
rule_parser uses []byte
intern target names: share the same string as much as possible.
$ ./repo/android.sh time kati -c -kati_memstats='alloc={{.Alloc}},total={{.TotalAlloc}},sys={{.Sys}},malloc={{.Mallocs}},free={{.Frees}},heap idle={{.HeapIdle}},inuse={{.HeapInuse}},released={{.HeapReleased}},pause={{.PauseTotalNs}},numGC={{.NumGC}}'
...
alloc=686232544,total=9471977912,sys=990856408,malloc=204647708,free=200142535,heap idle=5914624,inuse=909885440,released=0,pause=10103883229,numGC=341
Diffstat (limited to 'eval.go')
-rw-r--r-- | eval.go | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -152,7 +152,7 @@ func (ev *Evaluator) evalMaybeRule(ast *MaybeRuleAST) { filename: ast.filename, lineno: ast.lineno, } - assign, err := rule.parse(string(line)) // use []byte? + assign, err := rule.parse(line) if err != nil { Error(ast.filename, ast.lineno, "%v", err.Error()) } @@ -168,7 +168,7 @@ func (ev *Evaluator) evalMaybeRule(ast *MaybeRuleAST) { if err != nil { panic(fmt.Errorf("parse %s:%d %v", ev.filename, ev.lineno, err)) } - assign, err = rule.parse(string(ev.Value(lexpr))) + assign, err = rule.parse(ev.Value(lexpr)) if err != nil { Error(ast.filename, ast.lineno, "%v", err.Error()) } |