Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix over read in strcpy/stpcpy/strcat. | Christopher Ferris | 2015-09-24 | 1 | -6/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | This bug will happen when these circumstances are met: - Destination address & 0x7 == 1, strlen of src is 11, 12, 13. - Destination address & 0x7 == 2, strlen of src is 10, 11, 12. - Destination address & 0x7 == 3, strlen of src is 9, 10, 11. - Destination address & 0x7 == 4, strlen of src is 8, 9, 10. In these cases, the dest alignment code does a ldr which reads 4 bytes, and it will read past the end of the source. In most cases, this is probably benign, but if this crosses into a new page it could cause a crash. Fix the labels in the cortex-a9 strcat. Modify the overread test to vary the dst alignment to expost this bug. Also, shrink the strcat/strlcat overread cases since the dst alignment variation increases the runtime too much. Bug: 24345899 Change-Id: Ib34a559bfcebd89861985b29cae6c1e47b5b5855 | ||||
* | Use delete[] to de-allocate pointers from new[] | Pirama Arumuga Nainar | 2015-07-09 | 1 | -6/+6 |
| | | | | | | | | | Upstream clang has a new diagnostic, '-Wmismatched-new-delete' to generate a warning (that becomes an error with -Werror) when delete is used to deallocate pointers created with 'new[]'. This patch fixes 'delete's that trigger this warning/error. Change-Id: Id7b6f6c2df3e860e576de55e2f61f3d2be3a3986 | ||||
* | Add strcmp/memcmp testing. | Christopher Ferris | 2013-12-03 | 1 | -6/+113 |
| | | | | | Bug: 9797008 Change-Id: I11b1da060d29f7dacbb53f20a3e2082395b5bd8a | ||||
* | Add new tests for memory/string routines. | Christopher Ferris | 2013-11-15 | 1 | -0/+341 |
Create a few generic testing functions to allow any memory/string tests to be created. Add alignment tests for memcpy/memset/strcat/strcpy/strlen. Add an overread test for memcpy/strcat/strcpy/strlen. This test attempts to verify that the functions do not read past the end of their buffers (src buffer in the case of src/dst functions). Bug: 9797008 Change-Id: Ib3223ca1b99e729ae8229adc2d03f4dc3103d97c |