diff options
| author | Ryan Prichard <rprichard@google.com> | 2019-01-25 16:14:31 -0800 |
|---|---|---|
| committer | Ryan Prichard <rprichard@google.com> | 2019-01-25 17:53:01 -0800 |
| commit | 5f5a1929e8bd883c79669dc5dd2348d9cec1d1a6 (patch) | |
| tree | 9bcd21c4e14268e538c2728474ae48b222020b33 /tests/dlfcn_test.cpp | |
| parent | 96773a2daf8d11f2d95801935e26f71eb0265559 (diff) | |
| download | android_bionic-5f5a1929e8bd883c79669dc5dd2348d9cec1d1a6.tar.gz android_bionic-5f5a1929e8bd883c79669dc5dd2348d9cec1d1a6.tar.bz2 android_bionic-5f5a1929e8bd883c79669dc5dd2348d9cec1d1a6.zip | |
Disable the dlfcn.dlopen_library_with_ELF_TLS test
This test is verifying that an ELF TLS solib can't be loaded, but once
ELF TLS is implemented, it *can* be loaded. Removing the test requires
coordinated changes with internal test suites.
I could modify the test to verify that the solib was successfully loaded,
but support for dynamic ELF TLS appears across a few different CLs.
Bug: http://b/78026329
Test: bionic unit tests
Change-Id: If8cd798f456568a5c76310b754cea48ca8edaa82
Diffstat (limited to 'tests/dlfcn_test.cpp')
| -rw-r--r-- | tests/dlfcn_test.cpp | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/tests/dlfcn_test.cpp b/tests/dlfcn_test.cpp index 176a6f809..e3ba22718 100644 --- a/tests/dlfcn_test.cpp +++ b/tests/dlfcn_test.cpp @@ -1083,10 +1083,16 @@ TEST(dlfcn, dlopen_library_with_only_sysv_hash) { } TEST(dlfcn, dlopen_library_with_ELF_TLS) { +// TODO: Remove this test. Once ELF TLS is implemented, this test will be +// replaced with a larger set of tests. Removing the test requires matching CLs +// in CTS and in internal test suites. +#if 0 dlerror(); // Clear any pending errors. void* handle = dlopen("libelf-tls-library.so", RTLD_NOW); ASSERT_TRUE(handle == nullptr); ASSERT_SUBSTR("unknown reloc type ", dlerror()); +#endif + GTEST_LOG_(INFO) << "This test is disabled pending replacement with dynamic ELF TLS tests.\n"; } TEST(dlfcn, dlopen_bad_flags) { |