platform_tools_base/bazel/coverage, branch studio-master-dev Unnamed repository; edit this file 'description' to name the repository. Add coverage target for parallel device test report. 2020-05-19T18:08:50+00:00 Arif Sukoco arifs@google.com 2020-05-18T19:07:04+00:00 8532277e4d6535d3323e8214971961d578043e20 Test: manually run coverage/report.sh Bug: None Change-Id: I9c7cc1cbb04624dc683c22bab2017272a770ec38 
Test: manually run coverage/report.sh
Bug: None

Change-Id: I9c7cc1cbb04624dc683c22bab2017272a770ec38
Prune coverage master ignore list to only necessary items 2020-05-08T06:24:38+00:00 Eric Reed ericreed@google.com 2020-05-05T23:18:07+00:00 810b499a1dc7ccfe054c584cbbec5fe8b65518b9 The use of baseline sources takes care of a lot of filtering for us (test code/data, external projects that don't use our custom rules, etc). This lets us drop a lot from the master filter without changing what is filtered in practice. Test: Checked that filtered merged baseline sources is the same Bug: 153913236 Change-Id: I107b625db373f2cd5db49a62d90e18bdc6b343d7 
The use of baseline sources takes care of a lot of filtering for us
(test code/data, external projects that don't use our custom rules,
etc). This lets us drop a lot from the master filter without changing
what is filtered in practice.

Test: Checked that filtered merged baseline sources is the same
Bug: 153913236
Change-Id: I107b625db373f2cd5db49a62d90e18bdc6b343d7
Merge baseline LCOV and use in all coverage reports 2020-05-08T04:35:50+00:00 Eric Reed ericreed@google.com 2020-05-03T04:36:45+00:00 fa50dc42616906ce28dc667184fda538725f3830 Merge all individual baseline LCOVs into a single baseline LCOV, which then is used as an additional input to all coverage report definitions. This ensures that all coverage eligible files that meet the include/exclude rules of a coverage report definition are actually included in the report. Previously if some file was eligible, but never actually touched by a test then it would be omitted due to lack of data. With this change, such omissions will be detected and included in the report as a file with zero coverage. Change-Id: I1a4b14ebf8f75e342786cb7917e3503d4e95207e Test: N/A Bug: 153913236 
Merge all individual baseline LCOVs into a single baseline LCOV, which
then is used as an additional input to all coverage report definitions.

This ensures that all coverage eligible files that meet the
include/exclude rules of a coverage report definition are actually
included in the report. Previously if some file was eligible, but never
actually touched by a test then it would be omitted due to lack of data.
With this change, such omissions will be detected and included in the
report as a file with zero coverage.

Change-Id: I1a4b14ebf8f75e342786cb7917e3503d4e95207e
Test: N/A
Bug: 153913236
Use baseline filelist in results XML->LCOV conversion step 2020-05-08T01:26:04+00:00 Eric Reed ericreed@google.com 2020-05-03T03:44:46+00:00 d9b73406660e6abf6c13cee1f68506bc124d418f This removes the master ignore list logic from the XML-LCOV conversion ending the earlier duplication. Now the converter is provided a list of coverage eligible files and drops any data from ineligible files. As a side bonus, this enables the converter to run remotely removing the local execution bottleneck that previously slowed down coverage post-processing. Test: N/A Bug: 153913236 Change-Id: I254a74a6ba33fb5cbfa28f7b22af027d220c5481 
This removes the master ignore list logic from the XML-LCOV conversion
ending the earlier duplication. Now the converter is provided a list of
coverage eligible files and drops any data from ineligible files.

As a side bonus, this enables the converter to run remotely removing the
local execution bottleneck that previously slowed down coverage
post-processing.

Test: N/A
Bug: 153913236
Change-Id: I254a74a6ba33fb5cbfa28f7b22af027d220c5481
Revert Change Ic17e5fdd 2020-05-08T01:00:00+00:00 Dana Dahlstrom dahlstrom@google.com 2020-05-08T00:00:00+00:00 3188ccc2ab9fea5e0abd5f47cec5f57b390b2f43 … following Change Ibbb7f1e0. Change-Id: Ie50e05f32f7e66a63498fc10c901416a57a2d7bd Issue: 155929139 
… following Change Ibbb7f1e0.

Change-Id: Ie50e05f32f7e66a63498fc10c901416a57a2d7bd
Issue: 155929139
Find and merge all baseline coverage sourcefile lists 2020-05-08T00:18:19+00:00 Eric Reed ericreed@google.com 2020-05-03T05:59:52+00:00 51157d603c2bceda3863d6464d2c7c095fcfa5c2 Uses the WORKSPACE loop trick to find all baseline source file targets by looking for their ourput and constructs the merger rule with all the rules as the sources. We cannot express such a dependency in Starlark normally due to a mix of factors (no wildcards in BUILD files prevents using a genquery to find the rules and even if we could do that we couldn't use the output file to populate the `srcs` of a genrule anyway). However, by using a WORKSPACE loop into `bazel-bin` to glob for files that look like the rule outputs we can identify all the rules and construct the merger genrule correctly. The downside is that we need to do a targeted remove of the rule outputs to ensure we don't pick up anything from deleted targets, but we can mechanically enforce that in both places we invoke coverage processing (tools/base/bazel/studio_coverage.sh and tools/base/bazel/coverage/report.sh). This is similar to using a script to construct a BUILD file and then invoking a target in that BUILD file, but this method does not pollute the workspace filetree. Change-Id: I7132af7aea7f8b2a65b393801ca7962453cd02a9 Test: N/A Bug: 153913236 
Uses the WORKSPACE loop trick to find all baseline source file targets
by looking for their ourput and constructs the merger rule with all
the rules as the sources.

We cannot express such a dependency in Starlark normally due to a mix of
factors (no wildcards in BUILD files prevents using a genquery to find
the rules and even if we could do that we couldn't use the output file
to populate the `srcs` of a genrule anyway).
However, by using a WORKSPACE loop into `bazel-bin` to glob for files
that look like the rule outputs we can identify all the rules and
construct the merger genrule correctly.
The downside is that we need to do a targeted remove of the
rule outputs to ensure we don't pick up anything from deleted targets,
but we can mechanically enforce that in both places we invoke coverage
processing (tools/base/bazel/studio_coverage.sh and
tools/base/bazel/coverage/report.sh).

This is similar to using a script to construct a BUILD file and then
invoking a target in that BUILD file, but this method does not pollute
the workspace filetree.

Change-Id: I7132af7aea7f8b2a65b393801ca7962453cd02a9
Test: N/A
Bug: 153913236
Duplicate coverage master ignore logic into standalone filter 2020-05-07T23:23:18+00:00 Eric Reed ericreed@google.com 2020-05-03T03:39:05+00:00 e7c0e4bf64511c4319994f84385045471c887b8c This lets us use the master ignore list in other places (specifically for baseline coverage). This is just a temporary duplication. The logic in the XML->LCOV conveter will be removed in the course of the baseline coverage integration. I'm just splitting it out like this to make following the process across the commit chain easier. Test: N/A Bug: 153913236 Change-Id: Ic0f9f85c1aefa992f60b3a2e07a3dddf10a227af 
This lets us use the master ignore list in other places (specifically
for baseline coverage). This is just a temporary duplication. The logic
in the XML->LCOV conveter will be removed in the course of the baseline
coverage integration. I'm just splitting it out like this to make
following the process across the commit chain easier.

Test: N/A
Bug: 153913236
Change-Id: Ic0f9f85c1aefa992f60b3a2e07a3dddf10a227af
Remove failing android-ndk_tests 2020-05-07T03:00:00+00:00 Dana Dahlstrom dahlstrom@google.com 2020-05-07T02:00:00+00:00 e50e05f32f7e66a63498fc10c901416a57a2d7bd Change-Id: Ic17e5fdd934e2ca1de8e90577bf4010981b088ae Issue: 155929139 
Change-Id: Ic17e5fdd934e2ca1de8e90577bf4010981b088ae
Issue: 155929139
Add test tags to coverage data in results processing 2020-05-06T00:15:50+00:00 Eric Reed ericreed@google.com 2020-03-14T00:53:51+00:00 b63973ff9e491bdf089e75e084ca25bb434d0719 Refactoring that splits lcov merger and test tagging functionality so that the merger function can be reused in other stages. Change-Id: Idb63a629a47c3c5dccc83214839acd7f6d98e0a3 Test: N/A Bug: 153913236 
Refactoring that splits lcov merger and test tagging functionality
so that the merger function can be reused in other stages.

Change-Id: Idb63a629a47c3c5dccc83214839acd7f6d98e0a3
Test: N/A
Bug: 153913236
Remove leading "./" in LCOV and master ignore list 2020-05-05T23:19:05+00:00 Eric Reed ericreed@google.com 2020-05-03T01:57:05+00:00 90359a4a03231ca19cf605eb8acc508d8fa616f7 This refactoring makes processing filepaths a bit simpler, which will help keep things cleaner when adding baseline coverage Test: N/A Bug: N/A Change-Id: I0924b6aba0fc488db0a08bddd2be5fa762bd2e5f 
This refactoring makes processing filepaths a bit simpler, which will
help keep things cleaner when adding baseline coverage

Test: N/A
Bug: N/A
Change-Id: I0924b6aba0fc488db0a08bddd2be5fa762bd2e5f