platform_system_libhwbinder/IPCThreadState.cpp, branch master-cuttlefish-testing-release Unnamed repository; edit this file 'description' to name the repository. Reland: "IPCThreadState: Add a public method to probe is a hwbinder 2018-10-01T22:54:05+00:00 Jayant Chowdhary jchowdhary@google.com 2018-10-01T22:54:05+00:00 985fc89c0c528426cd26025de91dfd5a3531e824 called is being served." This reverts commit cc986a68b919f0ad8c624b5898d918a7930efffc. Reason for revert: Dependencies which broke tests due to exclusion from LOCAL_JNI_SHARED_LIBS have been added. Change-Id: Iab2d8c65088744812301d980881a45ac2b119d0c 
         called is being served."

This reverts commit cc986a68b919f0ad8c624b5898d918a7930efffc.

Reason for revert: Dependencies which broke tests due to exclusion from 
                   LOCAL_JNI_SHARED_LIBS have been added.

Change-Id: Iab2d8c65088744812301d980881a45ac2b119d0c
Revert "IPCThreadState: Add a public method to probe is a hwbinder called is being served." 2018-09-28T07:48:47+00:00 Remi NGUYEN VAN reminv@google.com 2018-09-28T07:48:47+00:00 cc986a68b919f0ad8c624b5898d918a7930efffc This reverts commit b178762cf7a93842de56fa0d7a153e0694543821. Reason for revert: This breaks framework tests and blocks presubmit Change-Id: I9546c267d14390684f488542e92d7ac64c612488 
This reverts commit b178762cf7a93842de56fa0d7a153e0694543821.

Reason for revert: This breaks framework tests and blocks presubmit

Change-Id: I9546c267d14390684f488542e92d7ac64c612488
IPCThreadState: Add a public method to probe is a hwbinder called is being served. 2018-09-26T19:40:26+00:00 Jayant Chowdhary jchowdhary@google.com 2018-09-12T00:15:08+00:00 b178762cf7a93842de56fa0d7a153e0694543821 This can be useful when common code can be executed by both hwbinder and binder threads, and, they want to access (hardware::)IPCThreadState specific information. Eg: cameraserver. Bug: 110364143 Test: mm -j64 Test: Boot device, use GCA Change-Id: I8e7c6beab857d2dcb4b7d55053307634f7d830c4 Signed-off-by: Jayant Chowdhary <jchowdhary@google.com> 
This can be useful when common code can be executed by both hwbinder and
binder threads, and, they want to access (hardware::)IPCThreadState
specific information. Eg: cameraserver.

Bug: 110364143

Test: mm -j64
Test: Boot device, use GCA

Change-Id: I8e7c6beab857d2dcb4b7d55053307634f7d830c4
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
Modernize codebase by replacing NULL with nullptr 2018-07-24T08:20:52+00:00 Yi Kong yikong@google.com 2018-07-24T08:20:52+00:00 bf1e65cf98a15ceff99ca56d5a9af1fa90673471 am: 55d4107c06 Change-Id: I77cb3c205454b5500508c48c0768c5611cfc13b4 
am: 55d4107c06

Change-Id: I77cb3c205454b5500508c48c0768c5611cfc13b4
Modernize codebase by replacing NULL with nullptr 2018-07-23T21:55:39+00:00 Yi Kong yikong@google.com 2018-07-23T21:55:39+00:00 55d4107c06fb0dc4051a3039174fbba36968f108 Fixes -Wzero-as-null-pointer-constant warning. Test: m Bug: 68236239 Change-Id: I23c4346097d1e7cfbbd7225913a4d187a05f7506 
Fixes -Wzero-as-null-pointer-constant warning.

Test: m
Bug: 68236239
Change-Id: I23c4346097d1e7cfbbd7225913a4d187a05f7506
Create temp refs on proxies. 2018-05-25T00:06:22+00:00 Martijn Coenen maco@google.com 2018-05-25T00:06:22+00:00 b2f9e3c0c08e388027d26d6638febffa402de5a2 am: b825372059 Change-Id: I98c39be7817dc0ad081d91d3b5135e6e1af3981a 
am: b825372059

Change-Id: I98c39be7817dc0ad081d91d3b5135e6e1af3981a
Create temp refs on proxies. 2018-05-23T19:57:32+00:00 Martijn Coenen maco@google.com 2018-05-23T13:33:22+00:00 b825372059de634f05ea3a2834b9a7fed0187243 Fixes the following scenario: 1) Thread T1 receives a binder proxy and adds a local strong/weak ref 2) Thread T1 queues BC_ACQUIRE/BC_INCREFS (but does not flush) 3) Thread T1 hands the binder proxy off to another thread T2, which adds another strong ref 4) Thread T1 now drops its own ref to the proxy, but it doesn't get destructed because T2 has its own ref to it 6) Thread T2 runs and drops its own ref to the proxy, which causes a BC_RELEASE/BC_DECREFS to be queued to the driver. Now, if T1 writes its command queue to the driver first, everything is fine, because a BC_ACQUIRE/BC_INCREFS will be followed by a BC_RELEASE/BC_DECREFS. However if T2 writes its command queue first, BC_RELEASE/BC_DECREFS will be sent first, and the driver will delete the reference prematurely. Fix this by temporarily holding a weak/strong ref until the initial BC_ACUIRE/BC_INCREFS is flushed to the driver. Bug: 78437964 Test: sailfish builds, boots, no invalid ref messages on dumpsys Change-Id: I127b85e12a415a1a1ca6e7082e2049513a347f9b 
Fixes the following scenario:
1) Thread T1 receives a binder proxy and adds a local strong/weak ref
2) Thread T1 queues BC_ACQUIRE/BC_INCREFS (but does not flush)
3) Thread T1 hands the binder proxy off to another thread T2, which
   adds another strong ref
4) Thread T1 now drops its own ref to the proxy, but it doesn't get
   destructed because T2 has its own ref to it
6) Thread T2 runs and drops its own ref to the proxy, which causes a
   BC_RELEASE/BC_DECREFS to be queued to the driver.

Now, if T1 writes its command queue to the driver first, everything
is fine, because a BC_ACQUIRE/BC_INCREFS will be followed by a
BC_RELEASE/BC_DECREFS. However if T2 writes its command queue first,
BC_RELEASE/BC_DECREFS will be sent first, and the driver will delete
the reference prematurely.

Fix this by temporarily holding a weak/strong ref until the initial
BC_ACUIRE/BC_INCREFS is flushed to the driver.

Bug: 78437964
Test: sailfish builds, boots, no invalid ref messages on dumpsys
Change-Id: I127b85e12a415a1a1ca6e7082e2049513a347f9b
Remove disableBackgroundScheduling. am: 8c3f4bd895 2018-05-09T00:28:00+00:00 Steven Moreland smoreland@google.com 2018-05-09T00:28:00+00:00 89946ae44d615c0b5a50ac5e06e4cf0c396baeda am: 10c1bdd6cc Change-Id: I74692706c1ca2ad11c55a8ae285ceda66180dced 
am: 10c1bdd6cc

Change-Id: I74692706c1ca2ad11c55a8ae285ceda66180dced
Remove disableBackgroundScheduling. 2018-05-08T00:24:24+00:00 Steven Moreland smoreland@google.com 2018-05-07T22:45:23+00:00 8c3f4bd89581e11ad40895511c0aeaa429e42631 This function is a no-oop. It is made private for now since it is still referenced by one device's prebuilts. Bug: 66905301 Test: m Change-Id: Ibf5b34b0c07decd4a7676caa4d4011ea824d0679 
This function is a no-oop.

It is made private for now since it is still referenced by
one device's prebuilts.

Bug: 66905301
Test: m
Change-Id: Ibf5b34b0c07decd4a7676caa4d4011ea824d0679
IPCThreadState: addPostCommandTask am: d7bbfdbd90 2018-05-03T21:26:05+00:00 Steven Moreland smoreland@google.com 2018-05-03T21:26:05+00:00 299769393d804b599517cf6e0017ee63c23d8297 am: 7779a98065 Change-Id: Icb4d6db16944e48c86c55659a2cda3e831927d1b 
am: 7779a98065

Change-Id: Icb4d6db16944e48c86c55659a2cda3e831927d1b