summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Maximum value of uint32_t should be UINT32_MAX instead of ULONG_MAXandroid11-devAutomerger Merge Worker2020-03-101-1/+1
| | | | | | | | | | | Fixes tautological-constant-out-of-range-compare warning. Bug: 72331526 Test: presubmit AOSP-Change: 1173604 Change-Id: Ie71f5a57fad298a9cb035b5e7430af617b438ab8 Merged-In: Ie71f5a57fad298a9cb035b5e7430af617b438ab8 (cherry picked from commit 7c0e9992d953850fd08c1f0f26cc3dcc24c61c4f)
* Make libapf compile against the NDK. am: 6ef6218a98 am: 991babe7e3 am: ↵Automerger Merge Worker2020-02-041-1/+1
|\ | | | | | | | | | | 9d9e852f62 Change-Id: I07e0c627a037913367035218d4a4746b0e57f92f
| * Make libapf compile against the NDK. am: 6ef6218a98 am: 991babe7e3Automerger Merge Worker2020-02-041-1/+1
| |\ | | | | | | | | | Change-Id: I46b2f09ed605e8d9c5960cd33a206ca880d448cf
| | * Make libapf compile against the NDK. am: 6ef6218a98Automerger Merge Worker2020-02-041-1/+1
| |/| | | | | | | | | | Change-Id: I847d80b9195ce5e43b4e2f880b3b01eaacdcf5fe
| | * Make libapf compile against the NDK.android-r-preview-1Lorenzo Colitti2020-02-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | libapf is intended to be run on wireless chipsets so it must never depend on Android platform internals. Set it to the SDK version that was current when the interpreter was written. Test: m libapf Bug: 148753875 Change-Id: Ib20aa28f37f344032b0cc4fc104bda6a3b5a5919
* | | Fix apf_run disassembler output. am: cdb38a5e3e am: 1f847f05d8Lorenzo Colitti2019-11-023-75/+75
|\| | | | | | | | | | | | | | | | | am: e5187d1a68 Change-Id: If8fd164050e13380f9925fda353debfe65e3f30b
| * | Fix apf_run disassembler output. am: cdb38a5e3eLorenzo Colitti2019-11-023-75/+75
| |\| | | | | | | | | | | | | | | | am: 1f847f05d8 Change-Id: I00c4097fd4df98d95263ba6141dc2f819172b69e
| | * Fix apf_run disassembler output.Lorenzo Colitti2019-11-023-75/+75
| | |\ | | | | | | | | | | | | | | | | | | | | am: cdb38a5e3e Change-Id: Id6afb62561ed5fb8cca7fc01ed78e4e8140b14ac
| | | * Fix apf_run disassembler output.Lorenzo Colitti2019-11-023-75/+75
| | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The change to print disassembled code in apf_run (aosp/1129074) broke the output of apf_run by printing PC, R0, PC instead of R0, R1, PC. This was noticed because compiling the code with -O0 (which happened when I put apf_run.c into a test target) results in a compiler error. Unfortunately the error goes away with the default compiler settings and -Werror=format-extra-args does not help. Test: existing tests were incorrect, modified Change-Id: Iad1713ce253b5df62ad5cd42b6ddff28559dda8c
* | | Add TEST_MAPPING for the APF low-level code. am: 74ede83c56 am: fed006431b ↵Lorenzo Colitti2019-10-192-0/+10
|\| | | | | | | | | | | | | | | | | | | | | | | am: 33a1edf8ec am: 9d5cf97e14 Change-Id: Ie772087162a9be5fa2fcdbb8dc3973ba67ee21a6
| * | Add TEST_MAPPING for the APF low-level code. am: 74ede83c56 am: fed006431bLorenzo Colitti2019-10-192-0/+10
| |\ \ | | | | | | | | | | | | | | | | | | | | am: 33a1edf8ec Change-Id: I0b08c923425a1a809dec79d47e7ee82863193708
| | * | Add TEST_MAPPING for the APF low-level code. am: 74ede83c56Lorenzo Colitti2019-10-192-0/+10
| | |\| | | | | | | | | | | | | | | | | | | | | am: fed006431b Change-Id: Ifca1a1f8f95f83a02128f500c122332ac5eda551
| | | * Add TEST_MAPPING for the APF low-level code.Lorenzo Colitti2019-10-192-0/+10
| | | |\ | | | | | | | | | | | | | | | | | | | | | | | | | am: 74ede83c56 Change-Id: Ic3962d1c8bad5f233c983e1718ba72a9ff454e38
| | | | * Add TEST_MAPPING for the APF low-level code.Lorenzo Colitti2019-10-162-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, this will run NetworkStackTests (which run the interpreter) and apf_run_test (which runs the disassembler). Also disable apf_run_test on Windows because it's a shell script that relies on bash. Bug: 66928272 Test: treehugger Change-Id: I0773887604a2c41e63e4c6c629ad81c3e6143bcc
* | | | | Add some tests for apf_run. am: 26dafcd858 am: 37e5280ee8 am: ad57e39f07Lorenzo Colitti2019-10-1510-0/+160
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 42383d6a21 Change-Id: I61caf48b26408d947591047a4ac20985a47509ea
| * | | | Add some tests for apf_run. am: 26dafcd858 am: 37e5280ee8Lorenzo Colitti2019-10-1510-0/+160
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | am: ad57e39f07 Change-Id: Ic83594bf763945c0f0f616bc9c0acb83605fc87a
| | * | | Add some tests for apf_run. am: 26dafcd858Lorenzo Colitti2019-10-1510-0/+160
| | |\| | | | | | | | | | | | | | | | | | | | | | | | | | | am: 37e5280ee8 Change-Id: I8f538f1b2534056b8507a70913c1652bc468e5c0
| | | * | Add some tests for apf_run.Lorenzo Colitti2019-10-1510-0/+160
| | | |\| | | | | | | | | | | | | | | | | | | | | | | | | | am: 26dafcd858 Change-Id: Ib28de45a785965e930b92362b5b22a454a01f9b5
| | | | * Add some tests for apf_run.Lorenzo Colitti2019-10-1410-0/+160
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These tests cover both apf_run itself and the disassembler (and of course the interpreter). Test: atest apf_run_test Change-Id: I622bb2bbd0ec48bdddb511963c374651705ff545
* | | | | Print disassembled code in apf_run. am: 983eb51423 am: da6a0ef335 am: 18ce213d82Lorenzo Colitti2019-10-156-198/+272
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 687dc350f8 Change-Id: Ica93341d77ce0183751365357d1e74fb26b47813
| * | | | Print disassembled code in apf_run. am: 983eb51423 am: da6a0ef335Lorenzo Colitti2019-10-156-198/+272
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 18ce213d82 Change-Id: If1e9925d21ba40e674164f67cc4dfd1058e3d26f
| | * | | Print disassembled code in apf_run. am: 983eb51423Lorenzo Colitti2019-10-156-198/+272
| | |\| | | | | | | | | | | | | | | | | | | | | | | | | | | am: da6a0ef335 Change-Id: Idab03998dda6a8f99889d6a6892eba825a931862
| | | * | Print disassembled code in apf_run.Lorenzo Colitti2019-10-156-198/+272
| | | |\| | | | | | | | | | | | | | | | | | | | | | | | | | am: 983eb51423 Change-Id: I43418a911de2c0c0bf0f2ca56720aba3b974127e
| | | | * Print disassembled code in apf_run.Lorenzo Colitti2019-10-146-198/+272
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | apf_run is a great tool to debug APF programs, but it does not currently print disassemled code. Fix this. Before: PC: 0 R0: 0 R1: 0 PC: 2 R0: 86dd R1: 0 PC: 7 R0: 86dd R1: 0 PC: 64 R0: 86dd R1: 0 PC: 141 R0: 86dd R1: 0 After: R0 R1 PC Instruction ------------------------------------------------- 0 0 0: ldh r0, [12] 2 86dd 2: jlt r0, 0x600, drop 7 86dd 7: jne r0, 0x806, 64 40 86dd 64: jne r0, 0x800, 141 8d 86dd 141: jeq r0, 0x86dd, 161 ... Bug: 66928272 Test: manually compared output on a sample program Change-Id: I1b93f70e0381d6e43d7f7d9785ab8c935baa1e4b
* | | | | Enable stricter compiler warnings am: 90cde57df6 am: f8f0959556 am: 28176c5731Bernie Innocenti2019-10-082-1/+7
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 377554ff83 Change-Id: If4e1ef9465257e94a1ea9cd32452c2d166a09721
| * | | | Enable stricter compiler warnings am: 90cde57df6 am: f8f0959556Bernie Innocenti2019-10-082-1/+7
|/| | | | | |/ / / | | | | | | | | | | | | | | | | am: 28176c5731 Change-Id: Ie7d5c581c4f9dab5750bb35f487fbce7c96b9e30
| * / / Enable stricter compiler warnings am: 90cde57df6Bernie Innocenti2019-10-082-1/+7
|/| | | | |/ / | | | | | | | | | | | | am: f8f0959556 Change-Id: I184e4a24c19ec7d3cfdc604899549c87305db471
| * / Enable stricter compiler warningsBernie Innocenti2019-10-082-1/+7
|/| | | |/ | | | | | | | | am: 90cde57df6 Change-Id: Ia4e4f9ccd4e482dfe74c4292c628a4470ad3a6c5
| * Enable stricter compiler warningsndk-sysroot-r21Bernie Innocenti2019-10-082-1/+7
|/ | | | | Test: m apf_run apf_disassembler libapf Change-Id: I43b975a6afa11f693268317de69967e7774a1c85
* Revert "Enable the clang-format hook for hardware/google/apf" am: 6f73fbb3a0 ↵android-mainline-10.0.0_r9android-mainline-10.0.0_r4android-mainline-10.0.0_r10android-10.0.0_r9android-10.0.0_r8android-10.0.0_r7android-10.0.0_r45android-10.0.0_r44android-10.0.0_r43android-10.0.0_r42android-10.0.0_r41android-10.0.0_r40android-10.0.0_r39android-10.0.0_r38android-10.0.0_r37android-10.0.0_r36android-10.0.0_r35android-10.0.0_r34android-10.0.0_r33android-10.0.0_r32android-10.0.0_r31android-10.0.0_r30android-10.0.0_r29android-10.0.0_r28android-10.0.0_r27android-10.0.0_r26android-10.0.0_r25android-10.0.0_r24android-10.0.0_r23android-10.0.0_r22android-10.0.0_r21android-10.0.0_r20android-10.0.0_r19android-10.0.0_r18android-10.0.0_r16android-10.0.0_r15android-10.0.0_r14android-10.0.0_r13android-10.0.0_r12android10-qpr3-s1-releaseandroid10-qpr3-releaseandroid10-qpr2-s4-releaseandroid10-qpr2-s3-releaseandroid10-qpr2-s2-releaseandroid10-qpr2-s1-releaseandroid10-qpr2-releaseandroid10-qpr1-releaseandroid10-qpr1-mainline-releaseandroid10-qpr1-d-releaseandroid10-qpr1-c-s1-releaseandroid10-qpr1-c-releaseandroid10-qpr1-b-s1-releaseandroid10-qpr1-b-releaseandroid10-mainline-media-releaseandroid10-devandroid10-d4-s1-releaseandroid10-d4-releaseandroid10-c2f2-s2-releaseandroid10-c2f2-s1-releaseandroid10-c2f2-releaseBernie Innocenti2019-03-083-7/+0
|\ | | | | | | | | | | | | | | am: 3ae28a202f am: b8a466afd4 Change-Id: Ie06a6071c83e0596a3d130053a0c3d9c8be017d8
| * Revert "Enable the clang-format hook for hardware/google/apf" am: 6f73fbb3a0Bernie Innocenti2019-03-083-7/+0
| |\ | | | | | | | | | | | | | | | am: 3ae28a202f Change-Id: I7ac3ecc4b254f56fa98962f4c09b8f7c33b414a5
| | * Revert "Enable the clang-format hook for hardware/google/apf"android-o-mr1-iot-release-1.0.14android-o-mr1-iot-release-1.0.13Bernie Innocenti2019-03-083-7/+0
| | |\ | | | | | | | | | | | | | | | | | | | | am: 6f73fbb3a0 Change-Id: Ib577d2959588e0e1cd6301fcf129d3347c1f3f6f
| | | * Revert "Enable the clang-format hook for hardware/google/apf"android-q-preview-6android-q-preview-5android-q-preview-4android-q-preview-2.5android-q-preview-1android-o-mr1-iot-release-1.0.12android-o-mr1-iot-release-1.0.10oreo-mr1-iot-releaseBernie Innocenti2019-02-223-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2af4ba42b5e3e9e16765979d169c7c6fe49e603d. Reason for revert: APF uses a mix of 2-space and 4-space indentation, and clang-format doesn't support this. Re-indenting the entire codebase would interferes with 'git blame' and cause annoying merge conflicts. Change-Id: If77e4e2f189549cfd0635b52a32c89f14b8f99cf
* | | | Merge stage-aosp-master into pi-dev-plus-aospXin Li2019-02-250-0/+0
|\| | | | | | | | | | | | | | | | | | | | | | | am: ee8232b1c0 Change-Id: I7bd1d151e9791c09ad2e77986b64f246823778e7
| * | | Merge stage-aosp-master into pi-dev-plus-aospXin Li2019-02-250-0/+0
| |\| | | | | | | | | | | | | | | | | | Bug: 126125118 Change-Id: I9ad60eb896816eb533b0c364d3cb34b23aee28e5
| | * | Merge "DO NOT MERGE - Merge pi-dev@5234907 into stage-aosp-master" into ↵Xin Li2019-02-210-0/+0
| | |\ \ | | | | | | | | | | | | | | | stage-aosp-master
| | | * \ DO NOT MERGE - Merge pi-dev@5234907 into stage-aosp-masterXin Li2019-02-200-0/+0
| | | |\ \ | | | | | | | | | | | | | | | | | | | | | | | | Bug: 120848293 Change-Id: I5c91808a99e0412fd00de3b2a6ab0428417abd97
* | | | | | Enable the clang-format hook for hardware/google/apf am: 2af4ba42b5 am: ↵Bernie Innocenti2019-02-203-0/+7
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 39492ba12d am: 98acc3d25c Change-Id: Iea9148ec580b54b28736d2ac7583caa90e122252
| * | | | | Enable the clang-format hook for hardware/google/apf am: 2af4ba42b5Bernie Innocenti2019-02-203-0/+7
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 39492ba12d Change-Id: I03bde339794a63f5625687381fbbf2d01d32ade7
| | * | | | Enable the clang-format hook for hardware/google/apfBernie Innocenti2019-02-203-0/+7
| | |\ \ \ \ | | | |/ / / | | |/| | / | | | | |/ | | | |/| | | | | | am: 2af4ba42b5 Change-Id: I62ba263cd1c12ed1ae678c361c4086175f30f2b6
| | | * | Enable the clang-format hook for hardware/google/apfBernie Innocenti2019-02-143-0/+7
| | | | | | | | | | | | | | | | | | | | Change-Id: Ia98bf4f7e030541e1062effb8ba2ab8fd6e6050e
* | | | | Add basic execution tracing support to apf_run am: d0174a67d8 am: adf9750f28Bernie Innocenti2019-02-123-63/+95
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 87a315aff4 Change-Id: I1a7f254bf42a8b4939fbbf39e946cf862f1bccc4
| * | | | Add basic execution tracing support to apf_run am: d0174a67d8Bernie Innocenti2019-02-123-63/+95
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | am: adf9750f28 Change-Id: I898b468a2ed6bde1c8546bd74d7f091de01fc606
| | * | | Add basic execution tracing support to apf_runBernie Innocenti2019-02-123-63/+95
| | |\| | | | | | | | | | | | | | | | | | | | | | | | | | | am: d0174a67d8 Change-Id: I2e879d7f42469f98efaa7ba6aadb63fa8ddef268
| | | * | Add basic execution tracing support to apf_runBernie Innocenti2019-02-123-63/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds a --trace option to apf_run which dumps the PC and register content during execution. This is a big aid in debugging misbehaving APF programs. It should be easy to disassemble the current instruction inline if we refactor apf_disassembler to extract its body to a separate function. Another easy feature would be dumping the memory locations that were modified by the previous instruction. Test: apf_run --trace --program <program> --packet <packet> --data <data> Change-Id: I2a24bdfb84ce4e86409542332ee32082988a7698
* | | | | Consolidate OWNERS to platform/system/netd:/OWNERS am: 5698836c72 am: 49b916a860Bernie Innocenti2019-02-051-3/+1
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 71413c43c6 Change-Id: I1e500c6de4b07508041b70de924d13fe9b7bfeeb
| * | | | Consolidate OWNERS to platform/system/netd:/OWNERS am: 5698836c72Bernie Innocenti2019-02-051-3/+1
| |\| | | | | |_|/ | |/| | | | | | | | | | | | | | am: 49b916a860 Change-Id: Idb29fb501066048ead2e378969de2bc19edba7e3
| | * | Consolidate OWNERS to platform/system/netd:/OWNERSBernie Innocenti2019-02-051-3/+1
| | |\| | | | | | | | | | | | | | | | | | | | | am: 5698836c72 Change-Id: I3ca8d27fd11721660bae27698367106d6488b86f
| | | * Consolidate OWNERS to platform/system/netd:/OWNERSBernie Innocenti2019-02-061-3/+1
| | | | | | | | | | | | | | | | | | | | Test: build/make/tools/checkowners.py hardware/google/apf/OWNERS Change-Id: Ie6c815257523666740d0c648761083b357dd4cac
* | | | Disable apf_run on darwin am: b7af00686b am: 30f80adf19Aaron Huang2018-12-101-0/+5
|\| | | | | | | | | | | | | | | | | | | | | | | am: f03e5d7819 Change-Id: Ie33ffe7d1a8f57c7d8c4cf0f1383a889e2748fb9