From 021e5c70160c9682e8d8ab6e2c36a3cb3f57604a Mon Sep 17 00:00:00 2001 From: Ben Wagner Date: Wed, 18 Oct 2017 18:09:37 +0000 Subject: Revert "Add an Option for orientation on JPEG encodes" This reverts commit 5411a60e0d7370a5d47b5049de845a06fe52e98b. Reason for revert: ASAN and Coverage failing: https://chromium-swarm.appspot.com/task?id=394978f3b7d44610 Flutter_Android failing. Original change's description: > Add an Option for orientation on JPEG encodes > > Move Origin to its own header so that SkPixmap and SkJpegEncoder need > not depend on SkCodec. > > Add libexif, which is already used by Android, and use it to write the > orientation. Write a makefile based on the Android.bp in Android, minus > warnings. (libexif has an LGPL license.) > > Add a test that verifies all the orientations work. > > Optionally enable writing the orientation (and therefore including > libexif). Chromium does not currently need it, and Android does not > expose an API that would allow using it. Disable on Windows, where we > still have build errors to fix. > > Bug: skia:7138 > Change-Id: Iaeff44c36aebe0e639666979dc00e1b7594bbeb1 > Reviewed-on: https://skia-review.googlesource.com/60721 > Commit-Queue: Leon Scroggins > Reviewed-by: Mike Klein > Reviewed-by: Mike Reed TBR=mtklein@chromium.org,mtklein@google.com,scroggo@google.com,reed@google.com Change-Id: I05b7ae8d1c5bbd1de1642d9ef024943500256273 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7138 Reviewed-on: https://skia-review.googlesource.com/61620 Reviewed-by: Ben Wagner Commit-Queue: Ben Wagner --- third_party/libexif/BUILD.gn | 47 -------------------------------------------- 1 file changed, 47 deletions(-) delete mode 100644 third_party/libexif/BUILD.gn (limited to 'third_party') diff --git a/third_party/libexif/BUILD.gn b/third_party/libexif/BUILD.gn deleted file mode 100644 index 9bd6c72b28..0000000000 --- a/third_party/libexif/BUILD.gn +++ /dev/null @@ -1,47 +0,0 @@ -# Copyright 2017 Google Inc. -# -# Use of this source code is governed by a BSD-style license that can be -# found in the LICENSE file. - -declare_args() { - skia_use_system_exif = is_official_build -} - -import("../third_party.gni") - -if (skia_use_system_exif) { - system("libexif") { - libs = [ "exif" ] - } -} else { - third_party("libexif") { - public_include_dirs = [ "../externals/libexif" ] - - sources = [ - "../externals/libexif/libexif/canon/exif-mnote-data-canon.c", - "../externals/libexif/libexif/canon/mnote-canon-entry.c", - "../externals/libexif/libexif/canon/mnote-canon-tag.c", - "../externals/libexif/libexif/exif-byte-order.c", - "../externals/libexif/libexif/exif-content.c", - "../externals/libexif/libexif/exif-data.c", - "../externals/libexif/libexif/exif-entry.c", - "../externals/libexif/libexif/exif-format.c", - "../externals/libexif/libexif/exif-ifd.c", - "../externals/libexif/libexif/exif-loader.c", - "../externals/libexif/libexif/exif-log.c", - "../externals/libexif/libexif/exif-mem.c", - "../externals/libexif/libexif/exif-mnote-data.c", - "../externals/libexif/libexif/exif-tag.c", - "../externals/libexif/libexif/exif-utils.c", - "../externals/libexif/libexif/fuji/exif-mnote-data-fuji.c", - "../externals/libexif/libexif/fuji/mnote-fuji-entry.c", - "../externals/libexif/libexif/fuji/mnote-fuji-tag.c", - "../externals/libexif/libexif/olympus/exif-mnote-data-olympus.c", - "../externals/libexif/libexif/olympus/mnote-olympus-entry.c", - "../externals/libexif/libexif/olympus/mnote-olympus-tag.c", - "../externals/libexif/libexif/pentax/exif-mnote-data-pentax.c", - "../externals/libexif/libexif/pentax/mnote-pentax-entry.c", - "../externals/libexif/libexif/pentax/mnote-pentax-tag.c", - ] - } -} -- cgit v1.2.3