From 00fa04e5d40ed870fc1966209a64ee80fbae4cbf Mon Sep 17 00:00:00 2001 From: Adrian Cole Date: Tue, 10 Apr 2018 13:12:23 +0800 Subject: Clarifies implementation details on BinaryFormat (#1119) --- api/src/main/java/io/opencensus/trace/propagation/BinaryFormat.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'api') diff --git a/api/src/main/java/io/opencensus/trace/propagation/BinaryFormat.java b/api/src/main/java/io/opencensus/trace/propagation/BinaryFormat.java index da7ea4cc..9b6c9632 100644 --- a/api/src/main/java/io/opencensus/trace/propagation/BinaryFormat.java +++ b/api/src/main/java/io/opencensus/trace/propagation/BinaryFormat.java @@ -117,7 +117,7 @@ public abstract class BinaryFormat { * @since 0.7 */ public SpanContext fromByteArray(byte[] bytes) throws SpanContextParseException { - // Implementation must override this method. + // Implementation must override this method. If it doesn't, the below will StackOverflowError. try { return fromBinaryValue(bytes); } catch (ParseException e) { -- cgit v1.2.3