Error Prone: 2.2.0 -> 2.3.1

This commit contains several other changes as part of the upgrade:

- Use -XepAllDisabledChecksAsWarnings to enable all available warnings so
  that we don't need to enable each warning explicitly.

- Remove explicit suppression of warnings in generated code, since
  -XepDisableWarningsInGeneratedCode is now sufficient to suppress all warnings
  in AutoValue and Protocol Buffer generated classes.

- Remove a suppression of "ConstructorLeaksThis", since
  https://github.com/google/error-prone/pull/789 was fixed.

- Fix a few occurrences of "FieldCanBeFinal".

4 files changed, 0 insertions, 177 deletions

diff --git a/gradle/errorprone/experimental_errors b/gradle/errorprone/experimental_errors
deleted file mode 100644
index f791feda..00000000
--- a/gradle/errorprone/experimental_errors
+++ /dev/null
@@ -1,27 +0,0 @@
-errorProneExperimentalErrors = \
--Xep:AssistedInjectAndInjectOnSameConstructor:ERROR,\
--Xep:AutoFactoryAtInject:ERROR,\
--Xep:ClassName:ERROR,\
--Xep:ComparisonContractViolated:ERROR,\
--Xep:DepAnn:ERROR,\
--Xep:DivZero:ERROR,\
--Xep:EmptyIf:ERROR,\
--Xep:FuzzyEqualsShouldNotBeUsedInEqualsMethod:ERROR,\
--Xep:InjectInvalidTargetingOnScopingAnnotation:ERROR,\
--Xep:InjectMoreThanOneQualifier:ERROR,\
--Xep:InjectScopeAnnotationOnInterfaceOrAbstractClass:ERROR,\
--Xep:InjectScopeOrQualifierAnnotationRetention:ERROR,\
--Xep:InjectedConstructorAnnotations:ERROR,\
--Xep:InsecureCryptoUsage:ERROR,\
--Xep:IterablePathParameter:ERROR,\
--Xep:JMockTestWithoutRunWithOrRuleAnnotation:ERROR,\
--Xep:JavaxInjectOnFinalField:ERROR,\
--Xep:LockMethodChecker:ERROR,\
--Xep:LongLiteralLowerCaseSuffix:ERROR,\
--Xep:NoAllocation:ERROR,\
--Xep:NumericEquality:ERROR,\
--Xep:ParameterPackage:ERROR,\
--Xep:ProtoStringFieldReferenceEquality:ERROR,\
--Xep:RestrictTo:ERROR,\
--Xep:StaticOrDefaultInterfaceMethod:ERROR,\
--Xep:UnlockMethod:ERROR
diff --git a/gradle/errorprone/experimental_suggestions b/gradle/errorprone/experimental_suggestions
deleted file mode 100644
index d44049e9..00000000
--- a/gradle/errorprone/experimental_suggestions
+++ /dev/null
@@ -1,32 +0,0 @@
-# FieldMissingNullable is marked as WARN
-# detects errors in autovalue generated code.
-
-# ReturnMissingNullable is turned off because it
-# conflicts with Checker Framework null analysis.
-
-errorProneExperimentalSuggestions = \
--Xep:BooleanParameter:ERROR,\
--Xep:ConstantField:ERROR,\
--Xep:EmptySetMultibindingContributions:ERROR,\
--Xep:FieldMissingNullable:WARN,\
--Xep:LambdaFunctionalInterface:ERROR,\
--Xep:MethodCanBeStatic:ERROR,\
--Xep:MixedArrayDimensions:ERROR,\
--Xep:MultiVariableDeclaration:ERROR,\
--Xep:MultipleTopLevelClasses:ERROR,\
--Xep:MultipleUnaryOperatorsInMethodCall:ERROR,\
--Xep:PackageLocation:ERROR,\
--Xep:ParameterComment:ERROR,\
--Xep:ParameterNotNullable:ERROR,\
--Xep:PrivateConstructorForNoninstantiableModuleTest:ERROR,\
--Xep:PrivateConstructorForUtilityClass:ERROR,\
--Xep:RemoveUnusedImports:ERROR,\
--Xep:ReturnMissingNullable:OFF,\
--Xep:SwitchDefault:ERROR,\
--Xep:ThrowsUncheckedException:ERROR,\
--Xep:TypeParameterNaming:ERROR,\
--Xep:UngroupedOverloads:ERROR,\
--Xep:UnnecessarySetDefault:ERROR,\
--Xep:UnnecessaryStaticImport:ERROR,\
--Xep:UseBinds:ERROR,\
--Xep:WildcardImport:ERROR
diff --git a/gradle/errorprone/experimental_warnings b/gradle/errorprone/experimental_warnings
deleted file mode 100644
index 46e2371a..00000000
--- a/gradle/errorprone/experimental_warnings
+++ /dev/null
@@ -1,29 +0,0 @@
-# MutableMethodReturnType is turned off because it can suggest returning Guava
-# types from API methods (https://github.com/google/error-prone/issues/982).
-
-errorProneExperimentalWarnings = \
--Xep:AssertFalse:ERROR,\
--Xep:AssistedInjectAndInjectOnConstructors:ERROR,\
--Xep:BigDecimalLiteralDouble:ERROR,\
--Xep:BinderIdentityRestoredDangerously:ERROR,\
--Xep:BindingToUnqualifiedCommonType:ERROR,\
--Xep:ConstructorInvokesOverridable:ERROR,\
--Xep:ConstructorLeaksThis:ERROR,\
--Xep:EmptyTopLevelDeclaration:ERROR,\
--Xep:ExpectedExceptionChecker:ERROR,\
--Xep:FunctionalInterfaceClash:ERROR,\
--Xep:HardCodedSdCardPath:ERROR,\
--Xep:InconsistentOverloads:ERROR,\
--Xep:MissingDefault:ERROR,\
--Xep:MutableMethodReturnType:OFF,\
--Xep:NonCanonicalStaticMemberImport:ERROR,\
--Xep:PrimitiveArrayPassedToVarargsMethod:ERROR,\
--Xep:ProvidesFix:ERROR,\
--Xep:QualifierWithTypeUse:ERROR,\
--Xep:RedundantThrows:ERROR,\
--Xep:StaticQualifiedUsingExpression:ERROR,\
--Xep:StringEquality:ERROR,\
--Xep:StringSplit:ERROR,\
--Xep:TestExceptionChecker:ERROR,\
--Xep:UnnecessaryDefaultInEnumSwitch:ERROR,\
--Xep:Var:OFF
diff --git a/gradle/errorprone/warnings b/gradle/errorprone/warnings
deleted file mode 100644
index 3a8bb2f5..00000000
--- a/gradle/errorprone/warnings
+++ /dev/null
@@ -1,89 +0,0 @@
-# NarrowingCompoundAssignment is marked as WARN
-# detects errors in autovalue generated code.
-
-errorProneWarnings = \
--Xep:AmbiguousMethodReference:ERROR,\
--Xep:ArgumentSelectionDefectChecker:ERROR,\
--Xep:AssertEqualsArgumentOrderChecker:ERROR,\
--Xep:AssertionFailureIgnored:ERROR,\
--Xep:BadAnnotationImplementation:ERROR,\
--Xep:BadComparable:ERROR,\
--Xep:BoxedPrimitiveConstructor:ERROR,\
--Xep:CannotMockFinalClass:ERROR,\
--Xep:CanonicalDuration:ERROR,\
--Xep:CatchFail:ERROR,\
--Xep:ClassCanBeStatic:ERROR,\
--Xep:ClassNewInstance:ERROR,\
--Xep:CollectionToArraySafeParameter:ERROR,\
--Xep:CollectorShouldNotUseState:ERROR,\
--Xep:ComparableAndComparator:ERROR,\
--Xep:DateFormatConstant:ERROR,\
--Xep:DefaultCharset:ERROR,\
--Xep:DoubleCheckedLocking:ERROR,\
--Xep:EqualsHashCode:ERROR,\
--Xep:EqualsIncompatibleType:ERROR,\
--Xep:FallThrough:ERROR,\
--Xep:Finally:ERROR,\
--Xep:FloatCast:ERROR,\
--Xep:FloatingPointLiteralPrecision:ERROR,\
--Xep:FragmentInjection:ERROR,\
--Xep:FragmentNotInstantiable:ERROR,\
--Xep:FutureReturnValueIgnored:ERROR,\
--Xep:GetClassOnEnum:ERROR,\
--Xep:HidingField:ERROR,\
--Xep:ImmutableAnnotationChecker:ERROR,\
--Xep:ImmutableEnumChecker:ERROR,\
--Xep:IncompatibleModifiers:ERROR,\
--Xep:IncrementInForLoopAndHeader:ERROR,\
--Xep:InjectOnConstructorOfAbstractClass:ERROR,\
--Xep:InputStreamSlowMultibyteRead:ERROR,\
--Xep:InstanceOfAndCastMatchWrongType:ERROR,\
--Xep:IntLongMath:ERROR,\
--Xep:IterableAndIterator:ERROR,\
--Xep:JUnit3FloatingPointComparisonWithoutDelta:ERROR,\
--Xep:JUnit4ClassUsedInJUnit3:ERROR,\
--Xep:JUnitAmbiguousTestClass:ERROR,\
--Xep:JavaLangClash:ERROR,\
--Xep:JdkObsolete:ERROR,\
--Xep:LogicalAssignment:ERROR,\
--Xep:MissingCasesInEnumSwitch:ERROR,\
--Xep:MissingFail:ERROR,\
--Xep:MissingOverride:ERROR,\
--Xep:ModifyCollectionInEnhancedForLoop:ERROR,\
--Xep:MultipleParallelOrSequentialCalls:ERROR,\
--Xep:MutableConstantField:ERROR,\
--Xep:NarrowingCompoundAssignment:WARN,\
--Xep:NestedInstanceOfConditions:ERROR,\
--Xep:NonAtomicVolatileUpdate:ERROR,\
--Xep:NonOverridingEquals:ERROR,\
--Xep:NullableConstructor:ERROR,\
--Xep:NullablePrimitive:ERROR,\
--Xep:NullableVoid:ERROR,\
--Xep:OperatorPrecedence:ERROR,\
--Xep:OptionalNotPresent:ERROR,\
--Xep:OverrideThrowableToString:ERROR,\
--Xep:Overrides:ERROR,\
--Xep:OverridesGuiceInjectableMethod:ERROR,\
--Xep:ParameterName:ERROR,\
--Xep:PreconditionsInvalidPlaceholder:ERROR,\
--Xep:ProtoFieldPreconditionsCheckNotNull:ERROR,\
--Xep:QualifierOrScopeOnInjectMethod:ERROR,\
--Xep:ReachabilityFenceUsage:ERROR,\
--Xep:ReferenceEquality:ERROR,\
--Xep:RequiredModifiers:ERROR,\
--Xep:ShortCircuitBoolean:ERROR,\
--Xep:StaticGuardedByInstance:ERROR,\
--Xep:StringSplitter:ERROR,\
--Xep:SynchronizeOnNonFinalField:ERROR,\
--Xep:ThreadJoinLoop:ERROR,\
--Xep:ThreadLocalUsage:ERROR,\
--Xep:ThreeLetterTimeZoneID:ERROR,\
--Xep:TruthConstantAsserts:ERROR,\
--Xep:TypeParameterShadowing:ERROR,\
--Xep:TypeParameterUnusedInFormals:ERROR,\
--Xep:URLEqualsHashCode:ERROR,\
--Xep:UnsafeFinalization:ERROR,\
--Xep:UnsynchronizedOverridesSynchronized:ERROR,\
--Xep:UseCorrectAssertInTests:ERROR,\
--Xep:WaitNotInLoop:ERROR,\
--Xep:WakelockReleasedDangerously:ERROR