aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-02-06 01:28:55 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-02-06 01:28:55 +0000
commitb6c59f84fdc3be0b32c2306dce790e6135179b44 (patch)
treefc80a999c3ca5014a36190f7804c5cf3e4ac6770
parente8f6c07643a51695706628a696a85aeec455bdad (diff)
parentea5bcde008f7ef1704af3379e77c5d165bc114ea (diff)
downloadplatform_external_minijail-b6c59f84fdc3be0b32c2306dce790e6135179b44.tar.gz
platform_external_minijail-b6c59f84fdc3be0b32c2306dce790e6135179b44.tar.bz2
platform_external_minijail-b6c59f84fdc3be0b32c2306dce790e6135179b44.zip
minijail0: add minimalistic-mountns-nodev profile am: cc5917c757 am: c6dc29781f am: ea5bcde008
Change-Id: Ie46b8304bc4601cdd40c651673973c93e2f75f43
-rw-r--r--minijail0.14
-rw-r--r--minijail0_cli.c13
-rw-r--r--minijail0_cli_unittest.cc1
3 files changed, 13 insertions, 5 deletions
diff --git a/minijail0.1 b/minijail0.1
index 642c48cb..cab94ec2 100644
--- a/minijail0.1
+++ b/minijail0.1
@@ -309,6 +309,10 @@ The following sandboxing profiles are supported:
\fBminimalistic-mountns\fR
Set up a minimalistic mount namespace. Equivalent to \fB-v -P /var/empty
-b / -b /proc -b /dev/log -t -r --mount-dev\fR.
+.TP
+\fBminimalistic-mountns-nodev\fR
+Set up a minimalistic mount namespace with an empty /dev path. Equivalent to
+\fB-v -P /var/empty -b/ -b/proc -t -r\fR.
.SH IMPLEMENTATION
This program is broken up into two parts: \fBminijail0\fR (the frontend) and a helper
library called \fBlibminijailpreload\fR. Some jailings can only be achieved
diff --git a/minijail0_cli.c b/minijail0_cli.c
index 277c2224..f19a053a 100644
--- a/minijail0_cli.c
+++ b/minijail0_cli.c
@@ -376,7 +376,8 @@ static void use_profile(struct minijail *j, const char *profile,
{
/* Note: New profiles should be added in minijail0_cli_unittest.cc. */
- if (!strcmp(profile, "minimalistic-mountns")) {
+ if (!strcmp(profile, "minimalistic-mountns") ||
+ !strcmp(profile, "minimalistic-mountns-nodev")) {
minijail_namespace_vfs(j);
if (minijail_bind(j, "/", "/", 0)) {
fprintf(stderr, "minijail_bind(/) failed.\n");
@@ -386,11 +387,13 @@ static void use_profile(struct minijail *j, const char *profile,
fprintf(stderr, "minijail_bind(/proc) failed.\n");
exit(1);
}
- if (minijail_bind(j, "/dev/log", "/dev/log", 0)) {
- fprintf(stderr, "minijail_bind(/dev/log) failed.\n");
- exit(1);
+ if (!strcmp(profile, "minimalistic-mountns")) {
+ if (minijail_bind(j, "/dev/log", "/dev/log", 0)) {
+ fprintf(stderr, "minijail_bind(/dev/log) failed.\n");
+ exit(1);
+ }
+ minijail_mount_dev(j);
}
- minijail_mount_dev(j);
if (!*tmp_size) {
/* Avoid clobbering |tmp_size| if it was already set. */
*tmp_size = DEFAULT_TMP_SIZE;
diff --git a/minijail0_cli_unittest.cc b/minijail0_cli_unittest.cc
index 0d6a07d4..077f5f77 100644
--- a/minijail0_cli_unittest.cc
+++ b/minijail0_cli_unittest.cc
@@ -286,6 +286,7 @@ TEST_F(CliTest, valid_profile) {
// This should list all valid profiles.
const std::vector<std::string> profiles = {
"minimalistic-mountns",
+ "minimalistic-mountns-nodev",
};
for (const auto profile : profiles) {