platform_external_minijail/libminijail_unittest.cc, branch master

libminijail: localize internal APIs

2020-09-10T09:01:12+00:00

These aren't used outside of this module, so make sure they're all
marked static.  The symbols weren't being exported, but the compiler
wasn't able to optimize things as well.  This shrinks the library a
little bit.

Also delete the unused minijail_get_tmpfs_size helper.

Bug: None
Test: `make check` passes
Change-Id: Iec243430e7643062ce32b56a8d885561c1bd3db5

util: move unittests to the right module

2020-09-03T22:14:11+00:00

Move unittests specifically for util funcs to the util_unittest
module.  This makes it easier to check coverage.

Bug: None
Test: `make check` still passes
Change-Id: I8880f9f18ab1986b0389403090bce60a2d3f81d7

Set library path in unittest

2020-06-11T01:06:20+00:00

Tell minijail to use the locally built libminijailpreload.so file
instead of searching the system path when running this test.
The unittest can be run on a system without minijail installed and would
fail in that case, plus we should test the newly built preload library.

Before this change my github mirror's cli was upset because it didn't
have the lib installed and git CI was added this year.

Bug: None
Test: libminijail_unittest passes

Change-Id: I69d71b2f100ad6b9987ebca3d4d6ac1bbbb656dd

Add test minijail_preserve_fd_no_leak

2020-04-21T00:48:01+00:00

Added test to check if minijail_preserve_fd actually causes the original
file descriptor to be closed in the child process.

BUG=chromium:1071691
TEST=Run Minijail unit tests

Change-Id: Id123500f7132c12158d0974cd6c332bac34cd2ab

Allow passing environment also for LD_PRELOAD

2020-02-12T16:35:57+00:00

This expands support for passing an environment for the child process
also for the LD_PRELOAD case. The code now constructs the enviroment
for the child in a separate environment array for both code paths.
This also avoids messing with the parent's environment, which may have
unintended side effects.

BUG=chromium:1050997
TEST=New unit tests.

Change-Id: Ib05cad1d1ebe6e10d429501c8e467c3a53632753

minijail: Change some C-style casts to const_casts in unit tests

2019-10-28T00:54:11+00:00

Bug: None
Tests: Unit tests pass

Change-Id: Id0ed9e85821470eff597e65642df263b2f8793c7

Use *_no_preload in dup test.

2019-10-24T15:19:51+00:00

Otherwise when running the unit tests on Linux this test fails.

Bug: None
Test: make -j48 tests passes on gLinux.
Change-Id: Id6a8778fd4ff05190766579859227d042dfae1fb

Close original pipe end after dup2 in child process

2019-10-17T05:32:51+00:00

This avoids "leaking" duplicated file descriptors in the child process.

This also allows the child process to signal the end of its processing
by closing its stdout and stderr. This can now be reliably detected by
the parent process, if needed.

Bug: chromium:1009857
Test: Unit tests pass
Change-Id: Ie1cd4ff9e95f18e423df007f88bfff34456346f3

Made minijail_kill return the same code as minijail_wait

2019-10-16T09:17:03+00:00

Bug: chromium:1007557
Test: Unit tests pass
Change-Id: I26118292e0880a4ad2d39a0a59b0dd06ff338a52

minijail_wait returns 126 or 127 if execve fails in child process

2019-10-11T04:43:35+00:00

This is more consistent than returning 255.

See "Exit Status for Commands":
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_08_02

Bug: https://crbug.com/1012561
Change-Id: I1ab5c08628719f58b7395b0e55bc4a0b0032bd56
Tests: Unit tests pass