platform_external_minigbm/rockchip.c, branch master

Revert "Merge Android R"

2020-09-18T15:59:58+00:00

This reverts commit 25ff66748d4b08e7059aad06d967128681838fd4, reversing
changes made to 8884508fa662f8e2b11ea1639006fb0e17d65483.

Bug: b/161909468
Test: launch_cvd
Merged-In: I27f020b4f661890bcc2817deb09ffb9af1c76f1b
Change-Id: I9929f68d173fb4d11ca1983a3b4a67dabdd35cf8

minigbm: rockchip: remove KMS dependency

2020-02-18T22:37:24+00:00

Same reason has i915.

BUG=b:145747132
TEST=emerge-kevin minigbm

Change-Id: Id51c5e9e27a7bfae7db63730d637b8d5d0ff841f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/1976276
Tested-by: Gurchetan Singh 
Commit-Queue: Gurchetan Singh 
Reviewed-by: Gurchetan Singh 
Reviewed-by: Robert Tarasov

rockchip: align height in NV12 format

2020-01-20T12:08:04+00:00

This reverts commit b80c6b9737dc22e7b71ca684fa85e51953465512.

Thanks to crrev.com/c/1909686, camera HAL on scarlet can fill
camera content with arbitrary offsets. Remove the workaround
introduced in b80c6b9737dc22e7b71ca684fa85e51953465512.

BUG=b:140152839
TEST=GCA on scarlet
TEST=CCA on scarlet
Cq-Depend: chromium:1906454
Change-Id: I6782e713b8f5dd57c5cdf6d1217adc9f73b61ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/1999866
Reviewed-by: Gurchetan Singh 
Commit-Queue: Hirokazu Honda 
Tested-by: Hirokazu Honda 
Auto-Submit: Hirokazu Honda

Revert "Enable to allocate XBGR8888 with HW_VIDEO_ENCODER usage"

2019-12-04T11:50:39+00:00

This reverts commit aa6b072d4ce2d445e48b9978ac3f0bc73cd97176.

Reason for revert: This change is unnecessary because HW_VIDEO_ENCODER
usage is unmasked in crrev.com/c/1940034.

Original change's description:
> Enable to allocate XBGR8888 with HW_VIDEO_ENCODER usage
>
> crrev.com/c/1904910 masks the HW_VIDEO_ENCODER usage when
> BO_USE_HW_VIDEO_ENCODER is specified in gralloc. A camera stack allocates
> XBGR8888 buffer with BO_USE_HW_VIDEO_ENCODER usage in ARC++ video
> recording if the camera HAL version is V1. Thanks to crrev.com/c/1904910,
> it is necessary to enable to allocate XBGR8888 with HW_VIDEO_ENCODER usage.
>
> BUG=b:144135251
> TEST=Recording with GCA
>
> Change-Id: I61beee87a1531c0dea371861ffb31ce2189ef854
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/1934068
> Tested-by: Hirokazu Honda 
> Reviewed-by: Stéphane Marchesin 
> Commit-Queue: Hirokazu Honda 

Bug: b:144135251
Cq-Depend: chromium:1940034
Change-Id: I8d64c97399a601487fc84a6ecae337c235bd4464
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/1947685
Tested-by: Hirokazu Honda 
Auto-Submit: Hirokazu Honda 
Reviewed-by: Gurchetan Singh 
Commit-Queue: Hirokazu Honda

Enable to allocate XBGR8888 with HW_VIDEO_ENCODER usage

2019-11-27T10:37:55+00:00

crrev.com/c/1904910 masks the HW_VIDEO_ENCODER usage when
BO_USE_HW_VIDEO_ENCODER is specified in gralloc. A camera stack allocates
XBGR8888 buffer with BO_USE_HW_VIDEO_ENCODER usage in ARC++ video
recording if the camera HAL version is V1. Thanks to crrev.com/c/1904910,
it is necessary to enable to allocate XBGR8888 with HW_VIDEO_ENCODER usage.

BUG=b:144135251
TEST=Recording with GCA

Change-Id: I61beee87a1531c0dea371861ffb31ce2189ef854
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/1934068
Tested-by: Hirokazu Honda 
Reviewed-by: Stéphane Marchesin 
Commit-Queue: Hirokazu Honda

minigbm: rockchip/mediatek: add PROTECTED flag back in

2019-10-10T23:38:19+00:00

crrev.com/c/1643677 removed it, so we should add it back in.

BUG=b:141347335
TEST=GtsExoPlayerTestCases/GtsMediaTestCases

Change-Id: Ic49bd4158349da6170e8435c5c516954fe1646fa
Reviewed-on: https://chromium-review.googlesource.com/1821693
Tested-by: Gurchetan Singh 
Commit-Ready: Kazuhiro Inaba 
Legacy-Commit-Queue: Commit Bot 
Reviewed-by: Gurchetan Singh

minigbm: factor out metadata from struct bo

2019-09-24T17:23:42+00:00

Generated using coccinelle:

@@
struct bo *B;
@@

- B->width
+ B->width

BUG=chromium:924405
TEST=compile

Change-Id: I4da1731a650d198ce7f2bda3031a47b2f9c3041c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/1815566
Reviewed-by: Stéphane Marchesin 
Tested-by: Gurchetan Singh 
Legacy-Commit-Queue: Commit Bot

minigbm: rockchip/mediatek: remove R8 as texture source on Mali/Bifrost

2019-09-19T16:59:17+00:00

EGL can't import this format on Mali/Bifrost.

BUG=chromium:969044
TEST=Ozone unit test

Change-Id: I356ec2bd35030af600b268bf39565e30e16465f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/1643677
Reviewed-by: Stéphane Marchesin 
Tested-by: Gurchetan Singh 
Legacy-Commit-Queue: Commit Bot 
Commit-Queue: ChromeOS CL Exonerator Bot

rockchip: Don't align height in NV12 format

2019-09-13T03:31:38+00:00

crrev.com/c/1729176 corrected a wrong NV12 buffer allocation on rockchip. After
the CL, the width and height both are aligned by 16. Since GBM API doesn't
notify the aligned height to an application. The application must handle the
planes with offsets.

It turns out that Camera HAL on ChromeOS doesn't handle the allocated buffer
with offsets. In other words, it doesn't think of extra data between planes.
This causes, in a camera preview, a green line at bottom and a strange blue line
due to misposition of color planes.

This CL is a temproal workaround for the Camera HAL issue. This CL changes
minigbm implementation to not align height. This works because present video
encoder and decoder always calls GBM API with the height already aligned by
video driver. Note that a camera stack on encoding process will have to allocate
a proper buffer with non-aligned height in the future. This must be a temporal
workaround.

BUG=b:140152839
TEST=Confirm no green line in camera view and recorded video with Camera app
Change-Id: Ide53fa6801fc4bdabcfbe46004d01f5ab83a002f
Reviewed-on: https://chromium-review.googlesource.com/1775953
Tested-by: Hirokazu Honda 
Commit-Ready: Hirokazu Honda 
Legacy-Commit-Queue: Commit Bot 
Reviewed-by: Tomasz Figa

mediatek/rockchip: Use PRIu64 to print uint64_t variables

2019-09-02T00:19:31+00:00

Required to build for arm64 on mediatek, and let's fix the
rockchip one, while we're at it.

BUG=b:140228960
TEST=emerge-kevin-arc64 -av arc-cros-gralloc
TEST=emerge-kukui -av arc-cros-gralloc (with ARC++ 64-bit)

Change-Id: I8e04355a4d247b44ac86963331be72495655d321
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/1775949
Tested-by: Nicolas Boichat 
Auto-Submit: Nicolas Boichat 
Legacy-Commit-Queue: Commit Bot 
Reviewed-by: Gurchetan Singh 
Commit-Queue: Nicolas Boichat