From ddb433c41731fa1dc251a8e6d3bcf170cad803c5 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Thu, 15 Aug 2019 14:32:52 -0400 Subject: common-mk: generate-pc: add a defines field The linter doesn't like it when you put -D into cflags. We could make the linter understand the AST for this specific case, but that seems a bit error prone, so just extend the existing template to handle defines in the same way as other build targets. BUG=None TEST=libbrillo pc still works Change-Id: Ife556fa5d52d14108584e2c32a30eae887f52480 Reviewed-on: https://chromium-review.googlesource.com/1756106 Tested-by: Mike Frysinger Commit-Ready: ChromeOS CL Exonerator Bot Legacy-Commit-Queue: Commit Bot Reviewed-by: Eric Caruso Cr-Mirrored-From: https://chromium.googlesource.com/chromiumos/platform2 Cr-Mirrored-Commit: 35c34057dfcc99d76c64b66d212a6ad8dff3f01d --- BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILD.gn b/BUILD.gn index bbe5be6..e475692 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -248,7 +248,7 @@ generate_pkg_config("libbrillo_pc") { requires_private += sublib.all_dependent_pkg_deps } } - cflags = [ "-DUSE_RTTI_FOR_TYPE_TAGS" ] + defines = [ "USE_RTTI_FOR_TYPE_TAGS" ] libs = [ "-lbrillo-${libbase_ver}" ] } -- cgit v1.2.3