diff options
author | Alex Deymo <deymo@chromium.org> | 2016-05-12 12:57:46 -0700 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2016-05-17 18:35:32 -0700 |
commit | 605f5a1218d61339df2b4a0ddda3ecea402ab856 (patch) | |
tree | d4d7ae5b4b6e49f8a54ec2aeaf72846137bb9412 /brillo | |
parent | ed104e9c878bb5e1441a4a10eb00825270f8bd2e (diff) | |
download | platform_external_libbrillo-605f5a1218d61339df2b4a0ddda3ecea402ab856.tar.gz platform_external_libbrillo-605f5a1218d61339df2b4a0ddda3ecea402ab856.tar.bz2 platform_external_libbrillo-605f5a1218d61339df2b4a0ddda3ecea402ab856.zip |
Disable SimpleProcess.BindFdToSameFd test
This test is flaky in the Chromium OS builders since it fails when a
file descriptor number is big enough.
BUG=None
TEST=FEATURES=test emerge-link libbrillo
(cherry picked from commit ae40d5e67c6686d02918ba42686f94d45ac92f86)
Change-Id: If85de274539d379d39f0cb831361432ffd981876
Reviewed-on: https://chromium-review.googlesource.com/344601
Commit-Ready: Alex Deymo <deymo@chromium.org>
Tested-by: Alex Deymo <deymo@chromium.org>
Reviewed-by: Daniel Colish <colish@chromium.org>
Diffstat (limited to 'brillo')
-rw-r--r-- | brillo/process_unittest.cc | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/brillo/process_unittest.cc b/brillo/process_unittest.cc index 58e2f56..d2c92e6 100644 --- a/brillo/process_unittest.cc +++ b/brillo/process_unittest.cc @@ -79,7 +79,13 @@ TEST(SimpleProcess, BindFd) { EXPECT_EQ(std::string(kMsg) + "\n", std::string(buf)); } -TEST(SimpleProcess, BindFdToSameFd) { +// The test framework uses the device's dash shell as "sh", which doesn't +// support redirecting stdout to arbitrary large file descriptor numbers +// directly, nor has /proc mounted to open /proc/self/fd/NN. This test would +// fail if pipe.writer is big enough. +// TODO(deymo): Write a helper program that writes "hello_world" to the passed +// file descriptor and re-enabled this test. +TEST(DISABLED_SimpleProcess, BindFdToSameFd) { static const char* kMsg = "hello_world"; ScopedPipe pipe; ProcessImpl process; |