diff options
author | Marc R. Hoffmann <hoffmann@mountainminds.com> | 2014-07-15 18:46:10 +0200 |
---|---|---|
committer | Marc R. Hoffmann <hoffmann@mountainminds.com> | 2014-07-15 18:46:10 +0200 |
commit | 4b5d99b1db89f9e87ff3d7625f5e1f1b96411a29 (patch) | |
tree | 22d257e2677cd59fa5aedcad41435d47e6b20eae /org.jacoco.report/src/org/jacoco | |
parent | 5c23016d5e9afd7f1cff0f80e691dbb6b734e55b (diff) | |
download | platform_external_jacoco-4b5d99b1db89f9e87ff3d7625f5e1f1b96411a29.tar.gz platform_external_jacoco-4b5d99b1db89f9e87ff3d7625f5e1f1b96411a29.tar.bz2 platform_external_jacoco-4b5d99b1db89f9e87ff3d7625f5e1f1b96411a29.zip |
Fix Sonar warnings in JavaScript.
Diffstat (limited to 'org.jacoco.report/src/org/jacoco')
-rw-r--r-- | org.jacoco.report/src/org/jacoco/report/internal/html/resources/sort.js | 86 |
1 files changed, 43 insertions, 43 deletions
diff --git a/org.jacoco.report/src/org/jacoco/report/internal/html/resources/sort.js b/org.jacoco.report/src/org/jacoco/report/internal/html/resources/sort.js index 761af4a8..b43e83fe 100644 --- a/org.jacoco.report/src/org/jacoco/report/internal/html/resources/sort.js +++ b/org.jacoco.report/src/org/jacoco/report/internal/html/resources/sort.js @@ -20,22 +20,22 @@ * hash links */ function initialSort(linkelementids) { - window.linkelementids = linkelementids - var hash = window.location.hash + window.linkelementids = linkelementids; + var hash = window.location.hash; if (hash) { - var m = hash.match(/up-./) + var m = hash.match(/up-./); if (m) { - var header = window.document.getElementById(m[0].charAt(3)) + var header = window.document.getElementById(m[0].charAt(3)); if (header) { - sortColumn(header, true) + sortColumn(header, true); } - return + return; } - var m = hash.match(/dn-./) + var m = hash.match(/dn-./); if (m) { - var header = window.document.getElementById(m[0].charAt(3)) + var header = window.document.getElementById(m[0].charAt(3)); if (header) { - sortColumn(header, false) + sortColumn(header, false); } return } @@ -46,54 +46,54 @@ * Sorts the columns with the given header dependening on the current sort state. */ function toggleSort(header) { - var sortup = header.className.indexOf('down ') == 0 - sortColumn(header, sortup) + var sortup = header.className.indexOf('down ') == 0; + sortColumn(header, sortup); } /** * Sorts the columns with the given header in the given direction. */ function sortColumn(header, sortup) { - var table = header.parentNode.parentNode.parentNode - var body = table.tBodies[0] - var colidx = getNodePosition(header) + var table = header.parentNode.parentNode.parentNode; + var body = table.tBodies[0]; + var colidx = getNodePosition(header); - resetSortedStyle(table) + resetSortedStyle(table); - var rows = body.rows - var sortedrows = [] + var rows = body.rows; + var sortedrows = []; for (var i = 0; i < rows.length; i++) { - r = rows[i] - sortedrows[parseInt(r.childNodes[colidx].id.slice(1))] = r + r = rows[i]; + sortedrows[parseInt(r.childNodes[colidx].id.slice(1))] = r; } - var hash + var hash; if (sortup) { for (var i = sortedrows.length - 1; i >= 0; i--) { - body.appendChild(sortedrows[i]) + body.appendChild(sortedrows[i]); } - header.className = 'up ' + header.className - hash = 'up-' + header.id + header.className = 'up ' + header.className; + hash = 'up-' + header.id; } else { for (var i = 0; i < sortedrows.length; i++) { - body.appendChild(sortedrows[i]) + body.appendChild(sortedrows[i]); } - header.className = 'down ' + header.className - hash = 'dn-' + header.id + header.className = 'down ' + header.className; + hash = 'dn-' + header.id; } - setHash(hash) + setHash(hash); } /** * Adds the sort indicator as a hash to the document URL and all links. */ function setHash(hash) { - window.document.location.hash = hash - ids = window.linkelementids + window.document.location.hash = hash; + ids = window.linkelementids; for (var i = 0; i < ids.length; i++) { - setHashOnAllLinks(document.getElementById(ids[i]), hash) + setHashOnAllLinks(document.getElementById(ids[i]), hash); } } @@ -101,15 +101,15 @@ * Extend all links within the given tag with the given hash. */ function setHashOnAllLinks(tag, hash) { - links = tag.getElementsByTagName("a") + links = tag.getElementsByTagName("a"); for (var i = 0; i < links.length; i++) { - var a = links[i] - var href = a.href - var hashpos = href.indexOf("#") + var a = links[i]; + var href = a.href; + var hashpos = href.indexOf("#"); if (hashpos != -1) { - href = href.substring(0, hashpos) + href = href.substring(0, hashpos); } - a.href = href + "#" + hash + a.href = href + "#" + hash; } } @@ -119,10 +119,10 @@ function getNodePosition(element) { var pos = -1; while (element) { - element = element.previousSibling - pos++ + element = element.previousSibling; + pos++; } - return pos + return pos; } /** @@ -132,16 +132,16 @@ for (var c = table.tHead.firstChild.firstChild; c; c = c.nextSibling) { if (c.className) { if (c.className.indexOf('down ') == 0) { - c.className = c.className.slice(5) + c.className = c.className.slice(5); } if (c.className.indexOf('up ') == 0) { - c.className = c.className.slice(3) + c.className = c.className.slice(3); } } } } - window['initialSort'] = initialSort - window['toggleSort'] = toggleSort + window['initialSort'] = initialSort; + window['toggleSort'] = toggleSort; })();
\ No newline at end of file |