diff options
| author | Marc R. Hoffmann <hoffmann@mountainminds.com> | 2014-04-14 07:56:28 +0200 |
|---|---|---|
| committer | Marc R. Hoffmann <hoffmann@mountainminds.com> | 2014-04-14 08:02:27 +0200 |
| commit | 91e51b560798dd0927a21344b12c1de5a26049f7 (patch) | |
| tree | 697735e8288c6b3668fcb7d99c932eca9a2ecf51 | |
| parent | 488550f5176f005ab78b70fe7439db57f4a442ed (diff) | |
| download | platform_external_jacoco-91e51b560798dd0927a21344b12c1de5a26049f7.tar.gz platform_external_jacoco-91e51b560798dd0927a21344b12c1de5a26049f7.tar.bz2 platform_external_jacoco-91e51b560798dd0927a21344b12c1de5a26049f7.zip | |
Fix Sonar warnings: Use collection interfaces in declarations.
3 files changed, 9 insertions, 10 deletions
diff --git a/jacoco-maven-plugin/src/org/jacoco/maven/MergeMojo.java b/jacoco-maven-plugin/src/org/jacoco/maven/MergeMojo.java index d4dea88f..3912efc6 100644 --- a/jacoco-maven-plugin/src/org/jacoco/maven/MergeMojo.java +++ b/jacoco-maven-plugin/src/org/jacoco/maven/MergeMojo.java @@ -13,7 +13,7 @@ package org.jacoco.maven; import java.io.File; import java.io.IOException; -import java.util.ArrayList; +import java.util.List; import org.apache.maven.plugin.MojoExecutionException; import org.apache.maven.plugin.MojoFailureException; @@ -44,10 +44,10 @@ public class MergeMojo extends AbstractJacocoMojo { /** * This mojo accepts any number of execution data file sets. - * - * Note that you need an <tt>implementation</tt> hint on - * <tt>fileset</tt> with Maven 2 (not needed with Maven 3): - * + * + * Note that you need an <tt>implementation</tt> hint on <tt>fileset</tt> + * with Maven 2 (not needed with Maven 3): + * * <pre> * <code> * <fileSets> @@ -60,11 +60,11 @@ public class MergeMojo extends AbstractJacocoMojo { * </fileSets> * </code> * </pre> - * + * * @parameter expression="${jacoco.fileSets}" * @required */ - private ArrayList<FileSet> fileSets; + private List<FileSet> fileSets; @Override protected void executeMojo() throws MojoExecutionException, diff --git a/org.jacoco.report/src/org/jacoco/report/check/BundleChecker.java b/org.jacoco.report/src/org/jacoco/report/check/BundleChecker.java index 3e8a75f4..a6178c48 100644 --- a/org.jacoco.report/src/org/jacoco/report/check/BundleChecker.java +++ b/org.jacoco.report/src/org/jacoco/report/check/BundleChecker.java @@ -34,7 +34,7 @@ class BundleChecker { private final Collection<Rule> bundleRules; private final Collection<Rule> packageRules; private final Collection<Rule> classRules; - private final ArrayList<Rule> sourceFileRules; + private final Collection<Rule> sourceFileRules; private final Collection<Rule> methodRules; private final boolean traversePackages; diff --git a/org.jacoco.report/src/org/jacoco/report/internal/html/table/Table.java b/org.jacoco.report/src/org/jacoco/report/internal/html/table/Table.java index 7f3e2d78..d09cb87a 100644 --- a/org.jacoco.report/src/org/jacoco/report/internal/html/table/Table.java +++ b/org.jacoco.report/src/org/jacoco/report/internal/html/table/Table.java @@ -131,8 +131,7 @@ public class Table { private List<? extends ITableItem> sort( final List<? extends ITableItem> items) { if (defaultComparator != null) { - final ArrayList<ITableItem> result = new ArrayList<ITableItem>( - items); + final List<ITableItem> result = new ArrayList<ITableItem>(items); Collections.sort(result, defaultComparator); return result; } |