platform_external_elfutils/tests/run-ar.sh, branch master Unnamed repository; edit this file 'description' to name the repository. tests: Use #/usr/bin/env bash in scripts that use bash 2020-06-15T22:32:30+00:00 Mark Wielaard mark@klomp.org 2020-06-15T22:25:47+00:00 bca87ed8a200b8845e82b06fa94e69cd637dfea3 Some systems don't have bash in /bin. Signed-off-by: Mark Wielaard <mark@klomp.org> 
Some systems don't have bash in /bin.

Signed-off-by: Mark Wielaard <mark@klomp.org>
ar: Check whether ar header values fit. 2017-09-20T18:43:48+00:00 Mark Wielaard mark@klomp.org 2017-09-10T22:12:31+00:00 b10d7eb74064c5906f031cd17c0f82041c6a4ca1 When compiling with -O3 gcc finds an interesting error: src/ar.c: In function ‘do_oper_insert’: src/ar.c:1077:56: error: ‘%-*ld’ directive output may be truncated writing between 6 and 10 bytes into a region of size 7 [-Werror=format-truncation=] snprintf (tmpbuf, sizeof (tmpbuf), ofmt ? "%-*lo" : "%-*ld", bufsize, val); ^~~~~ The problem is that the ar header values have to fit in a limited (not zero terminated) string. We should check the snprintf return value to see if the values are representable. Also make ar valgrind and ubsan clean and add a minimal sanity test. Reported-by: Matthias Klose <doko@ubuntu.com> Signed-off-by: Mark Wielaard <mark@klomp.org> 
When compiling with -O3 gcc finds an interesting error:

src/ar.c: In function ‘do_oper_insert’:
src/ar.c:1077:56: error: ‘%-*ld’ directive output may be truncated writing between 6 and 10 bytes into a region of size 7 [-Werror=format-truncation=]
   snprintf (tmpbuf, sizeof (tmpbuf), ofmt ? "%-*lo" : "%-*ld", bufsize, val);
                                                        ^~~~~
The problem is that the ar header values have to fit in a limited
(not zero terminated) string. We should check the snprintf return
value to see if the values are representable.

Also make ar valgrind and ubsan clean and add a minimal sanity test.

Reported-by: Matthias Klose <doko@ubuntu.com>
Signed-off-by: Mark Wielaard <mark@klomp.org>